)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d62bb16e1a0b97ca3306e0fef5b48e183083c564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ea86744_0fab0021","updated":"2022-07-20 15:10:50.000000000","message":"Can confirm that this fixes the reporting in performance.json. Before this, all neutron things reported as \"v2.0\" and now show as \"networking\". Thanks slaweq!","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edc0db55858e5fb9917fa15bab7d27ca4b5da329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e27f5b8_8e0210ff","updated":"2022-08-02 00:02:55.000000000","message":"I see this is being merged but I\u0027m afraid there are a few problems we should address.","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1def70512b16ef45f9b2470b8200df479d090775","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fe7adff3_dab92697","updated":"2022-08-01 22:03:38.000000000","message":"recheck depends-on is merged now","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7f5a9131be08334e18b2591c8afaedbaf4d2e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bc3548b4_8daf0800","in_reply_to":"5ea86744_0fab0021","updated":"2022-07-22 08:49:07.000000000","message":"+1, https://a1110360d0aa5b1915ef-de0170061a4c33caf35d62b404ee94ad.ssl.cf5.rackcdn.com/849145/5/check/tempest-full-py3/d172088/controller/logs/performance.json","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"}],"lib/neutron":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edc0db55858e5fb9917fa15bab7d27ca4b5da329","unresolved":true,"context_lines":[{"line_number":115,"context_line":"NEUTRON_PHYSICAL_NETWORK\u003d${NEUTRON_PHYSICAL_NETWORK:-}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The name of the service in the endpoint URL"},{"line_number":118,"context_line":"NEUTRON_ENDPOINT_SERVICE_NAME\u003d${NEUTRON_ENDPOINT_SERVICE_NAME-\"networking\"}"},{"line_number":119,"context_line":"if [[ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" \u0026\u0026 -z \"$NEUTRON_ENDPOINT_SERVICE_NAME\" ]]; then"},{"line_number":120,"context_line":"    NEUTRON_ENDPOINT_SERVICE_NAME\u003d\"networking\""},{"line_number":121,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ee1c4bbd_cd0f965a","line":118,"range":{"start_line":118,"start_character":61,"end_line":118,"end_character":74},"updated":"2022-08-02 00:02:55.000000000","message":"seems : is mising before - .\n\nAlso, we should not make this default to networking, right ? It seems like this is effectively changing url used in non-wsgi deployment.","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5f4096668cdb34be21d349340cdd87ebc5e13c38","unresolved":true,"context_lines":[{"line_number":115,"context_line":"NEUTRON_PHYSICAL_NETWORK\u003d${NEUTRON_PHYSICAL_NETWORK:-}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The name of the service in the endpoint URL"},{"line_number":118,"context_line":"NEUTRON_ENDPOINT_SERVICE_NAME\u003d${NEUTRON_ENDPOINT_SERVICE_NAME-\"networking\"}"},{"line_number":119,"context_line":"if [[ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" \u0026\u0026 -z \"$NEUTRON_ENDPOINT_SERVICE_NAME\" ]]; then"},{"line_number":120,"context_line":"    NEUTRON_ENDPOINT_SERVICE_NAME\u003d\"networking\""},{"line_number":121,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4b493d4e_c7bc605d","line":118,"range":{"start_line":118,"start_character":61,"end_line":118,"end_character":74},"in_reply_to":"3ee1f082_b1d5fb23","updated":"2022-08-02 07:10:20.000000000","message":"Ahh, and reply to Your second question - yes, it is changing networking endpoint for non-wsgi deployments by default but I though that it will be easier to do it that way rather than changing in all job\u0027s definitions as this is \"only\" devstack so :)","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b296e73704849e2ecc8a4c43d7c2f3563b4360af","unresolved":true,"context_lines":[{"line_number":115,"context_line":"NEUTRON_PHYSICAL_NETWORK\u003d${NEUTRON_PHYSICAL_NETWORK:-}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The name of the service in the endpoint URL"},{"line_number":118,"context_line":"NEUTRON_ENDPOINT_SERVICE_NAME\u003d${NEUTRON_ENDPOINT_SERVICE_NAME-\"networking\"}"},{"line_number":119,"context_line":"if [[ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" \u0026\u0026 -z \"$NEUTRON_ENDPOINT_SERVICE_NAME\" ]]; then"},{"line_number":120,"context_line":"    NEUTRON_ENDPOINT_SERVICE_NAME\u003d\"networking\""},{"line_number":121,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3ee1f082_b1d5fb23","line":118,"range":{"start_line":118,"start_character":61,"end_line":118,"end_character":74},"in_reply_to":"ee1c4bbd_cd0f965a","updated":"2022-08-02 07:08:35.000000000","message":"no, it\u0027s not missing it. This operator will assign \"networking\" variable only in case if NEUTRON_ENDPOINT_SERVICE_NAME is undefined. This was needed for e.g. Grenade jobs when I had to set it explicitly to the empty string. Please check e.g. https://www.cyberciti.biz/faq/bash-ksh-if-variable-is-not-defined-set-default-variable/ for more details","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d97c9efb70022529c5cf65aa36fd6f97b01e07f","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The name of the service in the endpoint URL"},{"line_number":118,"context_line":"NEUTRON_ENDPOINT_SERVICE_NAME\u003d${NEUTRON_ENDPOINT_SERVICE_NAME-\"networking\"}"},{"line_number":119,"context_line":"if [[ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" \u0026\u0026 -z \"$NEUTRON_ENDPOINT_SERVICE_NAME\" ]]; then"},{"line_number":120,"context_line":"    NEUTRON_ENDPOINT_SERVICE_NAME\u003d\"networking\""},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"15f9d49e_fdfabd4b","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":80},"updated":"2022-08-02 00:14:34.000000000","message":"also, this does not allow us to set an empty value, and it is always overridden when NEUTRON_DEPLOY_MOD_WSGI is true. Is this expected ?","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b296e73704849e2ecc8a4c43d7c2f3563b4360af","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The name of the service in the endpoint URL"},{"line_number":118,"context_line":"NEUTRON_ENDPOINT_SERVICE_NAME\u003d${NEUTRON_ENDPOINT_SERVICE_NAME-\"networking\"}"},{"line_number":119,"context_line":"if [[ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" \u0026\u0026 -z \"$NEUTRON_ENDPOINT_SERVICE_NAME\" ]]; then"},{"line_number":120,"context_line":"    NEUTRON_ENDPOINT_SERVICE_NAME\u003d\"networking\""},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"2637463e_e1beef0e","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":80},"in_reply_to":"15f9d49e_fdfabd4b","updated":"2022-08-02 07:08:35.000000000","message":"Please see my comment above. It allows to set empty value explicitly and it works like that in Grenade jobs.","commit_id":"1a21ccbdf8eb66582a06f181f8c9af1f43bd52f5"}]}