)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b093cbc3b2a6d2ed2be222922fbbc9cdc3e14483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66dbbd80_545bfc1b","updated":"2022-10-25 21:38:23.000000000","message":"This mostly looks good to me; question inline.","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc71d5fd765cb8120e2581e6759c68bb7f0c5360","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b0bc374_fd71a780","updated":"2022-07-14 11:11:05.000000000","message":"recheck - devstack-platform-debian-bullseye POST_FAILURE","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"87f9e2a70daaa438c46efe687552dd48c7f5791c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f16f205_f0fdac77","updated":"2022-08-11 09:12:05.000000000","message":"recheck - neutron job failed to deploy neutron \u0026 the ceph job failed on compute and glance jobs, which are not related","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df03cd467a52c87da8edf5788d415ffb8dbec807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b0accb3_96065767","updated":"2024-12-17 21:44:41.000000000","message":"I agree with the concern though there is a less probability the given case will happen so +1 on this.","commit_id":"3d598043597a92cce829f238fbac259e9d8c461f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a7737b4f3190a588e90759be1c126bb37de8d555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d60d6aa1_a8a48f03","updated":"2024-02-09 15:07:43.000000000","message":"Just want to re-surface this, it\u0027s still worth doing.","commit_id":"3d598043597a92cce829f238fbac259e9d8c461f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a03ad0c0a5de068d96f7cdcee7c5ac468eb0d2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"604a17f7_7f35dbfe","updated":"2025-01-14 14:59:37.000000000","message":"I went ahead and addressed Dan\u0027s concern from PS4.  Having the conditional guard there can\u0027t hurt anything, and maybe we can finally get this sucker merged.","commit_id":"74489472d07ad5b8065d8e5f39cb7e9ad96c969d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fa117d543f5b43fae25174eb88ff80f7368954b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d7703cbc_2c425931","updated":"2025-01-14 15:37:47.000000000","message":"Would be nice if Software Factory waited to post votes until after https://review.opendev.org/c/openstack/devstack/+/937251 merges.","commit_id":"74489472d07ad5b8065d8e5f39cb7e9ad96c969d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7b66ba6bf543d0586096c19987817cf8438daf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf191be7_65892e25","updated":"2025-01-14 15:54:16.000000000","message":"forgot to add a \"fi\"","commit_id":"74489472d07ad5b8065d8e5f39cb7e9ad96c969d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f2728444f542f37c78e52fb61eff25fa75165d49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"93abca28_1df8b168","updated":"2025-01-22 16:32:02.000000000","message":"Now it looks fine, and the only raised concern was addressed","commit_id":"8e3f4c5ef8aa919ca3ee542ec107fcccbc038433"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3cd32cf217f8c3c36fbb0a6283feeb5ffd72ae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4b3b45c_c293e27d","updated":"2025-10-15 22:10:44.000000000","message":"PLEASE!!! let\u0027s get some traction on this.","commit_id":"c4340a64ee35b2b8b5395461b6702ef765786465"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"53c28e31981a1af581715c8fddfd156ba519f080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"14b0d8a4_09909454","updated":"2025-10-16 13:38:31.000000000","message":"looks OK for me form nova perspective","commit_id":"c4340a64ee35b2b8b5395461b6702ef765786465"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"964c4ca3b097fa634cf60cf4ccb85c1c2388389f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"031705e3_1ddc408e","updated":"2025-10-16 16:32:04.000000000","message":"recheck","commit_id":"c4340a64ee35b2b8b5395461b6702ef765786465"}],"lib/cinder":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b093cbc3b2a6d2ed2be222922fbbc9cdc3e14483","unresolved":true,"context_lines":[{"line_number":469,"context_line":"    if is_service_enabled nova; then"},{"line_number":470,"context_line":"        iniset $NOVA_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":471,"context_line":"    fi"},{"line_number":472,"context_line":"    if is_service_enabled g-api n-api; then"},{"line_number":473,"context_line":"        iniset $GLANCE_API_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":474,"context_line":"        iniset $GLANCE_CACHE_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":475,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cb5ee384_d992eec3","line":472,"range":{"start_line":472,"start_character":32,"end_line":472,"end_character":37},"updated":"2022-10-25 21:38:23.000000000","message":"This confuses me.  Why would we want to modify the glance config files if n-api is enabled but g-api is not?","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"94e9831a4fc762be32e60c9d457d055097196123","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    if is_service_enabled nova; then"},{"line_number":470,"context_line":"        iniset $NOVA_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":471,"context_line":"    fi"},{"line_number":472,"context_line":"    if is_service_enabled g-api n-api; then"},{"line_number":473,"context_line":"        iniset $GLANCE_API_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":474,"context_line":"        iniset $GLANCE_CACHE_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":475,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ec47f727_b9368f74","line":472,"range":{"start_line":472,"start_character":32,"end_line":472,"end_character":37},"in_reply_to":"cb5ee384_d992eec3","updated":"2023-03-06 16:48:54.000000000","message":"I don\u0027t understand your question.  This checks that both g-api and n-api are enabled, so it will never happen that n-api is enabled by g-api is not.\n\nThough now I\u0027m trying to remember why I wrote both services, because I don\u0027t know why would we care about n-api at all.\n\nIt makes sense that we only care about glance, so I\u0027ll change this.","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a7737b4f3190a588e90759be1c126bb37de8d555","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    if is_service_enabled nova; then"},{"line_number":470,"context_line":"        iniset $NOVA_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":471,"context_line":"    fi"},{"line_number":472,"context_line":"    if is_service_enabled g-api n-api; then"},{"line_number":473,"context_line":"        iniset $GLANCE_API_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":474,"context_line":"        iniset $GLANCE_CACHE_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":475,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"76541c9e_fc9f43f4","line":472,"range":{"start_line":472,"start_character":32,"end_line":472,"end_character":37},"in_reply_to":"ec47f727_b9368f74","updated":"2024-02-09 15:07:43.000000000","message":"is_service_enabled does an \u0027or\u0027 with multiple arguments ... only mentioning it because it\u0027s completely counterintuitive and really easy to miss in code \u0026 reviews.","commit_id":"e47dd104bdf7e0435d22cc81e7cf74009f0e9ee8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"46abeeb2c678dd15ea99f9058784d72676a706c2","unresolved":true,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"function init_os_brick {"},{"line_number":467,"context_line":"    mkdir -p $OS_BRICK_LOCK_PATH"},{"line_number":468,"context_line":"    iniset $CINDER_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":469,"context_line":"    if is_service_enabled nova; then"},{"line_number":470,"context_line":"        iniset $NOVA_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":471,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d8af2fc5_ba1a0bf8","line":468,"updated":"2024-02-09 15:17:00.000000000","message":"Going back to the comment on the earlier PS, we want to be able to set this on any node, regardless of its service composition, right? Won\u0027t this fail if we run this on a node that doesn\u0027t have cinder (and thus no `CINDER_CONF`) while we\u0027re trying to actually get it set for nova or glance?","commit_id":"3d598043597a92cce829f238fbac259e9d8c461f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df03cd467a52c87da8edf5788d415ffb8dbec807","unresolved":true,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"function init_os_brick {"},{"line_number":467,"context_line":"    mkdir -p $OS_BRICK_LOCK_PATH"},{"line_number":468,"context_line":"    iniset $CINDER_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":469,"context_line":"    if is_service_enabled nova; then"},{"line_number":470,"context_line":"        iniset $NOVA_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":471,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"04410d42_470f55fe","line":468,"in_reply_to":"d8af2fc5_ba1a0bf8","updated":"2024-12-17 21:44:41.000000000","message":"So we only call this function if cinder services are enabled OR glance is using cinder as it\u0027s backend.\nIs it safe to assume that either of the conditions confirm the existence of cinder.conf of we can have an edge type of deployment where only nova and glance reside?\nIn any case, I agree with Dan that it\u0027s safe to include a check for cinder,\n\n    if is_service_enabled cinder; then\n        iniset $CINDER_CONF os_brick lock_path $OS_BRICK_LOCK_PATH","commit_id":"3d598043597a92cce829f238fbac259e9d8c461f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7b66ba6bf543d0586096c19987817cf8438daf3","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        iniset $GLANCE_API_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":475,"context_line":"        iniset $GLANCE_CACHE_CONF os_brick lock_path $OS_BRICK_LOCK_PATH"},{"line_number":476,"context_line":"    fi"},{"line_number":477,"context_line":"}"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"# install_cinder() - Collect source and prepare"},{"line_number":480,"context_line":"function install_cinder {"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"e8eb5c48_ec0d24ed","line":477,"in_reply_to":"b82ee988_f48d992c","updated":"2025-01-14 15:54:16.000000000","message":"\u003e bashate: E040 Syntax error: syntax error near unexpected token `}\u0027\n\nPlease fix.","commit_id":"74489472d07ad5b8065d8e5f39cb7e9ad96c969d"}],"stack.sh":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"785ddc9c6400ff6c71eb352b0d41fbb6d2449345","unresolved":true,"context_lines":[{"line_number":957,"context_line":"    fix_system_ca_bundle_path"},{"line_number":958,"context_line":"fi"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"if is_service_enabled cinder; then"},{"line_number":961,"context_line":"    # os-brick setup required by glance, cinder, and nova"},{"line_number":962,"context_line":"    init_os_brick"},{"line_number":963,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"f08c683a_1e783d1c","line":960,"updated":"2023-03-06 16:52:31.000000000","message":"I wonder if we could have a situation where cinder is not on this node, but nova and glance are and thus need to run this anyway? Like if nova and glance are on the subnode and cinder is on the controller? Maybe not so important, I dunno, but since you\u0027re setting up nova and glance based on the presence of cinder, it makes me wonder.","commit_id":"36b224bb0fbe1871e34688f2ffd8f82041fbb330"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1485164965dee3bf784990832776cacbad414779","unresolved":false,"context_lines":[{"line_number":957,"context_line":"    fix_system_ca_bundle_path"},{"line_number":958,"context_line":"fi"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"if is_service_enabled cinder; then"},{"line_number":961,"context_line":"    # os-brick setup required by glance, cinder, and nova"},{"line_number":962,"context_line":"    init_os_brick"},{"line_number":963,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"35566b1a_21d4f0fe","line":960,"in_reply_to":"f08c683a_1e783d1c","updated":"2023-03-10 17:14:54.000000000","message":"You are right, there is an scenario where it would matter: if glance and nova where running on a host and glance is configured to use cinder.\n\nI\u0027ll update the patch.","commit_id":"36b224bb0fbe1871e34688f2ffd8f82041fbb330"}]}