)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"380ff24510b27738ed23c2acffa3a0a1dab514cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20ce43c9_2b3d58e5","updated":"2022-08-10 21:05:08.000000000","message":"This doesn\u0027t work, at least with barbican\u0027s current devstack init scripts. The problem is barbican expects to create the \"creator\" role, and fails if it already exists (because cinder got to it first).","commit_id":"57eca5760523d356310f0ec4bd436c9eb17639b8"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"764e425066160a89d5a72f0c43882947ae491767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f423e4f0_bfedf1e9","updated":"2022-08-23 01:53:32.000000000","message":"LGTM. But I think it\u0027s good to update the comment of the function, too, but the patch can be a separated if it\u0027s uncomfortable.","commit_id":"b38a306e0888448ba2398f183cd50db609a8c7de"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"1a8d62f02c6a19e14db65b57140b4cd0aea480e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"269aa739_572b33ad","updated":"2022-08-23 03:49:36.000000000","message":"Thanks for the updating!","commit_id":"ccd116d36447ba1c5efad58ee360eb7f276eb7c6"}],"lib/cinder":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"764e425066160a89d5a72f0c43882947ae491767","unresolved":true,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# create_cinder_accounts() - Set up common required cinder accounts"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"# Tenant               User       Roles"},{"line_number":392,"context_line":"# ------------------------------------------------------------------"},{"line_number":393,"context_line":"# service              cinder     admin        # if enabled"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# Migrated from keystone_data.sh"},{"line_number":396,"context_line":"function create_cinder_accounts {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e5354326_a4e29c9d","line":393,"range":{"start_line":391,"start_character":0,"end_line":393,"end_character":59},"updated":"2022-08-23 01:53:32.000000000","message":"Don\u0027t we need to update like this?\n```\n# Project              User         Roles\n# ------------------------------------------------------------------\n# SERVICE_PROJECT_NAME cinder       service\n# SERVICE_PROJECT_NAME cinder       creator (if Barbican enabled)\n```\n\nI think the patch can be separated, though.","commit_id":"b38a306e0888448ba2398f183cd50db609a8c7de"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"013d456e0b9ed55e71b8c10641e963477429f805","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"# create_cinder_accounts() - Set up common required cinder accounts"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"# Tenant               User       Roles"},{"line_number":392,"context_line":"# ------------------------------------------------------------------"},{"line_number":393,"context_line":"# service              cinder     admin        # if enabled"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"# Migrated from keystone_data.sh"},{"line_number":396,"context_line":"function create_cinder_accounts {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"2ea8edde_4030005c","line":393,"range":{"start_line":391,"start_character":0,"end_line":393,"end_character":59},"in_reply_to":"e5354326_a4e29c9d","updated":"2022-08-23 02:53:14.000000000","message":"Yes, it should be updated like that, thank you! I prefer to do it now, rather than making another patch.","commit_id":"b38a306e0888448ba2398f183cd50db609a8c7de"}]}