)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7deb438f6283a6d026d54ada9eb91fe01b564b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82ef2199_07167461","updated":"2022-11-07 18:59:55.000000000","message":"Loading up the second +2 here so it\u0027ll be easy to merge when the dependent patch is ready.","commit_id":"bf0aa828ac22d1fa687ca4317d9bda445f3469ee"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"d20ba3d8522e54eb7fd7bf2cd689dfec2a1e6e59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19f0b558_7bb22230","updated":"2023-05-25 14:06:41.000000000","message":"This change to devstack has already received two +2 ... but what is missing the actual change to introduce this functionality to cinder-backup. Could you maybe have a look at https://review.opendev.org/c/openstack/cinder/+/810457 then?\n\nActually this is whole topic consists of three patches: https://review.opendev.org/q/topic:ceph_keep_snapshots","commit_id":"bf0aa828ac22d1fa687ca4317d9bda445f3469ee"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"742a8b5da9d0b2d0e214ab6bd2a8924a2214cffd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"795d376e_c6dab1d5","updated":"2022-11-04 09:38:56.000000000","message":"lgtm, if the depends-on patch will be merged, thanks for also proposing the patch here","commit_id":"bf0aa828ac22d1fa687ca4317d9bda445f3469ee"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"d4b578addfb71b2785f238ad7858ef75ae121198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d851da90_51ff0e96","updated":"2024-04-22 06:22:06.000000000","message":"Uploaded a new PS with the renamed option \"backup_ceph_max_snapshots\".\n\nPlease kindly take a look and let\u0027s get this whole topic reviewed :-)","commit_id":"d7b6e704031d9c2a566288988331b5238ffa568c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"30be798a6ee23ad54a2641cb803d93d28275bae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b2fabcb_e9cb282c","updated":"2025-08-12 16:38:44.000000000","message":"Late to the party but it looks like all the requested changes have been implemented. +2 and I will merge in a few days if no one objects.","commit_id":"31980e436b73db18297a295969069cf00bd43754"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"aef36c9d0b3fa449bc2126bf641b3e3a8bed97af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"766b0828_dedddc82","updated":"2025-10-28 15:53:24.000000000","message":"Ok, 77 days are more than enough, merging...","commit_id":"31980e436b73db18297a295969069cf00bd43754"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9e345c2c604bb811ddb15bf1216b0711fc61b329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3c8b27a1_d9766f30","updated":"2025-10-28 18:00:09.000000000","message":"recheck\n\nunrelated NODE_FAILURE in a job:\n\nopenstack-tox-bashate https://zuul.opendev.org/t/openstack/build/a6408a4d9a2e44339cbc2d39824d9304 : NODE_FAILURE Node(set) request 5a1d2ad2a4d44caaaabe24778c3a79d0 failed in 0s","commit_id":"31980e436b73db18297a295969069cf00bd43754"}],"lib/cinder_backups/ceph":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"be72711255b5782c1b6c7fa677b1d5163eb9f505","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.ceph.CephBackupDriver\""},{"line_number":41,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_conf \"$CEPH_CONF_FILE\""},{"line_number":42,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_keep_snapshots_count \"$CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT\""},{"line_number":43,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_pool \"$CINDER_BAK_CEPH_POOL\""},{"line_number":44,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_user \"$CINDER_BAK_CEPH_USER\""},{"line_number":45,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_stripe_unit 0"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fbaa4b3f_c58e5def","line":42,"updated":"2024-04-21 04:13:55.000000000","message":"-1: the cinder option (still under review) is \u0027backup_ceph_max_snapshots\u0027","commit_id":"bf0aa828ac22d1fa687ca4317d9bda445f3469ee"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"51afb58b5d82f65fee51c3451854f23180f75ffd","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.ceph.CephBackupDriver\""},{"line_number":41,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_conf \"$CEPH_CONF_FILE\""},{"line_number":42,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_keep_snapshots_count \"$CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT\""},{"line_number":43,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_pool \"$CINDER_BAK_CEPH_POOL\""},{"line_number":44,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_user \"$CINDER_BAK_CEPH_USER\""},{"line_number":45,"context_line":"    iniset $CINDER_CONF DEFAULT backup_ceph_stripe_unit 0"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"c2b230a7_a3975f62","line":42,"in_reply_to":"fbaa4b3f_c58e5def","updated":"2024-04-22 19:22:43.000000000","message":"Done","commit_id":"bf0aa828ac22d1fa687ca4317d9bda445f3469ee"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"58d7b1db303b960004eb69982373bd5539ef9f05","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# Defaults"},{"line_number":20,"context_line":"# --------"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT\u003d${CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT:--1}"},{"line_number":23,"context_line":"CINDER_BAK_CEPH_POOL\u003d${CINDER_BAK_CEPH_POOL:-backups}"},{"line_number":24,"context_line":"CINDER_BAK_CEPH_POOL_PG\u003d${CINDER_BAK_CEPH_POOL_PG:-8}"},{"line_number":25,"context_line":"CINDER_BAK_CEPH_POOL_PGP\u003d${CINDER_BAK_CEPH_POOL_PGP:-8}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0acadcb8_cab36983","line":22,"range":{"start_line":22,"start_character":77,"end_line":22,"end_character":79},"updated":"2024-09-27 10:05:31.000000000","message":"shouldn\u0027t this be 0 as the config option states \"0 indicates to keep an unlimited number of snapshots.\"\nlooking at the logic, -1 should also work as the conditions are \u003e 0 but good to keep it in sync with the default option by changing this to 0.","commit_id":"d7b6e704031d9c2a566288988331b5238ffa568c"},{"author":{"_account_id":33634,"name":"Jan Hartkopf","email":"j@hartkopf.io","username":"jhartkopf"},"change_message_id":"47031a3679d07c771fd6a486ca92d41e6e802645","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# Defaults"},{"line_number":20,"context_line":"# --------"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT\u003d${CINDER_BAK_CEPH_KEEP_SNAPSHOTS_COUNT:--1}"},{"line_number":23,"context_line":"CINDER_BAK_CEPH_POOL\u003d${CINDER_BAK_CEPH_POOL:-backups}"},{"line_number":24,"context_line":"CINDER_BAK_CEPH_POOL_PG\u003d${CINDER_BAK_CEPH_POOL_PG:-8}"},{"line_number":25,"context_line":"CINDER_BAK_CEPH_POOL_PGP\u003d${CINDER_BAK_CEPH_POOL_PGP:-8}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"2db3a8b5_2b3c6361","line":22,"range":{"start_line":22,"start_character":77,"end_line":22,"end_character":79},"in_reply_to":"0acadcb8_cab36983","updated":"2024-10-02 09:48:24.000000000","message":"Done\n\nAlso updated the remaining variable names to keep consistency with the merged Cinder patch.","commit_id":"d7b6e704031d9c2a566288988331b5238ffa568c"}]}