)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eaf065ba131bf9413176ee237bee00ab4d60d257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b18ca24c_3a22d030","updated":"2022-10-19 18:19:15.000000000","message":"Let\u0027s see if https://review.opendev.org/c/openstack/neutron/+/861916 passes first","commit_id":"6d9a8f7141794e6b3f59a58709e79700508e477a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6707b9b84f69fd03aeb57bf5e110bab35b3f2654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e0c8154_81b47623","updated":"2022-10-19 22:50:56.000000000","message":"Just an fyi the test neutron job didn\u0027t like my initial change","commit_id":"22e2648dd608fa69ec6d80329bdc911f85702593"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ebd4908f4d64341155d828fc8b6683c268c71797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0eaa185_2956b46e","updated":"2022-10-21 17:37:16.000000000","message":"Lucas - this seems to work in my environment and in the neutron test patch I created.","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"0fd1af1973920b5cf5cd553f61c2e123f0b0c21a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0e4b7808_fa9e5cfb","updated":"2022-10-24 08:03:21.000000000","message":"Nice! Thanks Brian","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18f342b273574ca24d3c0dcebe102fd4bb853b59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c76ef584_886eca03","updated":"2022-10-24 07:24:30.000000000","message":"Thanks Brian for working on this!","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"48cecf96d2ca7b580003aaf112901d5c532d17d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e58f24f_efef1abb","updated":"2022-11-01 15:43:51.000000000","message":"just a quick question","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f9fcc77a72e24e88f226740066b3d1cb84c81408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e9950030_4f46b76d","updated":"2022-11-01 16:48:23.000000000","message":"lgtm","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18f342b273574ca24d3c0dcebe102fd4bb853b59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f628768_b1f77821","in_reply_to":"b0eaa185_2956b46e","updated":"2022-10-24 07:24:30.000000000","message":"Thanks Brian! I was reviewing the patch, it looks good!","commit_id":"71c99655479174750bcedfe458328328a1596766"}],"functions-common":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8017db69f2c9d9b09e4b5fd1794516d0f00017ad","unresolved":true,"context_lines":[{"line_number":307,"context_line":"    local msg\u003d\"[ERROR] ${BASH_SOURCE[2]}:$1 $2\""},{"line_number":308,"context_line":"    echo \"$msg\" 1\u003e\u00262;"},{"line_number":309,"context_line":"    if [[ -n ${LOGDIR} ]]; then"},{"line_number":310,"context_line":"        echo \"$msg\" | sudo tee -a \"${LOGDIR}/error.log\""},{"line_number":311,"context_line":"    fi"},{"line_number":312,"context_line":"    $xtrace"},{"line_number":313,"context_line":"    return $exitcode"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"27d3918c_2c6441a2","line":310,"updated":"2022-10-20 23:48:36.000000000","message":"I can send out a separate patch for this, there\u0027s definitely something broken with permissions of this file","commit_id":"2c03bf0abd977f0f0ccbf880da57ecacdaf92522"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"723aec082e58ca42c7ef0ef843e7186676ad76f2","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    local stop_cmd\u003d\"$3\""},{"line_number":246,"context_line":"    local group\u003d$4"},{"line_number":247,"context_line":"    local user\u003d$5"},{"line_number":248,"context_line":"    local rundir\u003d${6:-$OVS_RUNDIR}"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    local systemd_service\u003d\"devstack@$service.service\""},{"line_number":251,"context_line":"    local unit_file\u003d\"$SYSTEMD_DIR/$systemd_service\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9c9eea32_227922e6","line":248,"updated":"2022-10-24 09:03:44.000000000","message":"nit: since this arg is specified in all invocations, you could omit the default here, too. or possibly even hardcode group and user, since they are the same all the time. or are there other uses outside this file?\n\nanyway, fine as-is for now","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"553135df5a87b6af267c6e760cc84335ac3624c9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    local stop_cmd\u003d\"$3\""},{"line_number":246,"context_line":"    local group\u003d$4"},{"line_number":247,"context_line":"    local user\u003d$5"},{"line_number":248,"context_line":"    local rundir\u003d${6:-$OVS_RUNDIR}"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    local systemd_service\u003d\"devstack@$service.service\""},{"line_number":251,"context_line":"    local unit_file\u003d\"$SYSTEMD_DIR/$systemd_service\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"599c0957_e26b86b9","line":248,"in_reply_to":"9c9eea32_227922e6","updated":"2022-11-01 16:14:08.000000000","message":"Hi Jens, yes I did make sure all users pass it since I had to verify they all passed $user, so it could be removed since there is noone outside this file callint it. I can change it if I re-spin.","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"48cecf96d2ca7b580003aaf112901d5c532d17d3","unresolved":true,"context_lines":[{"line_number":719,"context_line":"        fi"},{"line_number":720,"context_line":"        sudo ovn-nbctl --db\u003dunix:$OVN_RUNDIR/ovnnb_db.sock set-connection p${OVN_PROTO}:6641:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":721,"context_line":"        sudo ovn-sbctl --db\u003dunix:$OVN_RUNDIR/ovnsb_db.sock set-connection p${OVN_PROTO}:6642:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":722,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnnb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":723,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnsb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":724,"context_line":"    fi"},{"line_number":725,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"b15c3496_77faf97c","line":722,"range":{"start_line":722,"start_character":13,"end_line":722,"end_character":38},"updated":"2022-11-01 15:43:51.000000000","message":"ovs-appctl and OVN_RUNDIR, the same on line below, i just wanted to double check that it\u0027s intended","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f9fcc77a72e24e88f226740066b3d1cb84c81408","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        fi"},{"line_number":720,"context_line":"        sudo ovn-nbctl --db\u003dunix:$OVN_RUNDIR/ovnnb_db.sock set-connection p${OVN_PROTO}:6641:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":721,"context_line":"        sudo ovn-sbctl --db\u003dunix:$OVN_RUNDIR/ovnsb_db.sock set-connection p${OVN_PROTO}:6642:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":722,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnnb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":723,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnsb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":724,"context_line":"    fi"},{"line_number":725,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"0784ba97_e3f7663a","line":722,"range":{"start_line":722,"start_character":13,"end_line":722,"end_character":38},"in_reply_to":"ad148a91_65f48a4c","updated":"2022-11-01 16:48:23.000000000","message":"ack, thanks","commit_id":"71c99655479174750bcedfe458328328a1596766"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"553135df5a87b6af267c6e760cc84335ac3624c9","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        fi"},{"line_number":720,"context_line":"        sudo ovn-nbctl --db\u003dunix:$OVN_RUNDIR/ovnnb_db.sock set-connection p${OVN_PROTO}:6641:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":721,"context_line":"        sudo ovn-sbctl --db\u003dunix:$OVN_RUNDIR/ovnsb_db.sock set-connection p${OVN_PROTO}:6642:$SERVICE_LISTEN_ADDRESS -- set connection . inactivity_probe\u003d60000"},{"line_number":722,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnnb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":723,"context_line":"        sudo ovs-appctl -t $OVN_RUNDIR/ovnsb_db.ctl vlog/set console:off syslog:$OVN_DBS_LOG_LEVEL file:$OVN_DBS_LOG_LEVEL"},{"line_number":724,"context_line":"    fi"},{"line_number":725,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ad148a91_65f48a4c","line":722,"range":{"start_line":722,"start_character":13,"end_line":722,"end_character":38},"in_reply_to":"b15c3496_77faf97c","updated":"2022-11-01 16:14:08.000000000","message":"Yes, that -t argument is the control socket of the daemon this command is trying to communicate with. Without the \u0027ln -s\u0027 I removed above, we have to use the path to the OVN directory.","commit_id":"71c99655479174750bcedfe458328328a1596766"}]}