)]}'
{"stack.sh":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0f3dec9ad0f9809dec2e0d84ff11cb2be3f5d7f0","unresolved":false,"context_lines":[{"line_number":484,"context_line":"}"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"function kill_spinner {"},{"line_number":487,"context_line":"   kill \u003e/dev/null 2\u003e\u00261 $LAST_SPINNER_PID"},{"line_number":488,"context_line":"   if [ ! -z \"$LAST_SPINNER_PID\" ]; then"},{"line_number":489,"context_line":"       printf \"\\b\\b\\bdone\\n\" \u003e\u00263"},{"line_number":490,"context_line":"   fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAW3%2F%2Fkjw%3D","line":487,"updated":"2014-04-12 08:11:28.000000000","message":"Indents should be multiple of 4, but this is only 2.","commit_id":"669202f41d2594a0d2b298aae8bf5f126f329478"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"b14e278179e3007249d1108fe2acfc712cc7ea46","unresolved":false,"context_lines":[{"line_number":486,"context_line":"function kill_spinner {"},{"line_number":487,"context_line":"   kill \u003e/dev/null 2\u003e\u00261 $LAST_SPINNER_PID"},{"line_number":488,"context_line":"   if [ ! -z \"$LAST_SPINNER_PID\" ]; then"},{"line_number":489,"context_line":"       printf \"\\b\\b\\bdone\\n\" \u003e\u00263"},{"line_number":490,"context_line":"   fi"},{"line_number":491,"context_line":"}"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAXH%2F%2FsAo%3D","line":489,"updated":"2014-04-18 08:10:25.000000000","message":"Unlike the other calls to kill_spinner (in echo_summary), the last one (the one you introduced at the end) is unconditional. If your configuration doesn\u0027t use spinners, this results in a call to kill with an empty argument, which returns an error and Jenkins complains. Moving the kill statement down into the if clause should fix this.","commit_id":"669202f41d2594a0d2b298aae8bf5f126f329478"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"0f3dec9ad0f9809dec2e0d84ff11cb2be3f5d7f0","unresolved":false,"context_lines":[{"line_number":494,"context_line":"# echo_summary \"something to say\""},{"line_number":495,"context_line":"function echo_summary {"},{"line_number":496,"context_line":"    if [[ -t 3 \u0026\u0026 \"$VERBOSE\" !\u003d \"True\" ]]; then"},{"line_number":497,"context_line":"        kill_spinner       "},{"line_number":498,"context_line":"        echo -n -e $@ \u003e\u00266"},{"line_number":499,"context_line":"        spinner \u0026"},{"line_number":500,"context_line":"        LAST_SPINNER_PID\u003d$!"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAW3%2F%2Fkj0%3D","line":497,"updated":"2014-04-12 08:11:28.000000000","message":"Please remove extra spaces after \u0027kill_spinner\u0027.","commit_id":"669202f41d2594a0d2b298aae8bf5f126f329478"}]}
