)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60b711d2511b90422a092880a84d5d74f18b4b53","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[1] https://review.opendev.org/c/openstack/devstack/+/823653"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Related-bug: #1996748"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: Ibf1c8b2ee6b6618f77cd8486e9c687993d7cb4a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"6d123837_6aa0ff9b","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":5},"updated":"2022-12-19 19:00:53.000000000","message":"after this commit is merged, we need to close the associated bug manually - as the \"Closes-bug\" footer was previously a part of the follow-up change (https://review.opendev.org/c/openstack/devstack/+/865015) which was squashed into this one ... but I don\u0027t wanna hold the review over this, so in case I forget I\u0027m making this note to close the LP if you see this commit merged.","commit_id":"a52041cd3f067156e478e355f5712a60e12ce649"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"02ddd72ad5d299aa8ff53c881361e5555574813d","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[1] https://review.opendev.org/c/openstack/devstack/+/823653"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Related-bug: #1996748"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: Ibf1c8b2ee6b6618f77cd8486e9c687993d7cb4a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"bbe7d37a_b88c3e85","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":5},"in_reply_to":"6d123837_6aa0ff9b","updated":"2022-12-20 08:16:43.000000000","message":"Sure. I just closed LP","commit_id":"a52041cd3f067156e478e355f5712a60e12ce649"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"675248e08f7209e18bfc2d3fde6c52c33566590c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"24e1181b_d08be450","updated":"2022-11-25 09:05:18.000000000","message":"Did you test with some neutron patch already? I guess that would be needed to have confidence in this.","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e9c1c7afed7c2543365b41c65e70675247289ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80aef0da_96e921e7","in_reply_to":"0fad5478_e2b8d466","updated":"2022-12-12 10:15:04.000000000","message":"I just did neutron and tempest DNM patches which depends on https://review.opendev.org/c/openstack/devstack/+/865015/:\n\nhttps://review.opendev.org/c/openstack/tempest/+/865821\nhttps://review.opendev.org/c/openstack/neutron/+/865822\n\nLet\u0027s check how it will work there","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59217c28e676ddd7e6e61c5c75fa92401bb851a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0fad5478_e2b8d466","in_reply_to":"24e1181b_d08be450","updated":"2022-11-28 09:35:01.000000000","message":"We can maybe push a Neutron patch dependant on this one. That will increase the coverage, I guess.","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9182c03dbdad9adbd7613e7bb66b3c29ed980620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8751bec8_4cffe8f5","updated":"2022-11-28 20:11:16.000000000","message":"Slawek - I didn\u0027t see this change, but maybe my comments from the dependent change apply here instead.","commit_id":"ab0b53738f546c18c62e119fd48245680dfeae30"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d931fab39270babd6fd9163654c9b362437b0310","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"09671aed_efa07714","updated":"2022-12-13 14:59:37.000000000","message":"Apart from the issue detected in Octavia, the patch looks OK.\n\nWaiting for the mail from Ghanshyam.","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b8788bc75d68b2d60d379d0596c942909d326d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a7abb40d_3b87d865","updated":"2022-12-12 19:35:59.000000000","message":"I found octavia using lib/neutron and with this change they will be broken[1].\n\nAs we are renaming lib/neutron-legacy to neutron/lib in next patch (865015), I think it is better to squash both patch so that 1. porject using lib/neutron (like octavia) does not need any change 2. project using lib/neutron-legacy and lib/neutron both[2] does not need to change it twice.\n\nI am writing this in your ML thread also to discuss so that we can get more attention from projects and they know how we are planning?\n\n[1] https://opendev.org/openstack/octavia/src/branch/master/devstack/upgrade/shutdown.sh#L13\n\n[2] https://opendev.org/openstack/networking-generic-switch/src/branch/master/devstack/upgrade/upgrade.sh#L45-L46\n\n","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e9c1c7afed7c2543365b41c65e70675247289ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e5d26388_4e362772","updated":"2022-12-12 10:15:04.000000000","message":"recheck - unrelated grenade failures","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d3aef272a665bb1f1a661688ab30edb23743d25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"863566e7_4238b895","updated":"2022-12-12 18:57:29.000000000","message":"recheck error in enforce scope job for ovn_agent:start_ovn","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8f4ba3fe8d37192d65d86fc13c389b6bec9f8e07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5c71bb7b_2af1d6a3","in_reply_to":"a7abb40d_3b87d865","updated":"2022-12-16 09:06:26.000000000","message":"I squashed patches now. It\u0027s all in this one.\nI also proposed Octavia DNM patch to check how it will work there, see https://review.opendev.org/c/openstack/octavia/+/867956\nTo avoid breakage I also sources \"lib/neutron\" in \"lib/neutron-legacy\" so projects which are using lib/neutron-legacy shouldn\u0027t be broken with this.","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c4f4fcb64d98e5c37de40d8bb4d5c911b518e62f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"308fa7fd_c4a46859","updated":"2022-12-16 23:43:01.000000000","message":"Thanks Slawek for the updates. this lgtm and better transition plan.","commit_id":"a52041cd3f067156e478e355f5712a60e12ce649"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60b711d2511b90422a092880a84d5d74f18b4b53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"96752317_5db0662b","updated":"2022-12-19 19:00:53.000000000","message":"looks good, thanks Slawek for working on this!","commit_id":"a52041cd3f067156e478e355f5712a60e12ce649"}],"lib/neutron-legacy":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"675248e08f7209e18bfc2d3fde6c52c33566590c","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        fi"},{"line_number":408,"context_line":"    fi"},{"line_number":409,"context_line":"    if is_service_enabled q-agt q-svc; then"},{"line_number":410,"context_line":"        _configure_neutron_service"},{"line_number":411,"context_line":"    fi"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    iniset $NEUTRON_CONF DEFAULT api_workers \"$API_WORKERS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1375e407_cc9025be","line":410,"updated":"2022-11-25 09:05:18.000000000","message":"Why are you moving this? Seems unrelated and possibly breaking existing assumptions. Might at least be worth an explanation in the commit message.","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"05268322691410bd037c4cf063b495541e347ae3","unresolved":true,"context_lines":[{"line_number":407,"context_line":"        fi"},{"line_number":408,"context_line":"    fi"},{"line_number":409,"context_line":"    if is_service_enabled q-agt q-svc; then"},{"line_number":410,"context_line":"        _configure_neutron_service"},{"line_number":411,"context_line":"    fi"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    iniset $NEUTRON_CONF DEFAULT api_workers \"$API_WORKERS\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"d847f875_69642049","line":410,"in_reply_to":"1375e407_cc9025be","updated":"2022-11-28 10:52:04.000000000","message":"TBH I changed that as it was causing some issues in my dev env with ML2/OVS. I will mention that in commit message.","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"675248e08f7209e18bfc2d3fde6c52c33566590c","unresolved":true,"context_lines":[{"line_number":604,"context_line":"    test_with_retry \"$testcmd\" \"Neutron did not start\" $SERVICE_TIMEOUT"},{"line_number":605,"context_line":"}"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"function start_neutron {"},{"line_number":608,"context_line":"    start_l2_agent \"$@\""},{"line_number":609,"context_line":"    start_other_agents \"$@\""},{"line_number":610,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"36f7dbec_5fe59aa1","line":607,"updated":"2022-11-25 09:05:18.000000000","message":"That looks like a duplicate of start_neutron_agents, why do we need both? Can we make one just a wrapper of the other if both are currently needed and make a comment to clean this up later?","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"05268322691410bd037c4cf063b495541e347ae3","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    test_with_retry \"$testcmd\" \"Neutron did not start\" $SERVICE_TIMEOUT"},{"line_number":605,"context_line":"}"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"function start_neutron {"},{"line_number":608,"context_line":"    start_l2_agent \"$@\""},{"line_number":609,"context_line":"    start_other_agents \"$@\""},{"line_number":610,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"aa4dfe17_ef8fe054","line":607,"in_reply_to":"36f7dbec_5fe59aa1","updated":"2022-11-28 10:52:04.000000000","message":"Done","commit_id":"6f834f9a14787570c4025d3d20192ef211c02216"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"360512cfa19c630701e7502a74ea72a4c7e5a787","unresolved":true,"context_lines":[{"line_number":106,"context_line":"Q_DHCP_CONF_FILE\u003d$NEUTRON_CONF_DIR/dhcp_agent.ini"},{"line_number":107,"context_line":"# NOTE(slaweq): NEUTRON_DHCP_CONF is used e.g. in neutron repository,"},{"line_number":108,"context_line":"# it was previously defined in the lib/neutron module which is now deleted."},{"line_number":109,"context_line":"NEUTRON_DHCP_CONF\u003d$Q_L3_CONF_FILE"},{"line_number":110,"context_line":"Q_L3_CONF_FILE\u003d$NEUTRON_CONF_DIR/l3_agent.ini"},{"line_number":111,"context_line":"# NOTE(slaweq): NEUTRON_L3_CONF is used e.g. in neutron repository,"},{"line_number":112,"context_line":"# it was previously defined in the lib/neutron module which is now deleted."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"8c874748_c6d81480","line":109,"range":{"start_line":109,"start_character":21,"end_line":109,"end_character":23},"updated":"2022-12-06 14:32:04.000000000","message":"s/DHCP - oops :(","commit_id":"cd49f38d72c808154d59b1ec756b01b63f011369"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e9c1c7afed7c2543365b41c65e70675247289ddd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Q_DHCP_CONF_FILE\u003d$NEUTRON_CONF_DIR/dhcp_agent.ini"},{"line_number":107,"context_line":"# NOTE(slaweq): NEUTRON_DHCP_CONF is used e.g. in neutron repository,"},{"line_number":108,"context_line":"# it was previously defined in the lib/neutron module which is now deleted."},{"line_number":109,"context_line":"NEUTRON_DHCP_CONF\u003d$Q_L3_CONF_FILE"},{"line_number":110,"context_line":"Q_L3_CONF_FILE\u003d$NEUTRON_CONF_DIR/l3_agent.ini"},{"line_number":111,"context_line":"# NOTE(slaweq): NEUTRON_L3_CONF is used e.g. in neutron repository,"},{"line_number":112,"context_line":"# it was previously defined in the lib/neutron module which is now deleted."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"11162c7a_40b30866","line":109,"range":{"start_line":109,"start_character":21,"end_line":109,"end_character":23},"in_reply_to":"8c874748_c6d81480","updated":"2022-12-12 10:15:04.000000000","message":"Done","commit_id":"cd49f38d72c808154d59b1ec756b01b63f011369"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7d3aef272a665bb1f1a661688ab30edb23743d25","unresolved":true,"context_lines":[{"line_number":373,"context_line":"function configure_neutron {"},{"line_number":374,"context_line":"    _configure_neutron_common"},{"line_number":375,"context_line":"    iniset_rpc_backend neutron $NEUTRON_CONF"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    if is_service_enabled q-metering; then"},{"line_number":378,"context_line":"        _configure_neutron_metering"},{"line_number":379,"context_line":"    fi"},{"line_number":380,"context_line":"    if is_service_enabled q-agt; then"},{"line_number":381,"context_line":"        _configure_neutron_plugin_agent"},{"line_number":382,"context_line":"    fi"},{"line_number":383,"context_line":"    if is_service_enabled q-dhcp; then"},{"line_number":384,"context_line":"        _configure_neutron_dhcp_agent"},{"line_number":385,"context_line":"    fi"},{"line_number":386,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":387,"context_line":"        _configure_neutron_l3_agent"},{"line_number":388,"context_line":"    fi"},{"line_number":389,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":390,"context_line":"        _configure_neutron_metadata_agent"},{"line_number":391,"context_line":"    fi"},{"line_number":392,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"d2cc973d_e107b6a3","line":389,"range":{"start_line":376,"start_character":0,"end_line":389,"end_character":38},"updated":"2022-12-12 18:57:29.000000000","message":"sometime we should rename these service name from q-* to something starting with \u0027n\u0027 or \u0027ne\u0027","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60b711d2511b90422a092880a84d5d74f18b4b53","unresolved":true,"context_lines":[{"line_number":373,"context_line":"function configure_neutron {"},{"line_number":374,"context_line":"    _configure_neutron_common"},{"line_number":375,"context_line":"    iniset_rpc_backend neutron $NEUTRON_CONF"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    if is_service_enabled q-metering; then"},{"line_number":378,"context_line":"        _configure_neutron_metering"},{"line_number":379,"context_line":"    fi"},{"line_number":380,"context_line":"    if is_service_enabled q-agt; then"},{"line_number":381,"context_line":"        _configure_neutron_plugin_agent"},{"line_number":382,"context_line":"    fi"},{"line_number":383,"context_line":"    if is_service_enabled q-dhcp; then"},{"line_number":384,"context_line":"        _configure_neutron_dhcp_agent"},{"line_number":385,"context_line":"    fi"},{"line_number":386,"context_line":"    if is_service_enabled q-l3; then"},{"line_number":387,"context_line":"        _configure_neutron_l3_agent"},{"line_number":388,"context_line":"    fi"},{"line_number":389,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":390,"context_line":"        _configure_neutron_metadata_agent"},{"line_number":391,"context_line":"    fi"},{"line_number":392,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"0cd5a9c1_eab426f8","line":389,"range":{"start_line":376,"start_character":0,"end_line":389,"end_character":38},"in_reply_to":"d2cc973d_e107b6a3","updated":"2022-12-19 19:00:53.000000000","message":"yeah, i find q- a bit confusing ... \u0027ne\u0027 would be better than \u0027n\u0027 as \u0027n\u0027 can be mistaken for nova maybe","commit_id":"03b54ae6a63eaf3372dd27b974827684525d02c2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c4f4fcb64d98e5c37de40d8bb4d5c911b518e62f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# TODO(slaweq): remove that file when other projects, like e.g. Grenade will"},{"line_number":4,"context_line":"# be using lib/neutron"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"source $TOP_DIR/lib/neutron"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"1bf15feb_33db46c5","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":22},"updated":"2022-12-16 23:43:01.000000000","message":"+1, this will help this transition. thanks","commit_id":"a52041cd3f067156e478e355f5712a60e12ce649"}]}