)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71699b8b2cc90a2366855d5e994ccc10f3dead6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0b10a127_6e772ff6","updated":"2022-11-28 20:04:53.000000000","message":"I didn\u0027t go through this extensively, but wonder if there are places where only one of these two files were updated instead of both, and if there\u0027s any necessary small additions like below.","commit_id":"109b95742a7fbfff04acd21db7a4c90693addec3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2f451459331d4ca028a55970e12707946aa04640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"05fea501_5912c4dd","updated":"2022-11-30 11:00:58.000000000","message":"I tried to mix q-* and neutron-* service names and that doesn\u0027t work, I am not sure what we agreed if we want to keep the neutron-* names or use only q-* ones","commit_id":"7e09aaf81bf1794d88c02347b76a689d735ab9f0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f2a96f429c52746c3b4c43013c86140670da7ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a4126c5d_feb05ff1","updated":"2022-11-30 08:13:02.000000000","message":"I tried, actually just dropped this series of patch to my devstack and I got my usual setup, thanks","commit_id":"7e09aaf81bf1794d88c02347b76a689d735ab9f0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4e904578eb585bf1c82c1651dadd173091d5a198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e983c9c8_42f3a462","updated":"2022-12-12 19:30:13.000000000","message":"I know you have mentioned it in ML, but as many project using lib/neutron-legacy (for example ironic[1]) so with this change are we ok to break their gate until they switch to lib/neutron? or fix on their side should be proposed in advance so that they can just merge it(with depends-on this patch) ?\n\n[1] https://opendev.org/openstack/ironic-inspector/src/branch/master/devstack/upgrade/upgrade.sh#L44","commit_id":"68dff222b8b1372601993d644e8de94eb7986f08"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f737f010d736c75a6b8171f0c788ba8cb938b6f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"814ee97c_56cf6a08","in_reply_to":"e983c9c8_42f3a462","updated":"2022-12-16 09:02:27.000000000","message":"That\u0027s why I left \"lib/neutron-legacy\" for now but it just source \"lib/neutron\" so such projects shouldn\u0027t be broken.","commit_id":"68dff222b8b1372601993d644e8de94eb7986f08"}],"lib/neutron":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71699b8b2cc90a2366855d5e994ccc10f3dead6a","unresolved":true,"context_lines":[{"line_number":187,"context_line":"# Can be:"},{"line_number":188,"context_line":"# - ``legacy``   - No DVR functionality"},{"line_number":189,"context_line":"# - ``dvr_snat`` - Controller or single node DVR"},{"line_number":190,"context_line":"# - ``dvr``      - Compute node in multi-node DVR"},{"line_number":191,"context_line":"#"},{"line_number":192,"context_line":"Q_DVR_MODE\u003d${Q_DVR_MODE:-legacy}"},{"line_number":193,"context_line":"if [[ \"$Q_DVR_MODE\" !\u003d \"legacy\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"fcbcfcf6_8787cee3","line":190,"updated":"2022-11-28 20:04:53.000000000","message":"nit: this is missing\n\n# - ``dvr_no_external`` - Compute node in multi-node DVR, no external network\n\nWhich is in the \"old\" lib/neutron","commit_id":"109b95742a7fbfff04acd21db7a4c90693addec3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"53ccb17e478f83a81d513aa10558c3df6a6b3368","unresolved":false,"context_lines":[{"line_number":187,"context_line":"# Can be:"},{"line_number":188,"context_line":"# - ``legacy``   - No DVR functionality"},{"line_number":189,"context_line":"# - ``dvr_snat`` - Controller or single node DVR"},{"line_number":190,"context_line":"# - ``dvr``      - Compute node in multi-node DVR"},{"line_number":191,"context_line":"#"},{"line_number":192,"context_line":"Q_DVR_MODE\u003d${Q_DVR_MODE:-legacy}"},{"line_number":193,"context_line":"if [[ \"$Q_DVR_MODE\" !\u003d \"legacy\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"6ad8b043_c9f0929f","line":190,"in_reply_to":"fcbcfcf6_8787cee3","updated":"2022-12-05 13:25:39.000000000","message":"Done","commit_id":"109b95742a7fbfff04acd21db7a4c90693addec3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"71699b8b2cc90a2366855d5e994ccc10f3dead6a","unresolved":true,"context_lines":[{"line_number":930,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":931,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT nova_metadata_host $Q_META_DATA_IP"},{"line_number":932,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT metadata_workers $API_WORKERS"},{"line_number":933,"context_line":"    configure_root_helper_options $Q_META_CONF_FILE"},{"line_number":934,"context_line":"}"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"function _configure_neutron_ceilometer_notifications {"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ee3403f2_7ba52683","line":933,"updated":"2022-11-28 20:04:53.000000000","message":"There are probably other places where this file has diverged from the other one, do we have to add things to fix these small differences? For example the \"old\" lib/neutron does this here:\n\n    iniset $NEUTRON_META_CONF DEFAULT auth_url $KEYSTONE_SERVICE_URI\n    configure_keystone_authtoken_middleware $NEUTRON_META_CONF neutron DEFAULT","commit_id":"109b95742a7fbfff04acd21db7a4c90693addec3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"53ccb17e478f83a81d513aa10558c3df6a6b3368","unresolved":false,"context_lines":[{"line_number":930,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":931,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT nova_metadata_host $Q_META_DATA_IP"},{"line_number":932,"context_line":"    iniset $Q_META_CONF_FILE DEFAULT metadata_workers $API_WORKERS"},{"line_number":933,"context_line":"    configure_root_helper_options $Q_META_CONF_FILE"},{"line_number":934,"context_line":"}"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"function _configure_neutron_ceilometer_notifications {"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7071bb42_e5ca1539","line":933,"in_reply_to":"ee3403f2_7ba52683","updated":"2022-12-05 13:25:39.000000000","message":"TBH I don\u0027t know how many places like that can be there but I don\u0027t want to include things from the \"old lib/neutron\" module here because what we see here is what is used for years by every ci job and things from \"old lib/neutron\" weren\u0027t used almost at all.","commit_id":"109b95742a7fbfff04acd21db7a4c90693addec3"}],"lib/neutron-legacy":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"316bbfe0af3747064e015dba62e008f714277c66","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# TODO(slaweq): remove that file when other projects, like e.g. Grenade will"},{"line_number":4,"context_line":"# be using lib/neutron"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"source $TOP_DIR/lib/neutron"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"17daf1ab_61b9eae1","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":1},"updated":"2022-11-28 09:23:15.000000000","message":"+1, there are many projects still pointing to this file","commit_id":"7a93eb3bc361ebeda8deb83fd5433d817303d433"}]}