)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7c13b24d195e630909f65121fb2c3733b562c38e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Disable memory_tracker and file_tracker in unstask.sh properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this commit is applied, \"stop_process\" function still call"},{"line_number":10,"context_line":"\"is_service_enabled\" function for dstat, memory_tracker, and"},{"line_number":11,"context_line":"file_tracker individually."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1998990"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ca01e559_18fa08ba","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":39},"updated":"2023-02-21 15:36:54.000000000","message":"after this commit is applied, we will not call the is_service_enabled for the dstat service, or am I mistaken?","commit_id":"41c94ea2c0037883ab7e5fbc502b64a55a158ad2"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"3251ba5ddeaf768435455a4f9681720474e15c41","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Disable memory_tracker and file_tracker in unstask.sh properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this commit is applied, \"stop_process\" function still call"},{"line_number":10,"context_line":"\"is_service_enabled\" function for dstat, memory_tracker, and"},{"line_number":11,"context_line":"file_tracker individually."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1998990"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"051f77f1_0ecfeb94","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":39},"in_reply_to":"ca01e559_18fa08ba","updated":"2023-02-22 01:35:57.000000000","message":"Thanks for your review!\n\nMy commit message is inappropriate. I\u0027m sorry, stopping dstat-related services behaves exactly like the following:\n\nstop_dstat() calls stop_process() for dstat, memory_tracker and file_tracker respectively.\n\nInside stop_process(), a check for the existence of the service is performed by is_service_enabled().\n\nSo even if we apply this seemingly dangerous commit, is_service_enabled() is respected, so it\u0027s safe.","commit_id":"41c94ea2c0037883ab7e5fbc502b64a55a158ad2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"612e235956bffed5e92f04efecac93996c379e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"47fdda74_ad6670da","updated":"2022-11-22 10:59:58.000000000","message":"recheck","commit_id":"59b253100a1863746636922705de6a4a0da744bb"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"a38acad183df13ce21b9e07381ec098d72d73646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd9f6fdb_23f8098d","updated":"2023-01-24 09:29:04.000000000","message":"I think this issue is still in master.\nCould you please help to review it?","commit_id":"41c94ea2c0037883ab7e5fbc502b64a55a158ad2"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"60da6df4b0d8f7b500ab91c82e61ed0c8d9be027","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b9e600b_61e9c6d8","updated":"2023-02-27 09:28:23.000000000","message":"recheck a mirror issue (couldn\u0027t locate the packages)","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"3ce0f772489e8254f93af1b8d212e0e73347398c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04a298ca_f31a70c2","updated":"2023-02-28 01:19:15.000000000","message":"recheck a unrelated failure (ironic_tempest_plugin.tests.scenario)","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"add1dda880481e4245ec55b15f549e70b9ba8f86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"772e0a49_28c0ebd0","updated":"2023-02-25 14:33:32.000000000","message":"recheck not related error","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"c65453777765c31ca1d7d263a4aed92ed3073563","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0f8ffc21_9d45e275","updated":"2023-02-27 01:22:01.000000000","message":"recheck one more time\nThanks for your review.","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"1a04fb5efeeba1c3ae9bbab42f4dbc2520a6794b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c31ad224_411c9cbf","updated":"2023-02-27 05:51:18.000000000","message":"recheck unrelated failures","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85f45d5a80e8a46dcc7dc03248678da29bb62496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0f4bb05a_9e89455d","updated":"2023-02-22 07:41:11.000000000","message":"thanks, makes sense","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"}],"unstack.sh":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"85f45d5a80e8a46dcc7dc03248678da29bb62496","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    cleanup_etcd3"},{"line_number":169,"context_line":"fi"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"stop_dstat"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"# NOTE: Cinder automatically installs the lvm2 package, independently of the"},{"line_number":174,"context_line":"# enabled backends. So if Cinder is enabled, and installed successfully we are"}],"source_content_type":"text/x-sh","patch_set":4,"id":"33f131af_f7572504","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":10},"updated":"2023-02-22 07:41:11.000000000","message":"correct, stop_dstat calls stop_process which calls is_service enabled\n\nhttps://opendev.org/openstack/devstack/src/commit/e5c8e2951f8eed2d618bcb7c1d99adddeca4fffe/lib/dstat#L52\nhttps://opendev.org/openstack/devstack/src/commit/e5c8e2951f8eed2d618bcb7c1d99adddeca4fffe/functions-common#L1713","commit_id":"0572d73f8561f3304f897bf9ee2f63c406cc21b7"}]}