)]}'
{"files/rpms/hbase":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ea4579d13289689992241bf95ae8b4ed2b9c6283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ba7be1f8_cab526ef","line":2,"updated":"2015-02-24 11:40:56.000000000","message":"F21 uses 1.8.0 , instead of 1.7.0 .","commit_id":"ed091624f98e10c67f1f0315ebe5e666dfdadecb"}],"lib/nosql-database":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8a1d16bd675f1be160d05deeeb455a2181d595cf","unresolved":false,"context_lines":[{"line_number":88,"context_line":"function nosql_database_connection_url {"},{"line_number":89,"context_line":"    local db_type\u003d$1"},{"line_number":90,"context_line":"    local table_name\u003d$2"},{"line_number":91,"context_line":"    database_connection_url_$db_type $table_name"},{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FkRU%3D","line":91,"updated":"2014-04-12 13:57:09.000000000","message":"I think we should also namespace this to be nosql_database_connection_url_$db_type just to avoid accidental collision with mysql.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":88,"context_line":"function nosql_database_connection_url {"},{"line_number":89,"context_line":"    local db_type\u003d$1"},{"line_number":90,"context_line":"    local table_name\u003d$2"},{"line_number":91,"context_line":"    database_connection_url_$db_type $table_name"},{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F9QE%3D","line":91,"in_reply_to":"AAAAW3%2F%2FkRU%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4858393de9f2af2d23bc8b3b4d88b22fa30f5aa2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Recreate a given database table"},{"line_number":63,"context_line":"#  $1 The type of nosql database"},{"line_number":64,"context_line":"#  $2 The name of the table"},{"line_number":65,"context_line":"#  $3 The name of column family"},{"line_number":66,"context_line":"function recreate_nosql_database {"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_97fd1f3d","line":63,"updated":"2014-09-02 15:30:39.000000000","message":"Why table and cf are here? IMHO, it should not be created here, in devstack. After installation Mongo and HBase should be clear and any service should create tables on its own.","commit_id":"f22bfcefe954887245f5abaf125cff93c993e177"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"6e1ed87a7bbe264f057a84f001aa114419b620f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# lib/nosql-database"},{"line_number":2,"context_line":"# Interface for interacting with different nosql database backends"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Dependencies:"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"baa201ad_c2402459","line":1,"updated":"2014-09-29 15:26:50.000000000","message":"please use nosql_database for consistency","commit_id":"ec92be66632f00eb81cfdfa1f48fc6bc1f90f796"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"98563cebfe632f0fd22b2e8ee7ab6b4e9609ac53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# lib/nosql-database"},{"line_number":2,"context_line":"# Interface for interacting with different nosql database backends"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Dependencies:"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"baa201ad_e8c4f093","line":1,"in_reply_to":"baa201ad_c2402459","updated":"2014-10-01 15:01:41.000000000","message":"Done","commit_id":"ec92be66632f00eb81cfdfa1f48fc6bc1f90f796"}],"lib/nosql/hbase":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"15d9a7188d1f4c5224ae6ddb953a0039f719d45f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        exit_distro_not_supported \"hbase installation\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    add_env_var $HBASE_CONF_DIR/hbase-env.sh JAVA_HOME /usr/lib/jvm/java-7-openjdk-amd64/jre"},{"line_number":113,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":114,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":115,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAW3%2F%2Frhk%3D","line":112,"updated":"2014-04-11 07:22:01.000000000","message":"Is this needed? This is same as Line.105.","commit_id":"ef0d5875fbfca070ea8e3f4ca8ada65e97a6e682"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"9c009dbf260df8a6372276e685751c40b4693b60","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        exit_distro_not_supported \"hbase installation\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    add_env_var $HBASE_CONF_DIR/hbase-env.sh JAVA_HOME /usr/lib/jvm/java-7-openjdk-amd64/jre"},{"line_number":113,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":114,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":115,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAW3%2F%2Fq48%3D","line":112,"in_reply_to":"AAAAW3%2F%2Frhk%3D","updated":"2014-04-11 09:14:31.000000000","message":"Thanks, I fixed it. Please, look again.","commit_id":"ef0d5875fbfca070ea8e3f4ca8ada65e97a6e682"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8a1d16bd675f1be160d05deeeb455a2181d595cf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Variables"},{"line_number":13,"context_line":"# ---------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"HBASE_HOST\u003d${HBASE_HOST:-127.0.0.1}"},{"line_number":16,"context_line":"HBASE_PORT\u003d${HBASE_PORT:-9090}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APACHE_MIRROR\u003d${APACHE_MIRROR:-http://archive.apache.org/dist/hbase}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FkR4%3D","line":15,"updated":"2014-04-12 13:57:09.000000000","message":"should default to SERVICE_HOST I think","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Variables"},{"line_number":13,"context_line":"# ---------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"HBASE_HOST\u003d${HBASE_HOST:-127.0.0.1}"},{"line_number":16,"context_line":"HBASE_PORT\u003d${HBASE_PORT:-9090}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APACHE_MIRROR\u003d${APACHE_MIRROR:-http://archive.apache.org/dist/hbase}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F9P4%3D","line":15,"in_reply_to":"AAAAW3%2F%2FkR4%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8a1d16bd675f1be160d05deeeb455a2181d595cf","unresolved":false,"context_lines":[{"line_number":15,"context_line":"HBASE_HOST\u003d${HBASE_HOST:-127.0.0.1}"},{"line_number":16,"context_line":"HBASE_PORT\u003d${HBASE_PORT:-9090}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APACHE_MIRROR\u003d${APACHE_MIRROR:-http://archive.apache.org/dist/hbase}"},{"line_number":19,"context_line":"HBASE_VERSION\u003d${HBASE_VERSION:-0.94.18}"},{"line_number":20,"context_line":"HBASE_TARBALL\u003dhbase-${HBASE_VERSION}.tar.gz"},{"line_number":21,"context_line":"HBASE_DOWNLOAD_URL\u003d${APACHE_MIRROR}/hbase-${HBASE_VERSION}/${HBASE_TARBALL}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FkR0%3D","line":18,"updated":"2014-04-12 13:57:09.000000000","message":"is there an https url we can use for the default?","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":15,"context_line":"HBASE_HOST\u003d${HBASE_HOST:-127.0.0.1}"},{"line_number":16,"context_line":"HBASE_PORT\u003d${HBASE_PORT:-9090}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APACHE_MIRROR\u003d${APACHE_MIRROR:-http://archive.apache.org/dist/hbase}"},{"line_number":19,"context_line":"HBASE_VERSION\u003d${HBASE_VERSION:-0.94.18}"},{"line_number":20,"context_line":"HBASE_TARBALL\u003dhbase-${HBASE_VERSION}.tar.gz"},{"line_number":21,"context_line":"HBASE_DOWNLOAD_URL\u003d${APACHE_MIRROR}/hbase-${HBASE_VERSION}/${HBASE_TARBALL}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F9N4%3D","line":18,"in_reply_to":"AAAAW3%2F%2Fa4k%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done. HBASE_DOWNLOAD_URL variable has been moved to stackrc and uses https as default.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":7600,"name":"Ruslan Kamaldinov","email":"rkamaldinov@mirantis.com","username":"ruhe"},"change_message_id":"24640e12cefed6f61ca303c3ab9368e192155b95","unresolved":false,"context_lines":[{"line_number":15,"context_line":"HBASE_HOST\u003d${HBASE_HOST:-127.0.0.1}"},{"line_number":16,"context_line":"HBASE_PORT\u003d${HBASE_PORT:-9090}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APACHE_MIRROR\u003d${APACHE_MIRROR:-http://archive.apache.org/dist/hbase}"},{"line_number":19,"context_line":"HBASE_VERSION\u003d${HBASE_VERSION:-0.94.18}"},{"line_number":20,"context_line":"HBASE_TARBALL\u003dhbase-${HBASE_VERSION}.tar.gz"},{"line_number":21,"context_line":"HBASE_DOWNLOAD_URL\u003d${APACHE_MIRROR}/hbase-${HBASE_VERSION}/${HBASE_TARBALL}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2Fa4k%3D","line":18,"in_reply_to":"AAAAW3%2F%2FkR0%3D","updated":"2014-04-14 17:43:43.000000000","message":"https://archive.apache.org/dist/hbase/","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"7756896c7eba19b1229caca4c84658d5f31206dd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        echo \"disable \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":82,"context_line":"        echo \"drop \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":"    echo \"create \\\"$db\\\", \\\"t1\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"function install_database_hbase {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FRgo%3D","line":84,"updated":"2014-04-15 16:28:09.000000000","message":"why you create table with column family \u0027t1\u0027? I think it\u0027s incorrect. Column family should be configurable.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        echo \"disable \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":82,"context_line":"        echo \"drop \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":"    echo \"create \\\"$db\\\", \\\"t1\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"function install_database_hbase {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F9Hk%3D","line":84,"in_reply_to":"AAAAW3%2F%2FRgo%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8a1d16bd675f1be160d05deeeb455a2181d595cf","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Download hbase"},{"line_number":98,"context_line":"    wget --continue --no-check-certificat --no-verbose ${HBASE_DOWNLOAD_URL}"},{"line_number":99,"context_line":"    tar xfz ${HBASE_TARBALL} -C ${DEST}"},{"line_number":100,"context_line":"    rm -rf ${HBASE_TARBALL}"},{"line_number":101,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FkRw%3D","line":98,"updated":"2014-04-12 13:57:09.000000000","message":"why not check the certificate? That seems bad.\n\nWe should actually have this function like the cirros image downloads do and pull into files, then it\u0027s cachable, and we will be able to cache it in nodepool.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Download hbase"},{"line_number":98,"context_line":"    wget --continue --no-check-certificat --no-verbose ${HBASE_DOWNLOAD_URL}"},{"line_number":99,"context_line":"    tar xfz ${HBASE_TARBALL} -C ${DEST}"},{"line_number":100,"context_line":"    rm -rf ${HBASE_TARBALL}"},{"line_number":101,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F9Jc%3D","line":98,"in_reply_to":"AAAAW3%2F%2FkRw%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done. Was added download function for Hbase  and HBASE_DOWNLOAD_URL variable has been moved to stackrc. Now we able to cache hbase in nodepool.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8a1d16bd675f1be160d05deeeb455a2181d595cf","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":113,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":114,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"},{"line_number":115,"context_line":"    ${HBASE_BIN_DIR}/start-hbase.sh"},{"line_number":116,"context_line":"    ${HBASE_BIN_DIR}/hbase-daemon.sh start thrift"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAW3%2F%2FkRg%3D","line":115,"updated":"2014-04-12 13:57:09.000000000","message":"configure should be separate step than start. We also need a stop functions.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":10676,"name":"Aleksey Chuprin","email":"achuprin@mirantis.com","username":"achuprin"},"change_message_id":"40e6f02c77f4e4509a4299b5e9babc2cab916642","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":113,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":114,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"},{"line_number":115,"context_line":"    ${HBASE_BIN_DIR}/start-hbase.sh"},{"line_number":116,"context_line":"    ${HBASE_BIN_DIR}/hbase-daemon.sh start thrift"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXH%2F%2F86U%3D","line":115,"in_reply_to":"AAAAW3%2F%2FkRg%3D","updated":"2014-04-16 10:11:43.000000000","message":"Done.\nWas added stop and start functions. Now we launch start function as the last step of configuration. This way is used for example in the postgresql lib.","commit_id":"bd5a84bb8f7a975f6dc03b3b6ee755b1a1c5838e"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"ef871adf537502174bbbeb975dfc123517b8c5ab","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    else"},{"line_number":137,"context_line":"        exit_distro_not_supported \"hbase installation\""},{"line_number":138,"context_line":"    fi"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":141,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":142,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAXH%2F%2Fpo4%3D","line":139,"updated":"2014-04-18 14:17:24.000000000","message":"Could you please add one more option hbase.thrift.minWorkerThreads\u003d200. We use ConnectionPool\u003d100 in Ceilometer now and default value hbase.thrift.minWorkerThreads\u003d16 is not ok for testing","commit_id":"7d1fae8c1ee9bdc57af582cc25721eabcfae8ed6"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"ef0bdd2e65565bba59f86f32b05d7b297f070545","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    else"},{"line_number":137,"context_line":"        exit_distro_not_supported \"hbase installation\""},{"line_number":138,"context_line":"    fi"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.rootdir ${HBASE_ROOT_DIR}"},{"line_number":141,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.dataDir ${HBASE_ZOO_DIR}"},{"line_number":142,"context_line":"    add_property $HBASE_CONF_DIR/hbase-site.xml hbase.zookeeper.property.clientPort ${ZOO_CLIENT_PORT}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAXH%2F%2FKkM%3D","line":139,"in_reply_to":"AAAAXH%2F%2Fpo4%3D","updated":"2014-04-29 14:47:05.000000000","message":"Done","commit_id":"7d1fae8c1ee9bdc57af582cc25721eabcfae8ed6"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"2af7225e269cf7b6406fe863760809699c97e29a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    ${HBASE_BIN_DIR}/hbase-daemon.sh stop thrift"},{"line_number":78,"context_line":"    ${HBASE_BIN_DIR}/stop-hbase.sh"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"function cleanup_database_hbase {"},{"line_number":82,"context_line":"    stop_database_hbase"},{"line_number":83,"context_line":"    sudo rm -rf ${HBASE_DATA_DIR}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"baada198_22ff2f04","line":80,"updated":"2014-07-29 08:50:05.000000000","message":"it\u0027s better to call \u0027destroy_database\u0027 :) It\u0027s very cruel way to remove data from HBase. But I think it *may* be ok for tests and for devstack. Anyway, if you choose this way it\u0027s better to do health check before \u0027start.hbase.sh\u0027. It may be done within shell by running \u0027hbck\u0027 command","commit_id":"75de0a5c09b48e136ef67177a6a3d0b989216c5f"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"e04136c212c452233530f317c43cb23462dbec03","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    ${HBASE_BIN_DIR}/hbase-daemon.sh stop thrift"},{"line_number":78,"context_line":"    ${HBASE_BIN_DIR}/stop-hbase.sh"},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"function cleanup_database_hbase {"},{"line_number":82,"context_line":"    stop_database_hbase"},{"line_number":83,"context_line":"    sudo rm -rf ${HBASE_DATA_DIR}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"baada198_0b0d788f","line":80,"in_reply_to":"baada198_22ff2f04","updated":"2014-07-31 17:12:34.000000000","message":"Done","commit_id":"75de0a5c09b48e136ef67177a6a3d0b989216c5f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"14a8512ec6ad00da600e3f639468468ce0069769","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if ! grep -q \"\u003cname\u003e${prop}\u003c\\/name\u003e\" \"$file\" 2\u003e/dev/null; then"},{"line_number":43,"context_line":"        # Add new property"},{"line_number":44,"context_line":"        sed -i -e \"/^\u003cconfiguration\u003e/ a\\\\"},{"line_number":45,"context_line":"    \u003cproperty\u003e\\n\\    \u003cname\u003e$prop\u003c/name\u003e\\n    \u003cvalue\u003e$value\u003c/value\u003e\\n  \u003c/property\u003e"},{"line_number":46,"context_line":"    \" \"$file\""},{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        # Edit existing property"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_57ab7187","line":45,"updated":"2014-08-01 13:03:45.000000000","message":"You have 4 spaces before \u003cproperty\u003e and only 2 before \u003c/property\u003e. You should use 2 in the beginning","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"430d724c7d73d70601a2b3e30a3da4084f0f33f6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    if ! grep -q \"\u003cname\u003e${prop}\u003c\\/name\u003e\" \"$file\" 2\u003e/dev/null; then"},{"line_number":43,"context_line":"        # Add new property"},{"line_number":44,"context_line":"        sed -i -e \"/^\u003cconfiguration\u003e/ a\\\\"},{"line_number":45,"context_line":"    \u003cproperty\u003e\\n\\    \u003cname\u003e$prop\u003c/name\u003e\\n    \u003cvalue\u003e$value\u003c/value\u003e\\n  \u003c/property\u003e"},{"line_number":46,"context_line":"    \" \"$file\""},{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        # Edit existing property"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_da19587b","line":45,"in_reply_to":"baada198_57ab7187","updated":"2014-08-28 17:43:48.000000000","message":"Done","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"1eafcfa098c8b2b0e3a43a0fa1a63544f58df7f1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    ${HBASE_BIN_DIR}/hbase shell ${HBASE_BIN_DIR}/cleaner"},{"line_number":84,"context_line":"    stop_database_hbase"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"function recreate_database_hbase {"},{"line_number":88,"context_line":"    local db\u003d$1"},{"line_number":89,"context_line":"    local cf\u003d$2"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_84c87957","line":86,"updated":"2014-08-01 11:58:51.000000000","message":"why do you need this function? What is \u0027t1\u0027?","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"430d724c7d73d70601a2b3e30a3da4084f0f33f6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    ${HBASE_BIN_DIR}/hbase shell ${HBASE_BIN_DIR}/cleaner"},{"line_number":84,"context_line":"    stop_database_hbase"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"function recreate_database_hbase {"},{"line_number":88,"context_line":"    local db\u003d$1"},{"line_number":89,"context_line":"    local cf\u003d$2"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_5ac70898","line":86,"in_reply_to":"baada198_84c87957","updated":"2014-08-28 17:43:48.000000000","message":"the variable \"cf\" means column family, i renamed her to \"column_family\" in patch set  9.\nThanks.","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"14a8512ec6ad00da600e3f639468468ce0069769","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    local db\u003d$1"},{"line_number":89,"context_line":"    local cf\u003d$2"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    local cf\u003d${cf:-\"t1\"}"},{"line_number":92,"context_line":"    if $(echo exists \\\"$db\\\" | ${HBASE_BIN_DIR}/hbase shell | grep -wq \"does exist\"); then"},{"line_number":93,"context_line":"        echo \"disable \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":94,"context_line":"        echo \"drop \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"baada198_35eef521","line":91,"updated":"2014-08-01 13:03:45.000000000","message":"Why don\u0027t you use cf\u003d${2:-\"t1\"} ? And whan means \"t1\"?","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"430d724c7d73d70601a2b3e30a3da4084f0f33f6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    local db\u003d$1"},{"line_number":89,"context_line":"    local cf\u003d$2"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    local cf\u003d${cf:-\"t1\"}"},{"line_number":92,"context_line":"    if $(echo exists \\\"$db\\\" | ${HBASE_BIN_DIR}/hbase shell | grep -wq \"does exist\"); then"},{"line_number":93,"context_line":"        echo \"disable \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":94,"context_line":"        echo \"drop \\\"$db\\\"\" | ${HBASE_BIN_DIR}/hbase shell"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_3a3dec8f","line":91,"in_reply_to":"baada198_35eef521","updated":"2014-08-28 17:43:48.000000000","message":"Thanks.\nDone","commit_id":"e0efceb6edd46831727a4a82a3ee123b8b6c8139"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4858393de9f2af2d23bc8b3b4d88b22fa30f5aa2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    stop_database_hbase"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"function recreate_database_hbase {"},{"line_number":88,"context_line":"    local table_name\u003d${1:-\"test\"}"},{"line_number":89,"context_line":"    local column_family\u003d${2:-\"key1\"}"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa98f980_d72c0705","line":87,"updated":"2014-09-02 15:30:39.000000000","message":"And again: why do you need to create a test table?","commit_id":"f22bfcefe954887245f5abaf125cff93c993e177"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4c3b764bff8b6d8af0f92aa89dc6b2adccc802eb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    echo \"create \\\"$table_name\\\", \\\"$column_family\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"function download_database_hbase {"},{"line_number":97,"context_line":"    hbase_fname\u003d`basename \"$HBASE_DOWNLOAD_URL\"`"},{"line_number":98,"context_line":"    if [[ $HBASE_DOWNLOAD_URL !\u003d file* ]]; then"},{"line_number":99,"context_line":"        if [[ ! -f $FILES/$hbase_fname || \"$(stat -c \"%s\" $FILES/$hbase_fname)\" \u003d \"0\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baa201ad_b3207ef8","line":96,"updated":"2014-10-14 04:47:41.000000000","message":"is this not packaged?","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"53df01021438409392f08ee246abf2aecef7d172","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    echo \"create \\\"$table_name\\\", \\\"$column_family\\\"\" | ${HBASE_BIN_DIR}/hbase shell"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"function download_database_hbase {"},{"line_number":97,"context_line":"    hbase_fname\u003d`basename \"$HBASE_DOWNLOAD_URL\"`"},{"line_number":98,"context_line":"    if [[ $HBASE_DOWNLOAD_URL !\u003d file* ]]; then"},{"line_number":99,"context_line":"        if [[ ! -f $FILES/$hbase_fname || \"$(stat -c \"%s\" $FILES/$hbase_fname)\" \u003d \"0\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3a961159_63cd565d","line":96,"in_reply_to":"baa201ad_b3207ef8","updated":"2014-12-10 15:23:07.000000000","message":"Unfortunately not yet for Apache-HBase","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4c3b764bff8b6d8af0f92aa89dc6b2adccc802eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"function install_database_hbase {"},{"line_number":117,"context_line":"    # Install java"},{"line_number":118,"context_line":"    if is_ubuntu; then"},{"line_number":119,"context_line":"        install_package openjdk-7-jdk"},{"line_number":120,"context_line":"    elif is_fedora; then"},{"line_number":121,"context_line":"        install_package java-1.7.0-openjdk"},{"line_number":122,"context_line":"    elif is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baa201ad_d31b42c8","line":119,"updated":"2014-10-14 04:47:41.000000000","message":"entries in files/[apt|rpm]?","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"53df01021438409392f08ee246abf2aecef7d172","unresolved":false,"context_lines":[{"line_number":116,"context_line":"function install_database_hbase {"},{"line_number":117,"context_line":"    # Install java"},{"line_number":118,"context_line":"    if is_ubuntu; then"},{"line_number":119,"context_line":"        install_package openjdk-7-jdk"},{"line_number":120,"context_line":"    elif is_fedora; then"},{"line_number":121,"context_line":"        install_package java-1.7.0-openjdk"},{"line_number":122,"context_line":"    elif is_suse; then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3a961159_83dc0214","line":119,"in_reply_to":"baa201ad_d31b42c8","updated":"2014-12-10 15:23:07.000000000","message":"Done","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"}],"lib/nosql_database":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4c3b764bff8b6d8af0f92aa89dc6b2adccc802eb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Sourcing the nosql database libs sets"},{"line_number":38,"context_line":"for f in $TOP_DIR/lib/nosql/*; do"},{"line_number":39,"context_line":"    source $f;"},{"line_number":40,"context_line":"done"},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baa201ad_132f8af7","line":38,"updated":"2014-10-14 04:47:41.000000000","message":"I\u0027ve seen this cause issues for devs during development when it grabs editor backup files (*~) etc.  Maybe better to source explicitly","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"},{"author":{"_account_id":10829,"name":"Alexei Vinogradov","email":"avinogradov@mirantis.com","username":"spyray"},"change_message_id":"53df01021438409392f08ee246abf2aecef7d172","unresolved":false,"context_lines":[{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Sourcing the nosql database libs sets"},{"line_number":38,"context_line":"for f in $TOP_DIR/lib/nosql/*; do"},{"line_number":39,"context_line":"    source $f;"},{"line_number":40,"context_line":"done"},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3a961159_63e39605","line":38,"in_reply_to":"baa201ad_132f8af7","updated":"2014-12-10 15:23:07.000000000","message":"Maybe you\u0027re right, but I did by analogy with lib/database,\nas example:\n for f in $TOP_DIR/lib/databases/*; do","commit_id":"54e51fc6f49f1e7ba5a279136336f2436407933d"}],"stackrc":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7f3953d52e64e122380e3df63b33363ed4be8e44","unresolved":false,"context_lines":[{"line_number":431,"context_line":"SQLALCHEMY_MIGRATE_BRANCH\u003d${SQLALCHEMY_MIGRATE_BRANCH:-master}"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"# hbase"},{"line_number":434,"context_line":"HBASE_DOWNLOAD_URL\u003d${HBASE_DOWNLOAD_URL:-\"https://archive.apache.org/dist/hbase/hbase-0.94.18/hbase-0.94.18.tar.gz\"}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"#################"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3a961159_467f7dab","line":434,"updated":"2015-01-14 13:33:56.000000000","message":"Why this version ?\nFrom the 0.94 series the 0.94.26 is the current recommended version for downloading. \nThe 0.98 is the current stable branch with \u00270.98.9\u0027.\n\n(0.99.2 is devel)","commit_id":"ed091624f98e10c67f1f0315ebe5e666dfdadecb"}]}