)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbea19b05a91107ff390d6eb812b135d8afcd026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dec7132a_6f104cfb","updated":"2022-12-08 14:15:27.000000000","message":"fast-approving, blocking at least neutron+nova gates","commit_id":"0fcf5104908b3bef84e1db2e3f0dea1263c7b098"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d0b91501123f9d8e26a39691eeb7344dda47866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b46002ee_b384daac","updated":"2022-12-09 05:40:58.000000000","message":"to unblock gate for master, I am pinning tox for now and will continue debugging later to move to tox 4.0.0\n\nBut for stable branches fix, pinning tox\u003c4.0.0 is right way instead of fixing things for all stable branches.\n\nProposed the tox pin which needs to be merged in revers order - https://review.opendev.org/q/I9a138af94dedc0d8ce5a0d519d75779415d3c30b","commit_id":"71742fa265fbe90efb77bc97241412e8ef98d0ce"}],"lib/tempest":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"efb946ebc2f0de9bf10a4dcb2349f3d0505cf0a5","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bba0b2a6_6f027c73","line":710,"updated":"2022-12-08 15:44:00.000000000","message":"This line jumps out to me due to the two lines above it. In particular we are taking three steps:\n\n  707. Install tempest and all of its deps into venv-tempest using constraints\n  709. Install tempest and all of its deps into venv-tempest using a possibly different constraints file\n  710. Install tempest and all of its deps without a constraints file\n  \nAdditionally, we only guard line 707 for running offline. I think this effectively means that tempest installations cannot happen during an offline run of devstack.\n\nMy suggestion for fixing this is that we figure out what the install we need/want actually is and perform that in a single line and guard that properly with the offline check.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"06bdd3b3e72d1610d9c3762885e7a2faaa5ac474","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d5d0e29f_5640809c","line":710,"in_reply_to":"294af0f6_b047abe3","updated":"2022-12-08 17:10:54.000000000","message":"Then I\u0027m failing to understand while L732 tries to pick tempest from outside of the venv-tempest env.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e431c6bbbd5f335a3c76137e86eb5904d10930c","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"db7748af_e6b383b9","line":710,"in_reply_to":"853e917a_950065a1","updated":"2022-12-09 20:47:56.000000000","message":"\u003e Then I\u0027m failing to understand while L732 tries to pick tempest from outside of the venv-tempest env.\n\nBecause it is a different environment. The venv environment installs to .tox/venv (default envdir). The venv-tempest environment installs to .tox/tempest (overridden envdir in the tox.ini).","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"05fbb77e6bb90b8f370c52767aa5ed97ebf6b867","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"294af0f6_b047abe3","line":710,"in_reply_to":"bba0b2a6_6f027c73","updated":"2022-12-08 15:45:17.000000000","message":"Sorry for line 709 the action is install all of tempest deps into venv-tempest using a possibly different constraints file. I don\u0027t think that tempest itself is included in this list. But I believe it is for lines 707 and 709.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d8421846691d5d07cb9b3d5d9f5ca515d8d48c46","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"853e917a_950065a1","line":710,"in_reply_to":"be0805ed_184c3450","updated":"2022-12-08 21:04:38.000000000","message":"I agree that we should not need L710 as tempest is installed in venv-tempest.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eca795a2aca7800b08d757a66809b7aeed5cc099","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"be0805ed_184c3450","line":710,"in_reply_to":"d5d0e29f_5640809c","updated":"2022-12-08 20:16:19.000000000","message":"L732 still passing \u0027tempest\u0027 as a command to tox venv and which is what not in allowlist_externals now.\n\nlet me revise the allowlist_externals and see if that is only where it fail or anywhere also.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ffc74fbedfa05255594c6f521926cdc5559bc40","unresolved":true,"context_lines":[{"line_number":707,"context_line":"        tox -revenv-tempest --notest"},{"line_number":708,"context_line":"    fi"},{"line_number":709,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":710,"context_line":"    tox -evenv-tempest -- pip install ."},{"line_number":711,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    # Auth:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e4624e4f_7e88af41","line":710,"in_reply_to":"db7748af_e6b383b9","updated":"2022-12-09 22:07:42.000000000","message":"yeah that is true but gibi question was when he changed L732 to use \u0027venv-tempest\u0027\n\n    tox -evenv-tempest -- tempest verify-config -uro $tmp_cfg_file\n    \nbut still tox cannot find \u0027tempest\u0027 in \u0027venv-tempest and consider as external command and fail. Which is what the issue we are facing here.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d8421846691d5d07cb9b3d5d9f5ca515d8d48c46","unresolved":true,"context_lines":[{"line_number":729,"context_line":"    # API Extensions"},{"line_number":730,"context_line":"    # Run ``verify_tempest_config -ur`` to retrieve enabled extensions on API endpoints"},{"line_number":731,"context_line":"    # NOTE(mtreinish): This must be done after auth settings are added to the tempest config"},{"line_number":732,"context_line":"    tox -evenv-tempest -- tempest verify-config -uro $tmp_cfg_file"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    # Neutron API Extensions"},{"line_number":735,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"33596416_99c40f04","line":732,"updated":"2022-12-08 21:04:38.000000000","message":"let me try this again and with grenade job fix on stable/zed devstack","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d8421846691d5d07cb9b3d5d9f5ca515d8d48c46","unresolved":true,"context_lines":[{"line_number":729,"context_line":"    # API Extensions"},{"line_number":730,"context_line":"    # Run ``verify_tempest_config -ur`` to retrieve enabled extensions on API endpoints"},{"line_number":731,"context_line":"    # NOTE(mtreinish): This must be done after auth settings are added to the tempest config"},{"line_number":732,"context_line":"    tox -evenv-tempest -- tempest verify-config -uro $tmp_cfg_file"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    # Neutron API Extensions"},{"line_number":735,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7bb44d64_f45cbd4c","line":732,"range":{"start_line":732,"start_character":0,"end_line":732,"end_character":66},"updated":"2022-12-08 21:04:38.000000000","message":"this was bug and it seems it is fixed with this change. now  verify-config is running fine-  https://zuul.opendev.org/t/openstack/build/aaad7312f68246c0979e1a43cfe96c3b/log/job-output.txt#22469","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7dbeb8e0beea2131ac250ba289d91ea6e871b6b1","unresolved":true,"context_lines":[{"line_number":729,"context_line":"    # API Extensions"},{"line_number":730,"context_line":"    # Run ``verify_tempest_config -ur`` to retrieve enabled extensions on API endpoints"},{"line_number":731,"context_line":"    # NOTE(mtreinish): This must be done after auth settings are added to the tempest config"},{"line_number":732,"context_line":"    tox -evenv-tempest -- tempest verify-config -uro $tmp_cfg_file"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    # Neutron API Extensions"},{"line_number":735,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8819f0ac_2e56836e","line":732,"range":{"start_line":732,"start_character":0,"end_line":732,"end_character":66},"in_reply_to":"7bb44d64_f45cbd4c","updated":"2022-12-08 22:38:07.000000000","message":"I referred the PS2 results while commenting the above observation where gibi added the tempest installation at L710. changing only L732 has the same issue of not finding \u0027tempest\u0027 in venv-tempest venv.","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8c7bf7e6c558ab4532e831aa30dd010ad5a8fdbc","unresolved":true,"context_lines":[{"line_number":729,"context_line":"    # API Extensions"},{"line_number":730,"context_line":"    # Run ``verify_tempest_config -ur`` to retrieve enabled extensions on API endpoints"},{"line_number":731,"context_line":"    # NOTE(mtreinish): This must be done after auth settings are added to the tempest config"},{"line_number":732,"context_line":"    tox -evenv-tempest -- tempest verify-config -uro $tmp_cfg_file"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    # Neutron API Extensions"},{"line_number":735,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a9b43277_bd779478","line":732,"range":{"start_line":732,"start_character":0,"end_line":732,"end_character":66},"in_reply_to":"8819f0ac_2e56836e","updated":"2022-12-09 02:58:02.000000000","message":"even same \u0027tempest\u0027 command @L715 also failing in separate job https://zuul.opendev.org/t/openstack/build/2c3757b6a64347898e630b6c129f0582","commit_id":"637651e6d0b51d7787e88dce7da8242e9693959d"}]}