)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0dc4898cd4fbeea4505e1eaed9f261ad027ff64a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a614bd3a_dbbcf542","updated":"2023-03-24 07:52:19.000000000","message":"Thanks for the review Martin, please find my replies inline.","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08822c9b83aca86141005e94a5f41031fab2241b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa9aa8c6_ba4d8fa5","updated":"2023-01-03 11:32:29.000000000","message":"recheck","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8ee1d3a3b6586136e5bffb471d636be43d5d1028","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ea2b4e3_5b99c6af","updated":"2023-01-10 17:24:59.000000000","message":"recheck\n\nThere was another patch against swift on zed that pins tox for external projects: https://review.opendev.org/c/openstack/swift/+/869519","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1ef8e5988675dc42de5fcc8a9e56db6f7bf028fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ad55c6a_5486b32b","updated":"2023-03-25 07:35:24.000000000","message":"recheck post failure","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2aadee0e45202148c205d481ae4cc8c3087c69a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67a78f2b_7dd8246d","updated":"2023-03-27 10:52:18.000000000","message":"recheck random failure of a job which passed in the previous runs","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e94b01199a9897acf6e3329468dcad95d5a879b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f99695d_367431b9","updated":"2023-03-24 20:46:07.000000000","message":"recheck the failure is unrelated and hopefully just one-time occurrence","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b787967162c776dffaafdd79c0673e958d4366b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e58fefbe_c477b558","updated":"2022-12-27 14:35:09.000000000","message":"recheck unrelated failure in nova-ceph-multistore","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8840970b34a53789baf5556ad4508fd7f83196c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da9536ad_03ed9998","updated":"2023-01-03 11:33:29.000000000","message":"since [1] is merged, the swift job should pass now\n\n[1] https://review.opendev.org/c/openstack/swift/+/868932","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c6e7a9cedc06718a840b3fc442558ef5a885976d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eab556b1_a8d82e49","updated":"2023-03-24 08:36:27.000000000","message":"thanks, lgtm","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"}],"lib/cinder_backends/nfs":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaf3e17bcdbb6304ea232dd9a28523b2cb138c40","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    iniset $CINDER_CONF $be_name volume_driver \"cinder.volume.drivers.nfs.NfsDriver\""},{"line_number":34,"context_line":"    iniset $CINDER_CONF $be_name nfs_shares_config \"$CINDER_CONF_DIR/nfs-shares-$be_name.conf\""},{"line_number":35,"context_line":"    iniset $CINDER_CONF $be_name nas_host localhost"},{"line_number":36,"context_line":"    iniset $CINDER_CONF $be_name nas_share_path ${NFS_EXPORT_DIR}"},{"line_number":37,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_operations \\"},{"line_number":38,"context_line":"        ${NFS_SECURE_FILE_OPERATIONS}"},{"line_number":39,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_permissions \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9cf30f88_a144b96e","line":36,"range":{"start_line":36,"start_character":50,"end_line":36,"end_character":64},"updated":"2023-03-13 13:01:34.000000000","message":"I don\u0027t see this var set anywhere in devstack, is that expected?","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c6e7a9cedc06718a840b3fc442558ef5a885976d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    iniset $CINDER_CONF $be_name volume_driver \"cinder.volume.drivers.nfs.NfsDriver\""},{"line_number":34,"context_line":"    iniset $CINDER_CONF $be_name nfs_shares_config \"$CINDER_CONF_DIR/nfs-shares-$be_name.conf\""},{"line_number":35,"context_line":"    iniset $CINDER_CONF $be_name nas_host localhost"},{"line_number":36,"context_line":"    iniset $CINDER_CONF $be_name nas_share_path ${NFS_EXPORT_DIR}"},{"line_number":37,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_operations \\"},{"line_number":38,"context_line":"        ${NFS_SECURE_FILE_OPERATIONS}"},{"line_number":39,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_permissions \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d7684d81_e6d489e4","line":36,"range":{"start_line":36,"start_character":50,"end_line":36,"end_character":64},"in_reply_to":"987972c9_9a7fdc98","updated":"2023-03-24 08:36:27.000000000","message":"I see, thanks for the clarification","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0dc4898cd4fbeea4505e1eaed9f261ad027ff64a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    iniset $CINDER_CONF $be_name volume_driver \"cinder.volume.drivers.nfs.NfsDriver\""},{"line_number":34,"context_line":"    iniset $CINDER_CONF $be_name nfs_shares_config \"$CINDER_CONF_DIR/nfs-shares-$be_name.conf\""},{"line_number":35,"context_line":"    iniset $CINDER_CONF $be_name nas_host localhost"},{"line_number":36,"context_line":"    iniset $CINDER_CONF $be_name nas_share_path ${NFS_EXPORT_DIR}"},{"line_number":37,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_operations \\"},{"line_number":38,"context_line":"        ${NFS_SECURE_FILE_OPERATIONS}"},{"line_number":39,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_permissions \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"987972c9_9a7fdc98","line":36,"range":{"start_line":36,"start_character":50,"end_line":36,"end_character":64},"in_reply_to":"9cf30f88_a144b96e","updated":"2023-03-24 07:52:19.000000000","message":"This is set in devstack-plugin-nfs[1].\nThe plugin works correctly for single cinder backend deployment but when we\u0027re deploying multiple backends, eg, lvm, ceph and nfs then configure_cinder_backend_nfs method is called to configure nfs. devstack-plugin-nfs will always exist in the job run as we can\u0027t configure nfs without devstack-plugin-nfs anyway.\nYou can see the multi backend job (lvm + nfs) here[2] does install devstack successfully as it depends on this patch but without this patch it didn\u0027t configure all these config options and failed to run cinder-volume service hence failing devstack installation.\n\n[1] https://github.com/openstack/devstack-plugin-nfs/blob/f4ad926bdad9bf689dfad21c715f0ba49c2c8332/devstack/plugin.sh#L3\n[2] https://review.opendev.org/c/openstack/glance/+/863977","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaf3e17bcdbb6304ea232dd9a28523b2cb138c40","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    iniset $CINDER_CONF $be_name nas_host localhost"},{"line_number":36,"context_line":"    iniset $CINDER_CONF $be_name nas_share_path ${NFS_EXPORT_DIR}"},{"line_number":37,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_operations \\"},{"line_number":38,"context_line":"        ${NFS_SECURE_FILE_OPERATIONS}"},{"line_number":39,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_permissions \\"},{"line_number":40,"context_line":"        ${NFS_SECURE_FILE_PERMISSIONS}"},{"line_number":41,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b6a0bdba_0aaf8af0","line":38,"range":{"start_line":38,"start_character":10,"end_line":38,"end_character":36},"updated":"2023-03-13 13:01:34.000000000","message":"this one too","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0dc4898cd4fbeea4505e1eaed9f261ad027ff64a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    iniset $CINDER_CONF $be_name nas_host localhost"},{"line_number":36,"context_line":"    iniset $CINDER_CONF $be_name nas_share_path ${NFS_EXPORT_DIR}"},{"line_number":37,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_operations \\"},{"line_number":38,"context_line":"        ${NFS_SECURE_FILE_OPERATIONS}"},{"line_number":39,"context_line":"    iniset $CINDER_CONF $be_name nas_secure_file_permissions \\"},{"line_number":40,"context_line":"        ${NFS_SECURE_FILE_PERMISSIONS}"},{"line_number":41,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"312bf72d_7a76df56","line":38,"range":{"start_line":38,"start_character":10,"end_line":38,"end_character":36},"in_reply_to":"b6a0bdba_0aaf8af0","updated":"2023-03-24 07:52:19.000000000","message":"same as above\n\nhttps://github.com/openstack/devstack-plugin-nfs/blob/f4ad926bdad9bf689dfad21c715f0ba49c2c8332/devstack/plugin.sh#L5","commit_id":"aa47cb34ae25b66e46a216e1c9b7b668615b520b"}]}