)]}'
{".zuul.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"27898b346a55546728cabb4719545a7b8cb7d3fe","unresolved":true,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"- job:"},{"line_number":372,"context_line":"    name: devstack-base"},{"line_number":373,"context_line":"    parent: openstack-multinode-fips"},{"line_number":374,"context_line":"    abstract: true"},{"line_number":375,"context_line":"    description: |"},{"line_number":376,"context_line":"      Base abstract Devstack job."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"268d4aaa_3e7dea5a","line":373,"range":{"start_line":373,"start_character":12,"end_line":373,"end_character":36},"updated":"2023-04-19 16:16:14.000000000","message":"this job is defined in openstack-zuul-jobs repo which inherits from project-config repo [2].\n\nThe previous parent, multinode, was inherited from zuul-jobs [3]. zuul-jobs also has multinode-fips jobs [4], however, I see that multinode-fips job has a different fips playbook than openstack-multinode-fips (from openstack-zuul-jobs repo).\n\nAs I noticed that we\u0027re gonna inherit from different repo (not just from a different job) I got a bit alerted, whether that\u0027s intentional. \n\nOn the other side I see that the multinode playbook used by the multinode job (from zuul-jobs repo) is the same as the one used by openstack-multinode-fips (from openstack-zuul-jobs repo), so there is no logical change from multinode perspective. We will just use the multinode playbook from a different repo (the same content). If others agree, I\u0027m ok with that.\n\n[1] https://opendev.org/openstack/openstack-zuul-jobs/src/commit/b3cad4f7a36929c13d9c74f2de24789741aa5d85/zuul.d/jobs.yaml#L2095\n[2] https://opendev.org/openstack/project-config/src/commit/e1f1945675800dbf888f06cefb53b07e7f92e694/zuul.d/jobs.yaml#L1267\n[3] https://opendev.org/zuul/zuul-jobs/src/commit/0354a8c52d7b0f56fdcbd5e7fa65536779152c34/zuul.d/general-jobs.yaml#L34\n[4] https://opendev.org/zuul/zuul-jobs/src/commit/0354a8c52d7b0f56fdcbd5e7fa65536779152c34/zuul.d/general-jobs.yaml#L42","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"de71b50db4dd0eb8d9cb22ba85e5c59c9485a2c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22ce59d2_21c5efb0","updated":"2023-02-13 10:35:00.000000000","message":"recheck","commit_id":"8991f2bfb311565d04c03ffe67faa909f6398ccf"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ef1a70fb447f89a816762015dd97acfde3dc1dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"333467b6_b9250073","updated":"2023-02-10 21:13:48.000000000","message":"recheck","commit_id":"8991f2bfb311565d04c03ffe67faa909f6398ccf"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"3ff4e1d62d7d443774fc48b2f9b078546da27f3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53b8ca21_e78b14f3","updated":"2023-02-10 15:37:24.000000000","message":"recheck","commit_id":"8991f2bfb311565d04c03ffe67faa909f6398ccf"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"696afbf82cd69ac80eb03c52f98b4f412ae1a07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b47360f_98003143","updated":"2023-02-10 16:37:36.000000000","message":"recheck","commit_id":"8991f2bfb311565d04c03ffe67faa909f6398ccf"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"11cbc29c651ac23bd0f31fc696a32f33a14a7d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28054a23_55e7b864","updated":"2023-02-13 23:47:08.000000000","message":"recheck","commit_id":"e51c7a357603b5f46bf5862ec995b859b98365fb"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c46cfcad608d097d95e1bd8997d6a94f34fbfb65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e0600f17_95b70edf","updated":"2023-02-13 13:03:20.000000000","message":"recheck","commit_id":"e51c7a357603b5f46bf5862ec995b859b98365fb"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a937a8d2b9bcd4fd0b9dbc95f79c7cb35fa2d643","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"54b9c6b6_01cb947c","updated":"2023-02-14 10:18:45.000000000","message":"recheck","commit_id":"ab933b19cc7daee398e16d2dcbee890492b75a98"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"22e3263e584069173320dd93340717621d662fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"be96bb25_bb2d66c0","updated":"2023-04-17 08:43:10.000000000","message":"recheck","commit_id":"bc884d29f677374276acd59233c9fcf8f89ece76"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"27898b346a55546728cabb4719545a7b8cb7d3fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e6ef58eb_6af83407","updated":"2023-04-19 16:16:14.000000000","message":"I confirmed there isn\u0027t a logical change which we had provided by the previous multinode job we were inheriting from, check out my comment, so from my side, +2, but for this kind of change we need at least one more vote from other core(s)","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ad24a2a10bd0ff3c8e7b0af73a15bfbe439511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"276ea069_d5d2e91f","updated":"2023-04-19 18:24:43.000000000","message":"idea looks ok just 1 comment to have check with job side enable_fips var also to consider fips is required here.","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"}],"functions-common":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ad24a2a10bd0ff3c8e7b0af73a15bfbe439511","unresolved":true,"context_lines":[{"line_number":2546,"context_line":"}"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"function is_fips_enabled {"},{"line_number":2549,"context_line":"    fips\u003d`cat /proc/sys/crypto/fips_enabled`"},{"line_number":2550,"context_line":"    [ \"$fips\" \u003d\u003d \"1\" ]"},{"line_number":2551,"context_line":"}"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"194f1351_bd12d044","line":2550,"range":{"start_line":2549,"start_character":0,"end_line":2550,"end_character":22},"updated":"2023-04-19 18:24:43.000000000","message":"can we check var \u0027enable_fips\u0027 which is what job set to enable the fips things? or may be both? because if somewhere in base job or ubuntu image fips is enabled by default somehow then all the devstack jobs get fips emabled things even they have not set enable_fips flag in job definition. having the var enable_fips check also here will make sure jobs disabled fips via enable_fips var explicitly in definition will not fips in any situation.","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"6e68590c6b5929bebc9fe1c2321b2fb6c63bb2ec","unresolved":true,"context_lines":[{"line_number":2546,"context_line":"}"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"function is_fips_enabled {"},{"line_number":2549,"context_line":"    fips\u003d`cat /proc/sys/crypto/fips_enabled`"},{"line_number":2550,"context_line":"    [ \"$fips\" \u003d\u003d \"1\" ]"},{"line_number":2551,"context_line":"}"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"78d2a264_3bd499b0","line":2550,"range":{"start_line":2549,"start_character":0,"end_line":2550,"end_character":22},"in_reply_to":"194f1351_bd12d044","updated":"2023-04-20 09:12:55.000000000","message":"The purpose I had in mind for this boolean was to simply to make sure we had a working mysql (or whatever else) in the case where fips was enabled on the server.\nThis would be independent of however the job was defined, because it would only depend on whether fips was in fact turned on on the server.\n\nIf we want to explicitly reference enable_fips instead - so that we\u0027re basically saying that you must set enable_fips to True in the job - even if you\u0027re using an image with fips enabled by default - I can change to use that instead.\n\nLet me know what you\u0027d prefer.","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da93cf9cc2d5a1cada5487e5578428053a86f5d5","unresolved":true,"context_lines":[{"line_number":2546,"context_line":"}"},{"line_number":2547,"context_line":""},{"line_number":2548,"context_line":"function is_fips_enabled {"},{"line_number":2549,"context_line":"    fips\u003d`cat /proc/sys/crypto/fips_enabled`"},{"line_number":2550,"context_line":"    [ \"$fips\" \u003d\u003d \"1\" ]"},{"line_number":2551,"context_line":"}"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3eb516f8_3a2811ad","line":2550,"range":{"start_line":2549,"start_character":0,"end_line":2550,"end_character":22},"in_reply_to":"78d2a264_3bd499b0","updated":"2023-04-20 22:19:34.000000000","message":"I see your point. basically this will work for all local or non-zuul testing with FIPs image testing.\n\nand  enable_fips is separate flag to configure upstream image with FIPs things - https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/playbooks/fips/enable-fips.yaml#L7\n\nIt make sense, i agree here now. thanks.","commit_id":"15b2e429685fc753759ef8f3773ac559424e028f"}]}