)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4da47927edadf40279c54e1f9fd83b5ac056bd9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef4840b7_46d56873","updated":"2023-01-25 10:36:34.000000000","message":"something seems wrong for rpm-based jobs, I tagged two possible location, but not sure really","commit_id":"a35e3766feba110f97e7fcbcbe3603ac8f6f0506"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d43d83f947adb55ae83a352373f2042d1ed66ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"799ba2e3_895b51d8","updated":"2023-04-18 15:18:15.000000000","message":"+w, this has had a +2 vote for some time, let\u0027s move it forward","commit_id":"ec07b343d25e9964db57ef9c3e2a89deeb5ac56e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"be59facea8fe7c539b8da979483f5735cda936b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68e484fa_06b01dc5","updated":"2023-03-31 16:54:01.000000000","message":"recheck logs expired, rpm jobs still failing","commit_id":"ec07b343d25e9964db57ef9c3e2a89deeb5ac56e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0819fbebca94a2c80dde47cc715e681648b557d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6eb75f5_3b2d8f0f","updated":"2023-04-01 08:10:19.000000000","message":"recheck unrelated volume detach failure","commit_id":"ec07b343d25e9964db57ef9c3e2a89deeb5ac56e"}],"inc/python":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4da47927edadf40279c54e1f9fd83b5ac056bd9b","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Get the path to the directory where python executables are installed."},{"line_number":53,"context_line":"# get_python_exec_prefix"},{"line_number":54,"context_line":"function get_python_exec_prefix {"},{"line_number":55,"context_line":"    local xtrace"},{"line_number":56,"context_line":"    xtrace\u003d$(set +o | grep xtrace)"},{"line_number":57,"context_line":"    set +o xtrace"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0f5de02d_3922efb4","line":54,"updated":"2023-01-25 10:36:34.000000000","message":"IMO this whole function is redundant now, if we don\u0027t clean it up now, we\u0027ll likely never do it","commit_id":"a35e3766feba110f97e7fcbcbe3603ac8f6f0506"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0f085f5e87d5fa2028d831a35dc4e63f81cddcfb","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Get the path to the directory where python executables are installed."},{"line_number":53,"context_line":"# get_python_exec_prefix"},{"line_number":54,"context_line":"function get_python_exec_prefix {"},{"line_number":55,"context_line":"    local xtrace"},{"line_number":56,"context_line":"    xtrace\u003d$(set +o | grep xtrace)"},{"line_number":57,"context_line":"    set +o xtrace"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4b7d3d7a_b57f9ad7","line":54,"in_reply_to":"0f5de02d_3922efb4","updated":"2023-02-16 11:01:27.000000000","message":"redundant? how\u0027s so? None of the steps it executes is needed anymore?","commit_id":"a35e3766feba110f97e7fcbcbe3603ac8f6f0506"}],"lib/horizon":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4da47927edadf40279c54e1f9fd83b5ac056bd9b","unresolved":true,"context_lines":[{"line_number":129,"context_line":"    if is_ubuntu; then"},{"line_number":130,"context_line":"        disable_apache_site 000-default"},{"line_number":131,"context_line":"        sudo touch $horizon_conf"},{"line_number":132,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":133,"context_line":"        : # nothing to do"},{"line_number":134,"context_line":"    else"},{"line_number":135,"context_line":"        exit_distro_not_supported \"horizon apache configuration\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ac9aeb7a_145d57cd","side":"PARENT","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":9},"updated":"2023-01-25 10:36:34.000000000","message":"I think you need to keep this in order to skip the \"else\" branch","commit_id":"864f4d1ef05e3e539d3537fa4c8d731df9571c9d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0f085f5e87d5fa2028d831a35dc4e63f81cddcfb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if is_ubuntu; then"},{"line_number":130,"context_line":"        disable_apache_site 000-default"},{"line_number":131,"context_line":"        sudo touch $horizon_conf"},{"line_number":132,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":133,"context_line":"        : # nothing to do"},{"line_number":134,"context_line":"    else"},{"line_number":135,"context_line":"        exit_distro_not_supported \"horizon apache configuration\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9b4142e3_116d64e0","side":"PARENT","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":9},"in_reply_to":"ac9aeb7a_145d57cd","updated":"2023-02-16 11:01:27.000000000","message":"right, i deleted this by mistake, thanks","commit_id":"864f4d1ef05e3e539d3537fa4c8d731df9571c9d"}],"lib/lvm":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4da47927edadf40279c54e1f9fd83b5ac056bd9b","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    local size\u003d$2"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Start the tgtd service on Fedora and SUSE if tgtadm is used"},{"line_number":133,"context_line":"    if  is_fedora || is_suse  \u0026\u0026 [[ \"$CINDER_TARGET_HELPER\" \u003d \"tgtadm\" ]]; then"},{"line_number":134,"context_line":"        start_service tgtd"},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"613e3bcb_30756637","side":"PARENT","line":133,"updated":"2023-01-25 10:36:34.000000000","message":"I\u0027m not sure about the relative priorities of || vs. \u0026\u0026, maybe the \u0026\u0026 only affected the is_suse part?","commit_id":"864f4d1ef05e3e539d3537fa4c8d731df9571c9d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0f085f5e87d5fa2028d831a35dc4e63f81cddcfb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    local size\u003d$2"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Start the tgtd service on Fedora and SUSE if tgtadm is used"},{"line_number":133,"context_line":"    if  is_fedora || is_suse  \u0026\u0026 [[ \"$CINDER_TARGET_HELPER\" \u003d \"tgtadm\" ]]; then"},{"line_number":134,"context_line":"        start_service tgtd"},{"line_number":135,"context_line":"    fi"},{"line_number":136,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5d5a986f_6b6c15bb","side":"PARENT","line":133,"in_reply_to":"613e3bcb_30756637","updated":"2023-02-16 11:01:27.000000000","message":"very good point! thanks","commit_id":"864f4d1ef05e3e539d3537fa4c8d731df9571c9d"}]}