)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09abc7dfb1380d5ce66ea1122a3a6a9347f54007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"330f70d6_d80561de","updated":"2023-03-14 18:38:14.000000000","message":"After reading Ghanshyam\u0027s comments here and on IRC, I\u0027m dropping my objection.","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6d09d492b7ad111565cfb20b0e8c116b5c4232df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1f8d1172_2e258739","updated":"2023-03-14 14:31:10.000000000","message":"Instead of doing this in devstack, I wonder whether we should move the multiattach tests that require admin intervention to the \u0027tempest.api.volume.admin\u0027 package.  There\u0027s already a precedent for this in tempest:\n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/admin/test_volume_type_access.py\n\nThe tests in that file are checking to see if a regular end-user can access/not access private volume types.  The admin creates the volume-type and sets the access, and then the regular user tries to use the volume type.  So I\u0027d argue that it makes sense for the multiattach tests, which require admin and regular end-user collaboration, to be in the \u0027admin\u0027 package as well.","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6490c4aca0671790966346ff1801ae287f299a8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9f4dd476_1fff9ad9","updated":"2023-03-14 18:10:50.000000000","message":"recheck this time nova-ceph-multistore failed","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9118cadb384f99b7b74b0fb3265bd1f812c2514a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"011092f8_8450a5ec","updated":"2023-03-14 14:24:51.000000000","message":"recheck unrelated error in tempest-ipv6 job\n\ntempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.102 via SSH timed out.\nUser: cirros, Password: Z2*rycktcHeumTW","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3cc50dfb082650d1f6dc4100a24b5dc7e1d86ee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"19afcba0_8c20a167","in_reply_to":"1f8d1172_2e258739","updated":"2023-03-14 18:05:26.000000000","message":"I am not saying we cannot verify the multiataach operation by keeping the test in admin or non admin dir. Technically any test in any dir can request for set of creds to verify the things. \n\nBut main purpose of having ../admin/ dir and tests under them if to separate the tests need and executed by admin users vs non admin. for example anyone should be able to run tempest on env not having admin users. Interop certification program is one example.\n\nIf we move multiattach test to admin dir(I mean test need admin creds) then interop will not be able to test this as interop capability or anyone not having admin creds not able to run this.\n\nBy creating the volume_type in devstck and configure in tempest will test the multiattach operation as close to the end users. Same way we do create flavor for nova instances.","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e11fe1bb0092fc3d1d9bc2e8993ba5498af6c2da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d16632a0_485b6853","updated":"2023-03-15 18:35:24.000000000","message":"I have 1 comment on using volume_type id instead of name (in case name are not unique identifier of volume_type) but as this is urgent I am not blocking for that.","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1626c223bc65ac728e5424aa09f628b7a22357ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"00cfdf40_4b556046","updated":"2023-03-15 19:08:12.000000000","message":"Okay, seems to be working in the dependent tempest patch.","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"057d6c2ad4f5df29150ed805ecec268beeb7179a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"534adb09_3bb21e91","updated":"2023-03-15 18:46:51.000000000","message":"Thanks for the review, please find reply inline.","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b1e5d1ffc7511b9c8909f7d8bb03d2406f1628ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d96b6ea9_71135ba6","updated":"2023-03-15 10:39:16.000000000","message":"The multiattach volume type is created[1] and set in tempest.conf file[2][3]\n\n[1] 2023-03-15 07:44:54.980592 | controller | + lib/cinder:create_volume_types:681       :   create_one_type multiattach multiattach \u0027\u003cis\u003e True\u0027\n2023-03-15 07:44:54.983710 | controller | + lib/cinder:create_one_type:654           :   type_name\u003dmultiattach\n2023-03-15 07:44:54.987092 | controller | + lib/cinder:create_one_type:655           :   property_key\u003dmultiattach\n2023-03-15 07:44:54.990446 | controller | + lib/cinder:create_one_type:656           :   property_value\u003d\u0027\u003cis\u003e True\u0027\n2023-03-15 07:44:54.993593 | controller | + lib/cinder:create_one_type:658           :   is_service_enabled keystone\n2023-03-15 07:44:55.018734 | controller | + functions-common:is_service_enabled:2089 :   return 0\n2023-03-15 07:44:55.021790 | controller | + lib/cinder:create_one_type:659           :   openstack --os-region-name\u003dRegionOne volume type create --property \u0027multiattach\u003d\u003cis\u003e True\u0027 multiattach\n2023-03-15 07:44:57.502179 | controller | +-------------+--------------------------------------+\n2023-03-15 07:44:57.502216 | controller | | Field       | Value                                |\n2023-03-15 07:44:57.502229 | controller | +-------------+--------------------------------------+\n2023-03-15 07:44:57.502236 | controller | | description | None                                 |\n2023-03-15 07:44:57.502242 | controller | | id          | 511a7697-13b9-4cc9-803c-edf11e092967 |\n2023-03-15 07:44:57.502248 | controller | | is_public   | True                                 |\n2023-03-15 07:44:57.502254 | controller | | name        | multiattach                          |\n2023-03-15 07:44:57.502260 | controller | | properties  | multiattach\u003d\u0027\u003cis\u003e True\u0027              |\n2023-03-15 07:44:57.502266 | controller | +-------------+--------------------------------------+\n\n[2] 2023-03-15 07:46:23.151078 | controller | ++ lib/tempest:configure_tempest:608        :   iniset /opt/stack/tempest/etc/tempest.conf volume volume_type_multiattach multiattach\n\n[3]\n[volume]\nvolume_type_multiattach \u003d multiattach\nmax_microversion \u003d latest\nbuild_timeout \u003d 196","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b58e68b296fbf30ab7470905ed218af588e4c4dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f3405534_6b4213b2","updated":"2023-03-15 18:52:53.000000000","message":"for quick ref, this is tempest change using the testing with the created volume_type https://review.opendev.org/c/openstack/tempest/+/875372","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c0d633f51e4a5b860c7b171d0329c1f38506ce2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e0d02679_226364b5","in_reply_to":"f3405534_6b4213b2","updated":"2023-03-15 19:04:41.000000000","message":"here are the link of passing tests in tempest change on master. tempest stable job are failing as we need to backport this change to required stable branch (this comment https://review.opendev.org/c/openstack/tempest/+/875372/comments/0ac67281_724b5ce5)\n\n- https://zuul.opendev.org/t/openstack/build/7a829e3aaad7483cb4fe94823ffb1a9c/log/job-output.txt#22795\n- https://zuul.opendev.org/t/openstack/build/7a829e3aaad7483cb4fe94823ffb1a9c/log/job-output.txt#22812\n- https://zuul.opendev.org/t/openstack/build/7a829e3aaad7483cb4fe94823ffb1a9c/log/job-output.txt#22828\n- https://zuul.opendev.org/t/openstack/build/7a829e3aaad7483cb4fe94823ffb1a9c/log/job-output.txt#22834","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"}],"lib/cinder":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3e9e2daa297930c92612baa8fedefc88de094d4","unresolved":true,"context_lines":[{"line_number":677,"context_line":"        done"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if [[ $ENABLE_VOLUME_MULTIATTACH \u003d\u003d \"True\" ]]; then"},{"line_number":680,"context_line":"            create_one_type \"multiattach\" \"multiattach\" \"\u003cis\u003e True\""},{"line_number":681,"context_line":"        fi"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        # Increase quota for the service project if glance is using cinder,"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"4e4fecc2_eca7ba1b","line":680,"range":{"start_line":680,"start_character":0,"end_line":680,"end_character":67},"updated":"2023-03-14 21:56:44.000000000","message":"We can store this in var VOLUME_TYPE_MULTIATTACH and then set it in tempest.conf new config in lib/tempest\nplease check my comment about new config option in tempest patch","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b5e654eadada8b93cb42bc046494c8aa88232326","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        done"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        if [[ $ENABLE_VOLUME_MULTIATTACH \u003d\u003d \"True\" ]]; then"},{"line_number":680,"context_line":"            create_one_type \"multiattach\" \"multiattach\" \"\u003cis\u003e True\""},{"line_number":681,"context_line":"        fi"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        # Increase quota for the service project if glance is using cinder,"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fe80fd7a_e4e1ba32","line":680,"range":{"start_line":680,"start_character":0,"end_line":680,"end_character":67},"in_reply_to":"4e4fecc2_eca7ba1b","updated":"2023-03-15 07:24:20.000000000","message":"Done","commit_id":"0f903956de8dd65598ea2447661a4568433bef09"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e11fe1bb0092fc3d1d9bc2e8993ba5498af6c2da","unresolved":true,"context_lines":[{"line_number":678,"context_line":"        done"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        if [[ $ENABLE_VOLUME_MULTIATTACH \u003d\u003d \"True\" ]]; then"},{"line_number":681,"context_line":"            create_one_type $VOLUME_TYPE_MULTIATTACH $VOLUME_TYPE_MULTIATTACH \"\u003cis\u003e True\""},{"line_number":682,"context_line":"        fi"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        # Increase quota for the service project if glance is using cinder,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5c424fdd_fca3017f","line":681,"range":{"start_line":681,"start_character":29,"end_line":681,"end_character":53},"updated":"2023-03-15 18:35:24.000000000","message":"is volume_type name a unique identifier or it can be same for multiple volume_type and \u0027id\u0027 (uuid) is only unique? If name is not unique identifier then I will say we store the volume_type id and set the same in tempest.\n\nBut as this is working fine and we are at the edge of final release to get cinder change merged. we can do it in followup if needed","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"63cb4f745ec2c275795f8acab26885351f5ccec0","unresolved":true,"context_lines":[{"line_number":678,"context_line":"        done"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        if [[ $ENABLE_VOLUME_MULTIATTACH \u003d\u003d \"True\" ]]; then"},{"line_number":681,"context_line":"            create_one_type $VOLUME_TYPE_MULTIATTACH $VOLUME_TYPE_MULTIATTACH \"\u003cis\u003e True\""},{"line_number":682,"context_line":"        fi"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        # Increase quota for the service project if glance is using cinder,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"859da817_a7e4d4b8","line":681,"range":{"start_line":681,"start_character":29,"end_line":681,"end_character":53},"in_reply_to":"419239ef_fd807fe6","updated":"2023-03-15 18:56:01.000000000","message":"perfect. thanks.","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"057d6c2ad4f5df29150ed805ecec268beeb7179a","unresolved":true,"context_lines":[{"line_number":678,"context_line":"        done"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        if [[ $ENABLE_VOLUME_MULTIATTACH \u003d\u003d \"True\" ]]; then"},{"line_number":681,"context_line":"            create_one_type $VOLUME_TYPE_MULTIATTACH $VOLUME_TYPE_MULTIATTACH \"\u003cis\u003e True\""},{"line_number":682,"context_line":"        fi"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        # Increase quota for the service project if glance is using cinder,"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"419239ef_fd807fe6","line":681,"range":{"start_line":681,"start_character":29,"end_line":681,"end_character":53},"in_reply_to":"5c424fdd_fca3017f","updated":"2023-03-15 18:46:51.000000000","message":"volume type names are unique and we cannot create 2 volume types with the same name.\n\n$ cinder type-create test-type\n+--------------------------------------+-----------+-------------+-----------+\n| ID                                   | Name      | Description | Is_Public |\n+--------------------------------------+-----------+-------------+-----------+\n| a708aa29-f3cd-4bf2-9c22-dac77206934c | test-type | -           | True      |\n+--------------------------------------+-----------+-------------+-----------+\n$ cinder type-create test-type\nERROR: Volume Type test-type already exists. (HTTP 409) (Request-ID: req-31ac8ef9-d605-4a19-81dd-93e48eb5deae)","commit_id":"1898a683be78622445e48f1f071cf7188ab19450"}]}