)]}'
{"id":"openstack%2Fdevstack~877497","triplet_id":"openstack%2Fdevstack~stable%2F2023.1~Icd3690565bf7b27898cd206641e612da3993703d","project":"openstack/devstack","branch":"stable/2023.1","topic":"877337-stable/2023.1","attention_set":{},"removed_from_attention_set":{"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2023-03-16 08:39:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icd3690565bf7b27898cd206641e612da3993703d","subject":"Create multiattach volume type for tempest","status":"MERGED","created":"2023-03-15 19:15:22.000000000","updated":"2023-03-16 08:40:26.000000000","submitted":"2023-03-16 08:39:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"877497-877337-stable/2023.1","cherry_pick_of_change":877337,"cherry_pick_of_patch_set":8,"meta_rev_id":"7a93f901d77cfd6ab0dd340875d53dde385e6116","_number":877497,"virtual_id_number":877497,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-03-16 08:39:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":2,"date":"2023-03-15 22:27:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"all":[{"value":1,"date":"2023-03-16 07:03:37.000000000","_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":2,"date":"2023-03-15 22:27:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-15 21:21:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-15 22:27:11.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2023-03-16 07:03:37.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"}],"messages":[{"id":"ee883ee1014533239654bba9aa5c9d60be39ba44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2023-03-15 19:15:22.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"3d5d16cb2fb25af3ac00be5d876e2df16c7a18e2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-15 21:21:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/83e4bc396e7b4656bf6dabc6f36cc6ae\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/77b956cca0534194b33f2c1c64983d68 : SUCCESS in 1h 21m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d405cd53f4be46c0bed90ee408b52cdc : SUCCESS in 5m 09s\n- devstack https://zuul.opendev.org/t/openstack/build/767a412d911c42928e1c97ec97941724 : SUCCESS in 23m 40s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/10077b52d46949b0a4fd6390a1285740 : SUCCESS in 22m 06s\n- devstack-enforce-scope https://zuul.opendev.org/t/openstack/build/5ee29e8a40cc4fb99e18dd8b35da7ebc : SUCCESS in 32m 44s\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/fc4161de5a6748d7812a55f44073887f : SUCCESS in 1h 39m 28s (non-voting)\n- devstack-platform-centos-9-stream https://zuul.opendev.org/t/openstack/build/be82003bceb149388e01d2e4106f48b0 : SUCCESS in 1h 25m 04s (non-voting)\n- devstack-platform-debian-bullseye https://zuul.opendev.org/t/openstack/build/4afd27319ca847a7bf9cb0c9afa376d2 : SUCCESS in 1h 05m 34s\n- devstack-platform-rocky-blue-onyx https://zuul.opendev.org/t/openstack/build/9de9ce5d9ff546789a4b3069cae4e404 : SUCCESS in 1h 42m 41s\n- devstack-platform-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9a67a0a4c4c6487fad881ceac090da5b : SUCCESS in 1h 24m 33s\n- devstack-platform-ubuntu-jammy-ovs https://zuul.opendev.org/t/openstack/build/02dd03001fb14352a2442e0ecb128c6a : SUCCESS in 1h 29m 29s (non-voting)\n- devstack-platform-openEuler-22.03-ovn-source https://zuul.opendev.org/t/openstack/build/c1e612a802f04ee99303e2f36905aaeb : SUCCESS in 1h 40m 50s (non-voting)\n- devstack-platform-openEuler-22.03-ovs https://zuul.opendev.org/t/openstack/build/9a1a58131d1c4b43b417b10362d94df7 : SUCCESS in 1h 50m 03s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/c20bccd0aa34432a889ac922f6a84e7e : SUCCESS in 39m 53s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/282758e9856d4f0cbae99ee5fe644182 : SUCCESS in 2m 45s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/e45125a100ad43b8ad4787c259cbdc48 : SUCCESS in 1m 59s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/5e6e86181e584f7993448d0dadfedc83 : SUCCESS in 50m 05s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b002e145d52b4c2c9ea7ba5e73bbf561 : SUCCESS in 41m 15s\n- neutron-linuxbridge-tempest https://zuul.opendev.org/t/openstack/build/e870e687a8474ebc9fbeb4c39ab99bcf : SUCCESS in 58m 03s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/96be31b8a8a441058162cd206e249323 : SUCCESS in 1h 17m 53s (non-voting)\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/ca2181f1d94547bf97f57ece6e4913d5 : SUCCESS in 1h 05m 41s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/da53e98463ff45c68ac9c6281254859b : SUCCESS in 1h 00m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c1c2d39926f7487e943bfed1be7e046f : SUCCESS in 52m 57s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/1cf77558ebde49e59a3fc6dfbe5cf6d8 : SUCCESS in 1h 11m 33s","accounts_in_message":[],"_revision_number":1},{"id":"d50bc64a782dc704ef96ec9d5fbf718626b22ab2","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2023-03-15 22:27:11.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2152efe67d1b3142def3970cb424230e91b70a1a","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2023-03-16 07:03:37.000000000","message":"Patch Set 1: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"32ef3a284e2e4e0be282bd2326f60dcad842dea7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 07:04:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"34e4d2e87e462484cf1a43946e664019df7435b2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 08:39:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e2e8cfc44378429baa4b6424641a7279\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f780a6852e504b4c9ff8f26d150e79f5 : SUCCESS in 1h 27m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/584986b5c54d4949bd12be5c13b9d060 : SUCCESS in 4m 57s\n- devstack https://zuul.opendev.org/t/openstack/build/41d3feea5a39453b9b37b11f2cc37a97 : SUCCESS in 29m 23s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/ae0b6905aa6749a7bf93529cd6efdf04 : SUCCESS in 35m 08s\n- devstack-platform-debian-bullseye https://zuul.opendev.org/t/openstack/build/55a3f3ddd0bc4ed3aeaaabaa9d23b383 : SUCCESS in 1h 21m 44s\n- devstack-platform-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e79aeb67a3fb4e19b830e53232ea2f31 : SUCCESS in 1h 28m 02s\n- devstack-enforce-scope https://zuul.opendev.org/t/openstack/build/e266fdc04a5043cea8d72a493bcc23a1 : SUCCESS in 29m 25s\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/0ff1345cc7b740a08c32633cce54c8f9 : SUCCESS in 41m 50s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/bc157699319f443a8b924244db980179 : SUCCESS in 2m 51s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/51a33e6cb1464c53b34d92c037b3eebb : SUCCESS in 2m 26s\n- neutron-linuxbridge-tempest https://zuul.opendev.org/t/openstack/build/b3f9dcb643a1404bad778e3c2b183527 : SUCCESS in 1h 06m 25s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/0ee18c393c204500af348cfee6c1958d : SUCCESS in 1h 04m 08s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/498916a3f20949c797bb364086725744 : SUCCESS in 57m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cc270c2ed7ef4e698449bf251e3d812d : SUCCESS in 1h 01m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/672cac2a055647c0b8a9aee74b56be4b : SUCCESS in 54m 29s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/dbe1119c3e9d4fe5b43c0823723d7752 : SUCCESS in 1h 15m 22s","accounts_in_message":[],"_revision_number":1},{"id":"30cef59eef32f54870226993cccc3fe897e04a17","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 08:39:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"7a93f901d77cfd6ab0dd340875d53dde385e6116","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-16 08:40:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d217346f8f2e47cb9ae191ebbdbaf55b\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3ca8e9d5df494e579622be04bd1f9084 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"16594b7b2a08fe17002966a959bcbe82fdbe74f8","revisions":{"16594b7b2a08fe17002966a959bcbe82fdbe74f8":{"kind":"REWORK","_number":1,"created":"2023-03-15 19:15:22.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/97/877497/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/97/877497/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/97/877497/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/97/877497/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/97/877497/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/97/877497/1"}}},"commit":{"parents":[{"commit":"77822f74d7723b80a1d487eec213737957deca05","subject":"Update .gitreview for stable/2023.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/77822f74d7723b80a1d487eec213737957deca05"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2023-03-14 05:35:33.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2023-03-15 19:15:22.000000000","tz":0},"subject":"Create multiattach volume type for tempest","message":"Create multiattach volume type for tempest\n\nCreating multiattach volume is a non-admin operation but creating\nmultiattach volume type is an admin operation.\nPreviously cinder allowed creating multiattach volumes without a\nvolume type but that support is being removed with[1].\nThe change requires updating tempest tests[2] but some tempest\ntests are non-admin, which require admin priviledges to create the\nmultiattach volume type.\nBased on the last discussion with tempest team[3], the proposed\nsolution is to create a multiattach volume type in devstack,\nif ENABLE_VOLUME_MULTIATTACH is True, and use it in tempest\ntests. Similar to how admins create multiattach volume types\nfor non-admin users.\n\nThis patch creates a multiattach volume type if\nENABLE_VOLUME_MULTIATTACH is True. Also we set the multiattach\ntype name as a tempest config option \u0027volume_type_multiattach\u0027.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/874865\n[2] https://review.opendev.org/c/openstack/tempest/+/875372\n[3] https://meetings.opendev.org/irclogs/%23openstack-cinder/%23openstack-cinder.2023-03-13.log.html#t2023-03-13T18:47:56\n\nChange-Id: Icd3690565bf7b27898cd206641e612da3993703d\n(cherry picked from commit 1898a683be78622445e48f1f071cf7188ab19450)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/16594b7b2a08fe17002966a959bcbe82fdbe74f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/16594b7b2a08fe17002966a959bcbe82fdbe74f8"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}