)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c52ce661c32b5ed1853a477b8fc7cccd8fe322a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a15e71c6_98351fa0","updated":"2023-04-26 09:55:18.000000000","message":"-1 just for the wrong version being checked","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"be337e84117aef6fe4f833f8795465765e7babaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16fce1e3_6322b763","updated":"2023-04-26 07:51:03.000000000","message":"recheck\ngrenade hit https://bugs.launchpad.net/neutron/+bug/2015065","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4d62bfaf54694e42d918a4e0ee40b94a6dfe825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3330fb92_3efe07fe","updated":"2023-04-26 07:35:22.000000000","message":"recheck one of the tests in a grenade multinode job timeouted out","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab1c9505417464f02db2371335a6a4fa4e6d12d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35c7a4bd_191c3c4f","updated":"2023-05-21 11:23:16.000000000","message":"recheck failures look unrelated","commit_id":"22bb01db917bdff93c334df853e053feb3ece73f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0f50a6ca59440c375a6cfa3466fcfd40a5be428c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c764908_adcfa442","updated":"2023-05-22 17:45:23.000000000","message":"thanks. lgtm","commit_id":"a2943894031e5b1c7662512d54ffb75a3cd3ca9d"}],"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c52ce661c32b5ed1853a477b8fc7cccd8fe322a","unresolved":true,"context_lines":[{"line_number":519,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"},{"line_number":520,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    # since version 0.6.1 cirros uses dhcpcd dhcp client by default, however, tempest uses"},{"line_number":523,"context_line":"    # udhcpc by default which was also cirros\u0027 default prior to the version 0.6.1"},{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5d752b11_f1a91218","line":522,"range":{"start_line":522,"start_character":20,"end_line":522,"end_character":25},"updated":"2023-04-26 09:55:18.000000000","message":"actually that\u0027s since 0.6.0","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a5d325d3695bff26ba8d1772994bbc0fc84bb202","unresolved":true,"context_lines":[{"line_number":519,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"},{"line_number":520,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    # since version 0.6.1 cirros uses dhcpcd dhcp client by default, however, tempest uses"},{"line_number":523,"context_line":"    # udhcpc by default which was also cirros\u0027 default prior to the version 0.6.1"},{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f632b9f5_69fe8c0a","line":522,"range":{"start_line":522,"start_character":20,"end_line":522,"end_character":25},"in_reply_to":"5d752b11_f1a91218","updated":"2023-04-26 12:10:10.000000000","message":"right, thanks, i\u0027ll fix that in a new patch set","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c52ce661c32b5ed1853a477b8fc7cccd8fe322a","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"605d3e10_a8b14b98","line":527,"updated":"2023-04-26 09:55:18.000000000","message":"I\u0027m not sure if we can stick with this as \"good enough for now\", but it is possible to override DEFAULT_IMAGE_FILE_NAME to be not derived from CIRROS_VERSION. so at least a warning note might be good, if not using SCENARIO_IMAGE_FILE to extract the version directly. otoh the image file name may not contain a version at all, so this all is pretty fragile, in the end tempest should autodetect the correct client. or just work with dhcp and not need to do such hacky things at all.","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"85751d8dc110b4c92eb01f63e3287ce933189cd2","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e3e8ac06_b542626e","line":527,"in_reply_to":"2e663688_a221895e","updated":"2023-05-18 17:24:18.000000000","message":"ah you are right. it still download the cirros image. We can always set IMAGE_FILE_TYPE to cirros.","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a5d325d3695bff26ba8d1772994bbc0fc84bb202","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7b611de2_fcc2d980","line":527,"in_reply_to":"605d3e10_a8b14b98","updated":"2023-04-26 12:10:10.000000000","message":"it works - https://review.opendev.org/c/openstack/tempest/+/881536 - the problem we had before with one of the scenario test in tempest-slow jobs and tempest-full-py3 is solved (https://bugs.launchpad.net/tempest/+bug/2007973)\n\nDEFAULT_IMAGE_FILE_NAME not being derived from CIRROS_VERSION is a good point, i considered that, but the alternative would be to check the version directly from SCENARIO_IMAGE_FILE or DEFAULT_IMAGE_FILE_NAME which is a bit worse, as the name doesn\u0027t have to contain the version at all.\nAnyway, this file generates tempest.conf based on what\u0027s being deployed, if a user overrides the image and doesn\u0027t set the CIRROS_VERSION (well, they don\u0027t have to, e.g. if they use a non cirros image) and the image uses a different dhcp client than tempest expects by default, deployment will still work, they\u0027ll just need to modify the tempest.conf before running tempest - as matter of fact any user should verify whether tempest.conf contains the config they intend to run with.\n\ntempest can\u0027t detect the client, tempest doesn\u0027t do any kind of detection, it\u0027s always up to a user what config (tempest.conf) is tempest gonna be executed with - this way we avoid f.e. any unintended skips","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c94ab73cf8c9bed91d371b297a953902e1a1cb4","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"90602323_8d101fba","line":527,"in_reply_to":"7b611de2_fcc2d980","updated":"2023-05-16 01:21:12.000000000","message":"I agree with frickler, this solution is more fragile.\n\nIf we are bumping default image version to 0.6.1 then let\u0027s change the default in tempest also to dhcpcd and stable branch which still use tempest can set it to udhcpc This way at least we will be up to dated from current master onwards.\n\nInstead of auto fetching the version from image file name. let\u0027s hard code it as per known image version used in devstack with a note that if cirros is \u003c0.6.0 thgen use udhcpc otherwise dhcpcd","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0d22300e2f61ba9a69f471dbdd4520532ca33a1d","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e23b7e8b_e60c0ff0","line":527,"in_reply_to":"90602323_8d101fba","updated":"2023-05-16 01:32:44.000000000","message":"or if we want to be more careful about other images and not to change the default dhcp_client for them then let\u0027s keep dhcp_client default as it is today and add a new config option in tempest something \u0027img_file_type\u0027 with default to \u0027cirros\u0027 which is what our CI tests. And based on that img_file_type and CIRROS_VERSION  we can set the dhcp_client here (then it will not need change in devstack stable branches).\n\nAny job or downstream using other than Cirros image can set img_file_type to other value so that they get it what tempest default is.","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"19046665ca6c4a16d705f00106b8739dec2ade2a","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2e663688_a221895e","line":527,"in_reply_to":"e0a48556_77a835d0","updated":"2023-05-18 06:19:08.000000000","message":"hmm, if DEFAULT_IMAGE_NAME or DEFAULT_IMAGE_FILE_NAME aren\u0027t set we\u0027ll default to cirros, right?\n\nhttps://github.com/openstack/devstack/blob/4dfb67a831686279acd66f65e51beba42f675c91/stackrc#L703-L704\n\nCan we then make that assumption to set IMAGE_FILE_TYPE to vmware?","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9a8896e87dbbf88d1be6b882403fc4933757283f","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e58a1450_5c7229cc","line":527,"in_reply_to":"e23b7e8b_e60c0ff0","updated":"2023-05-16 16:37:07.000000000","message":"changing default value in tempest might get us into trouble too, depending on how many consumers rely on the current value\n\n-- 1 -- \n1. patch to devstack master and stable branches to explicitly set the tempest\u0027s current dhcp_client value.\n2. patch to tempest to change the default to dhcpcd\n3. patch to devstack master to use cirros 0.6.1 (and set dhcp_client to dhcpcd, or drop the hardcoding of the value as it\u0027s a new default in tempest)\n\nIn this approach, CI is fine, however, any consumer who implicitly relied on the old tempest\u0027s default will start failing - it\u0027s hard to predict how many affected consumers there would be\n\n-- 2 --\nthis is what you\u0027re proposing in the second comment, although, I\u0027m not fully following that - we can\u0027t use tempest\u0027s option to set another one - therefore I don\u0027t see how img_file_type, a new option in tempest, would help us. We could add a new option, IMG_FILE_TYPE, to devstack and use that with CIRROS_VERSION to set udhcpc or dhcpcd.\nIs that what you meant? \n\nThe second approach is easier than the first one, a single patch and no defaults are changed.","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5b2276166dd736969560e314290ed1032ba26192","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if echo \"$SCENARIO_IMAGE_FILE\" | grep \"cirros\"; then"},{"line_number":525,"context_line":"        # the image is a cirros image"},{"line_number":526,"context_line":"        # use dhcpcd client when version greater or equal 0.6.1"},{"line_number":527,"context_line":"        if [[ $(echo $CIRROS_VERSION | tr -d \u0027.\u0027) -ge 061 ]]; then"},{"line_number":528,"context_line":"            iniset $TEMPEST_CONFIG scenario dhcp_client dhcpcd"},{"line_number":529,"context_line":"        fi"},{"line_number":530,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e0a48556_77a835d0","line":527,"in_reply_to":"e58a1450_5c7229cc","updated":"2023-05-17 01:01:16.000000000","message":"\u003e -- 2 --\n\u003e this is what you\u0027re proposing in the second comment, although, I\u0027m not fully following that - we can\u0027t use tempest\u0027s option to set another one - therefore I don\u0027t see how img_file_type, a new option in tempest, would help us. We could add a new option, IMG_FILE_TYPE, to devstack and use that with CIRROS_VERSION to set udhcpc or dhcpcd.\n\u003e Is that what you meant? \n\u003e \n\u003e The second approach is easier than the first one, a single patch and no defaults are changed.\n\nYeah, I was thinking to add in tempest side but I think devstack var will be easy and more close configuration if DEFAULT_IMAGE_FILE_NAME is overriden.\n\nand we can default IMG_FILE_TYPE to \u0027cirros\u0027 and in below block we can set it to \u0027vmware\u0027 where we know image is vmware one.\n\nhttps://github.com/openstack/devstack/blob/4dfb67a831686279acd66f65e51beba42f675c91/stackrc#L705\n\nalso, add a note in IMG_FILE_TYPE var that if you are overriding DEFAULT_IMAGE_FILE_NAME to different image than cirros, then override IMG_FILE_TYPE also so that devstack can set the correct dhcp_client in Tempest.","commit_id":"b783df4f5eb72fc009f57fc5341f3e686b10216d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab1c9505417464f02db2371335a6a4fa4e6d12d2","unresolved":true,"context_lines":[{"line_number":517,"context_line":"    # Scenario"},{"line_number":518,"context_line":"    SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":519,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"},{"line_number":520,"context_line":"    IMG_FILE_TYPE\u003d${IMG_FILE_TYPE:-cirros}"},{"line_number":521,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # since version 0.6.0 cirros uses dhcpcd dhcp client by default, however, tempest uses"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"db2b4c78_675411d8","line":520,"updated":"2023-05-21 11:23:16.000000000","message":"I\u0027d like SCENARIO_IMAGE_TYPE as a variable name better","commit_id":"22bb01db917bdff93c334df853e053feb3ece73f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a743c97a7717218fb23126d943747ca0ac582e1d","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    # Scenario"},{"line_number":518,"context_line":"    SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":519,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"},{"line_number":520,"context_line":"    IMG_FILE_TYPE\u003d${IMG_FILE_TYPE:-cirros}"},{"line_number":521,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # since version 0.6.0 cirros uses dhcpcd dhcp client by default, however, tempest uses"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cdfea136_f4a87624","line":520,"in_reply_to":"db2b4c78_675411d8","updated":"2023-05-22 10:24:12.000000000","message":"Done","commit_id":"22bb01db917bdff93c334df853e053feb3ece73f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab1c9505417464f02db2371335a6a4fa4e6d12d2","unresolved":true,"context_lines":[{"line_number":521,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # since version 0.6.0 cirros uses dhcpcd dhcp client by default, however, tempest uses"},{"line_number":524,"context_line":"    # udhcpc by default which was also cirros\u0027 default prior to the version 0.6.0"},{"line_number":525,"context_line":"    if [[ \"$IMG_FILE_TYPE\" \u003d\u003d \"cirros\" ]]; then"},{"line_number":526,"context_line":"        # the image is a cirros image"},{"line_number":527,"context_line":"        # use dhcpcd client when version greater or equal 0.6.0"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da06abd8_82ad29ac","line":524,"updated":"2023-05-21 11:23:16.000000000","message":"Nit: That wasn\u0027t \"cirros\u0027 default\", but the only available dhcp client.","commit_id":"22bb01db917bdff93c334df853e053feb3ece73f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a743c97a7717218fb23126d943747ca0ac582e1d","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    iniset $TEMPEST_CONFIG scenario img_file $SCENARIO_IMAGE_DIR/$SCENARIO_IMAGE_FILE"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    # since version 0.6.0 cirros uses dhcpcd dhcp client by default, however, tempest uses"},{"line_number":524,"context_line":"    # udhcpc by default which was also cirros\u0027 default prior to the version 0.6.0"},{"line_number":525,"context_line":"    if [[ \"$IMG_FILE_TYPE\" \u003d\u003d \"cirros\" ]]; then"},{"line_number":526,"context_line":"        # the image is a cirros image"},{"line_number":527,"context_line":"        # use dhcpcd client when version greater or equal 0.6.0"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e3378165_8fb5b306","line":524,"in_reply_to":"da06abd8_82ad29ac","updated":"2023-05-22 10:24:12.000000000","message":"Done","commit_id":"22bb01db917bdff93c334df853e053feb3ece73f"}]}