)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"93330c21175d8151694f2dd7e6f5811a4bee9c34","unresolved":true,"context_lines":[{"line_number":14,"context_line":"utilize it to set required tb-cache size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.opendev.org/c/openstack/nova/+/868419"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":19,"context_line":"Related: blueprint libvirt-tb-cache-size"},{"line_number":20,"context_line":"Change-Id: Ifde737eb5d87dfe860445097d1f2b0ce16b0de05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7d8d8443_53181d96","line":17,"updated":"2024-06-26 16:55:25.000000000","message":"this should also fix https://bugs.launchpad.net/nova/+bug/2070501\n\nand unblock ironic.\n\nthe current approach has unintended precedence issues related to how zuul var and group_vars inter act and also breaks jobs where nova is disabled.","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e85f16af8063b7128a0313fd4e1005c9fd571e62","unresolved":true,"context_lines":[{"line_number":14,"context_line":"utilize it to set required tb-cache size."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.opendev.org/c/openstack/nova/+/868419"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":19,"context_line":"Related: blueprint libvirt-tb-cache-size"},{"line_number":20,"context_line":"Change-Id: Ifde737eb5d87dfe860445097d1f2b0ce16b0de05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a7c289b0_9c5021ea","line":17,"in_reply_to":"7d8d8443_53181d96","updated":"2024-06-27 05:41:17.000000000","message":"Thanks Sean for repicking it","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cf1ce5b4efda53f07bc17d2851418cf4b6a8df8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37a7d297_28255c3b","updated":"2024-06-26 18:50:48.000000000","message":"The experimental queue run is almost done and I can see nova-next passed in the zuul status and I can see `[libvirt]hw_machine_type \u003d x86_64\u003dq35` correctly set on both the controller and subnode:\nhttps://zuul.opendev.org/t/openstack/build/a59b9eafcc4b48258a8a64e418bafdae/log/controller/logs/etc/nova/nova-cpu_conf.txt\nhttps://zuul.opendev.org/t/openstack/build/a59b9eafcc4b48258a8a64e418bafdae/log/compute1/logs/etc/nova/nova-cpu_conf.txt","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4dfae43b6c2dc7b25b652165025cc3337abd5bf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e82d8d13_e9dd419e","updated":"2024-06-26 17:04:36.000000000","message":"check experimental","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad2267250ec62935a0ae8a5c2ca61354691edf26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57a942b3_d3791773","updated":"2024-06-26 16:56:39.000000000","message":"check experimental to see if this fixes nova-next","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"56e6d49b2f57ae0a391182704f9ee3e5f461646e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6246f67_8b17ef29","updated":"2024-06-26 18:53:25.000000000","message":"good enough I\u0027d say","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"13591631ecebca2fbf0eecdd0d3c5a38a055a169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"42a698b0_81ab05ee","updated":"2024-06-26 19:02:53.000000000","message":"lgtm , thanks","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8682d9a857360f5e1d436a9573b7177a7eefb4c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f790ae8_98ee06c2","updated":"2024-06-26 17:31:57.000000000","message":"lgtm, waiting for CI results","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"26caec99fe84f71a2fcabc09fbd3baa9a2f97cc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec334319_a2e74aae","updated":"2024-06-26 20:58:44.000000000","message":"recheck openstacksdk-functional-devstack NoValidHost probably a race of some kind","commit_id":"c707dd3fc2d601db5169508ed39e24dde89e9631"}],"lib/nova":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bd405cf4caeca67345ebcd5ba3cfd83073ce0d0b","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"    # Workaround bug #1939108"},{"line_number":1048,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d\u003d \"libvirt\" \u0026\u0026 \"$LIBVIRT_TYPE\" \u003d\u003d \"qemu\" ]]; then"},{"line_number":1049,"context_line":"        iniset $NOVA_CPU_CONF workarounds libvirt_disable_apic True"},{"line_number":1050,"context_line":"        if [ ${NOVA_LIBVIRT_TB_CACHE_SIZE} -gt 0 ]; then"},{"line_number":1051,"context_line":"            iniset $NOVA_CPU_CONF workarounds libvirt_tb_cache_size ${NOVA_LIBVIRT_TB_CACHE_SIZE}"},{"line_number":1052,"context_line":"        fi"},{"line_number":1053,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6d5e66c0_1d2805ff","line":1050,"updated":"2023-05-02 12:14:14.000000000","message":"im tempted to say we should set this to 128mb by default if \"$LIBVIRT_TYPE\" \u003d\u003d \"qemu\"\n\nwhen i orginally suggested having a devstack patch it was for changing the default\ngiven we can just set it via local.conf direclty otherwise.","commit_id":"09429bdce57861d83ec2c993fa492ec174cba26d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef4539d3b0cc32d631e41917bde0b7529ea7066e","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"    # Workaround bug #1939108"},{"line_number":1048,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d\u003d \"libvirt\" \u0026\u0026 \"$LIBVIRT_TYPE\" \u003d\u003d \"qemu\" ]]; then"},{"line_number":1049,"context_line":"        iniset $NOVA_CPU_CONF workarounds libvirt_disable_apic True"},{"line_number":1050,"context_line":"        if [ ${NOVA_LIBVIRT_TB_CACHE_SIZE} -gt 0 ]; then"},{"line_number":1051,"context_line":"            iniset $NOVA_CPU_CONF workarounds libvirt_tb_cache_size ${NOVA_LIBVIRT_TB_CACHE_SIZE}"},{"line_number":1052,"context_line":"        fi"},{"line_number":1053,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff94bf63_22c785f3","line":1050,"in_reply_to":"264df12d_a8317b18","updated":"2023-05-02 15:08:02.000000000","message":"i was thinkign the former\n\nif local.conf set LIBVIRT_TYPE\u003dqemu, workarounds/libvirt_tb_cache_size\u003d128 is set\n\nbut i also think we can proably hold this patch until we are happy with the sablity of the feature since we can just set it per job as you did in \nhttps://review.opendev.org/c/openstack/nova/+/868419/7/.zuul.yaml#380\n\nso to me the devstack change is useful for when we want to enable it for all jobs.","commit_id":"09429bdce57861d83ec2c993fa492ec174cba26d"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"8210774fd2a7798b562c3d62ce218c1e1ef4f312","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"    # Workaround bug #1939108"},{"line_number":1048,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d\u003d \"libvirt\" \u0026\u0026 \"$LIBVIRT_TYPE\" \u003d\u003d \"qemu\" ]]; then"},{"line_number":1049,"context_line":"        iniset $NOVA_CPU_CONF workarounds libvirt_disable_apic True"},{"line_number":1050,"context_line":"        if [ ${NOVA_LIBVIRT_TB_CACHE_SIZE} -gt 0 ]; then"},{"line_number":1051,"context_line":"            iniset $NOVA_CPU_CONF workarounds libvirt_tb_cache_size ${NOVA_LIBVIRT_TB_CACHE_SIZE}"},{"line_number":1052,"context_line":"        fi"},{"line_number":1053,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"264df12d_a8317b18","line":1050,"in_reply_to":"6d5e66c0_1d2805ff","updated":"2023-05-02 14:02:30.000000000","message":"The way i did was to make it optional by defaulting it to 0 so whoever(for now neutron jobs) so needs it would set it, all other projects/jobs are not impacted by the change.\n\nSo you mean no extra config hook required with devstack?\nif local.conf set LIBVIRT_TYPE\u003dqemu, workarounds/libvirt_tb_cache_size\u003d128 is set?\n\nor you mean extra config option(NOVA_LIBVIRT_TB_CACHE_SIZE) is fine but should defaults to 128, and deployers have option to set it to 0 or some other value as libvirt version may be lower then 8.0.0(like in ubuntu-focal)?","commit_id":"09429bdce57861d83ec2c993fa492ec174cba26d"}]}