)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"933b27c79f9a7c833be52df3fcdcd5e5866e5cb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82db4953_57429b3f","updated":"2023-06-23 22:46:19.000000000","message":"holding it until we figure out the octavia failure","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7482b7a849c80fd27e1d4f77989e99de8e229c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a5af91f_bbb0b8ad","updated":"2023-06-23 03:41:27.000000000","message":"recheck deps updated","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"727d53f1838e2d0ca192e8399a1845e0df1ae79c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d477fd1_b23d7b37","updated":"2023-06-23 04:44:03.000000000","message":"recheck deps updated","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4765a98c2c8d079090ca178908663280cf850947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f4ba52c_cc31ea31","updated":"2023-06-23 22:45:07.000000000","message":"this lgtm, setting img_id and img_id_alt to the same img in that specific condition doesn\u0027t make much sense, i think it might be a relic from old times when it could be used as an optimization (I can imagine) but since then a lot of other things has changed making this not needed anymore ...","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"97c08b348907b62ecccf7549000238c84205c9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8926b38_79aa5c89","in_reply_to":"8f4ba52c_cc31ea31","updated":"2023-06-23 22:47:02.000000000","message":"maybe, I tried to look into the history of 10 years back and could not find any reason behind it.","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81180beb8740f488a5e6904e4c64dc8014d2e508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11ed1af2_a8d87e47","updated":"2023-06-27 18:01:26.000000000","message":"...I have questions 😊","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8c781731892cbbcb71447eed93d942113bfa904f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6e33b61_63b548fb","updated":"2023-06-27 17:50:15.000000000","message":"Ironic job passing here\nOctavia is tested https://review.opendev.org/c/openstack/octavia/+/886807\n\nIt seems ready to go now.","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fa0d575ebc92fc4969f80b5e4628cc7af8f0b07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9fb8780b_b7011598","updated":"2023-06-27 15:14:01.000000000","message":"lgtm, giving my blessing +2","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c05fbdcfa78da88ccc3e4210b7f85f65a0640e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef453339_7d5d2179","updated":"2023-06-27 19:04:22.000000000","message":"I guess Martin was +2 before the cleanup, so I\u0027ll proxy his +2. I had to do some looking into things but I s\u0027pose we\u0027re good.","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a0756db4ef0eabd5e61461ec117e24f7130126dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6b922590_9e7e6fba","updated":"2023-07-18 13:22:06.000000000","message":"recheck .. almost there, an unrelated timeout showed up","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4502e44210ae870f349978bcb89b184adbb21de5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e5f199c5_80401ae5","updated":"2023-07-05 09:44:01.000000000","message":"recheck let\u0027s see if the gates are more favorable at this time","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bdadc098dee2b1f3e1843747b06ff4442368a17a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"451f934e_5c37c53b","updated":"2023-06-28 17:45:15.000000000","message":"recheck neutron ovs job failure not related to this change","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0f5b7725e58e23e9a7022b81a35c830e967df5ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5917d1ab_45baf3b4","updated":"2023-07-13 12:37:36.000000000","message":"recheck random failure","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"59f7eac071d9aa4b412dab94f7083ee85487283e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1acfd1f_93cbfaeb","updated":"2023-07-11 14:37:23.000000000","message":"recheck timeouts","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c581ae80280b8c520db8e74e6e6b4c0fa4668d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04290805_2b3a81b8","updated":"2023-07-17 08:54:56.000000000","message":"recheck unrelated failure","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ab62d814a0bf44708965345a7cc7a321fcdc46a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"13955648_c2d92030","updated":"2023-07-13 20:17:46.000000000","message":"recheck unrelated failure","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca5eab4b078f36d1f47c6534c820dab0ee70ea50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6ac548a_58e9e32b","updated":"2023-06-28 04:43:48.000000000","message":"recheck unrelated failure in multinode job","commit_id":"e32715b2515fdae523a3d113a881f0a57fff9410"}],"lib/tempest":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"9137f803cbc5cfff01f7d1e30c70a519efae93d8","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":159,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":160,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"function poll_glance_images {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0c62c707_99b37b18","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":84},"updated":"2023-06-23 08:13:07.000000000","message":"it still breaks Octavia.\nBasically, during the deployment, Octavia uploads a VM image to glance (the amphora image)\nthis image is returned by get_active_images and in the end, in tempest.conf, image_ref points to the Octavia image and not to the cirros image.\nIs there anything else we can do here to skip some specific images?\n\nin our DNM commit that tests this patch:\nimage_ref:\nhttps://zuul.opendev.org/t/openstack/build/ccf6f6e9efdf4a3db8ddbe8f5c451e6e/log/job-output.txt#21722\nwhich is the octavia image:\nhttps://zuul.opendev.org/t/openstack/build/ccf6f6e9efdf4a3db8ddbe8f5c451e6e/log/job-output.txt#19574","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7285d19b13f66d8a983d196875e7a843d2abed11","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":159,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":160,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"function poll_glance_images {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"28af1484_ab658fec","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":84},"in_reply_to":"0c62c707_99b37b18","updated":"2023-06-27 02:16:01.000000000","message":"ok, let me keep logic to return the DEFAULT_IMAGE_NAME image in image_ref and we can set image_ref_alt to something else in all condition","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2f32c62d81166ffea9cbee767f591d6b7048acd2","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":159,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":160,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"function poll_glance_images {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"50f2b1b4_2a291b10","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":84},"in_reply_to":"28af1484_ab658fec","updated":"2023-06-27 06:40:46.000000000","message":"Thanks, it looks good in the Octavia CI (image_ref_alt is now the id of the amphora image, but we don\u0027t use image_ref_alt in octavia-tempest-plugin, so I guess it\u0027s fine for us, however some other people may have some concerns about that)\nWe noticed that the issue also impacts the stable branches, are you going to backport this patch?","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"85dc2788874f6936a3052714dfbc35ae3fafd244","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":159,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":160,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"function poll_glance_images {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fd22c72c_f9f21c99","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":84},"in_reply_to":"50f2b1b4_2a291b10","updated":"2023-06-27 17:49:37.000000000","message":"thanks. image_ref_alt is set to the one uploaded by devstack as pert of configured images. any job need specific image to test on as alt then we can think of a new variable in devstack and set the alt image also as asked. But as there is no such use case I will leave that part.\n\nNo, we will not backport this at least no requirement of backport for now.","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"51837d8eaa99acd764c88f1371a75987398849ae","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":159,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":160,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"},{"line_number":161,"context_line":"}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"function poll_glance_images {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0618f81d_d0d06c57","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":84},"in_reply_to":"fd22c72c_f9f21c99","updated":"2023-06-27 18:45:09.000000000","message":"Done","commit_id":"16214ad963d92a979c2566ec272c40a56a927c45"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81180beb8740f488a5e6904e4c64dc8014d2e508","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":162,"context_line":"        if [ \"$IMAGE_NAME\" \u003d \"$DEFAULT_IMAGE_NAME\" ]; then"},{"line_number":163,"context_line":"            img_id\u003d\"$IMAGE_UUID\""},{"line_number":164,"context_line":"            img_id_alt\u003d\"$IMAGE_UUID\""},{"line_number":165,"context_line":"        fi"},{"line_number":166,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":167,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5af6aaa4_e701734c","side":"PARENT","line":164,"updated":"2023-06-27 18:01:26.000000000","message":"I guess I\u0027m missing how these are used and thus why removing one matters at all. Does `declare -n` mean we update whatever variable they passed in somehow?","commit_id":"39228451b6542ff63f288affbda13897089eb16d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2598c35ddcf5f75988cc69bc8e84a1040b382be6","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":162,"context_line":"        if [ \"$IMAGE_NAME\" \u003d \"$DEFAULT_IMAGE_NAME\" ]; then"},{"line_number":163,"context_line":"            img_id\u003d\"$IMAGE_UUID\""},{"line_number":164,"context_line":"            img_id_alt\u003d\"$IMAGE_UUID\""},{"line_number":165,"context_line":"        fi"},{"line_number":166,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":167,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"96bf6c94_69b4e20d","side":"PARENT","line":164,"in_reply_to":"5af6aaa4_e701734c","updated":"2023-06-27 18:39:59.000000000","message":"yeah, with -n the passed variable (L230) is set with the $IMAGE_UUID but with the value setting removal, we do not need delcare itself here for the $3. let me cleanup this.","commit_id":"39228451b6542ff63f288affbda13897089eb16d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"51837d8eaa99acd764c88f1371a75987398849ae","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":162,"context_line":"        if [ \"$IMAGE_NAME\" \u003d \"$DEFAULT_IMAGE_NAME\" ]; then"},{"line_number":163,"context_line":"            img_id\u003d\"$IMAGE_UUID\""},{"line_number":164,"context_line":"            img_id_alt\u003d\"$IMAGE_UUID\""},{"line_number":165,"context_line":"        fi"},{"line_number":166,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":167,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a8297ec2_a601dc12","side":"PARENT","line":164,"in_reply_to":"96bf6c94_69b4e20d","updated":"2023-06-27 18:45:09.000000000","message":"Done","commit_id":"39228451b6542ff63f288affbda13897089eb16d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c05fbdcfa78da88ccc3e4210b7f85f65a0640e57","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    while read -r IMAGE_NAME IMAGE_UUID; do"},{"line_number":162,"context_line":"        if [ \"$IMAGE_NAME\" \u003d \"$DEFAULT_IMAGE_NAME\" ]; then"},{"line_number":163,"context_line":"            img_id\u003d\"$IMAGE_UUID\""},{"line_number":164,"context_line":"            img_id_alt\u003d\"$IMAGE_UUID\""},{"line_number":165,"context_line":"        fi"},{"line_number":166,"context_line":"        img_array+\u003d($IMAGE_UUID)"},{"line_number":167,"context_line":"    done \u003c \u003c(openstack --os-cloud devstack-admin image list --property status\u003dactive | awk -F\u0027|\u0027 \u0027!/^(+--)|ID|aki|ari/ { print $3,$2 }\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e059a973_a17f8526","side":"PARENT","line":164,"in_reply_to":"a8297ec2_a601dc12","updated":"2023-06-27 19:04:22.000000000","message":"Okay, `-n` links two variables so they point at the same memory/storage or something? That seems pretty dangerous and obscure, but okay :)","commit_id":"39228451b6542ff63f288affbda13897089eb16d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81180beb8740f488a5e6904e4c64dc8014d2e508","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                elif [ -z \"$image_uuid_alt\" ]; then"},{"line_number":264,"context_line":"                    for image in $images; do"},{"line_number":265,"context_line":"                        if [[ \"$image\" !\u003d \"$image_uuid\" ]]; then"},{"line_number":266,"context_line":"                            image_uuid_alt\u003d$image"},{"line_number":267,"context_line":"                        fi"},{"line_number":268,"context_line":"                    done"},{"line_number":269,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"648a76e0_899e99ab","line":266,"updated":"2023-06-27 18:01:26.000000000","message":"To be clear, this will silently still allow `image_uuid_alt` to be empty, which I guess makes sense for most cases. We\u0027ll just only set it if we find another image to use.","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2598c35ddcf5f75988cc69bc8e84a1040b382be6","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                elif [ -z \"$image_uuid_alt\" ]; then"},{"line_number":264,"context_line":"                    for image in $images; do"},{"line_number":265,"context_line":"                        if [[ \"$image\" !\u003d \"$image_uuid\" ]]; then"},{"line_number":266,"context_line":"                            image_uuid_alt\u003d$image"},{"line_number":267,"context_line":"                        fi"},{"line_number":268,"context_line":"                    done"},{"line_number":269,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b9ca2a51_cb2d19fe","line":266,"in_reply_to":"648a76e0_899e99ab","updated":"2023-06-27 18:39:59.000000000","message":"As this case *) meand we will have more than 1 image so we will be setting image_uuid_alt always right? previous case L251 will set the both to same uuid as we have only one image in glance.","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c05fbdcfa78da88ccc3e4210b7f85f65a0640e57","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                elif [ -z \"$image_uuid_alt\" ]; then"},{"line_number":264,"context_line":"                    for image in $images; do"},{"line_number":265,"context_line":"                        if [[ \"$image\" !\u003d \"$image_uuid\" ]]; then"},{"line_number":266,"context_line":"                            image_uuid_alt\u003d$image"},{"line_number":267,"context_line":"                        fi"},{"line_number":268,"context_line":"                    done"},{"line_number":269,"context_line":"                fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"43cfd808_47c814fe","line":266,"in_reply_to":"b9ca2a51_cb2d19fe","updated":"2023-06-27 19:04:22.000000000","message":"Oh I see, I missed the `case`, got it.","commit_id":"d130d85238da1c2e90610e7fdd4b70a401bdf3cc"}]}