)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch: https://review.opendev.org/c/openstack/devstack/+/882299"},{"line_number":10,"context_line":"provides functionality, that commit hash can be passed as last arugment,"},{"line_number":11,"context_line":"howewer when GIT_DEPTH is set, it fails, as in:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"timeout -s SIGINT 0 git clone https://github.com/ovn-org/ovn.git ./ovn"},{"line_number":14,"context_line":"--depth 1 --branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a8b1be72_7cadb50e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2023-07-18 14:03:42.000000000","message":"nit: however","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"0698fbb5700137c44b08652ef01ae132b109f791","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch: https://review.opendev.org/c/openstack/devstack/+/882299"},{"line_number":10,"context_line":"provides functionality, that commit hash can be passed as last arugment,"},{"line_number":11,"context_line":"howewer when GIT_DEPTH is set, it fails, as in:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"timeout -s SIGINT 0 git clone https://github.com/ovn-org/ovn.git ./ovn"},{"line_number":14,"context_line":"--depth 1 --branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d4c0cab2_c5879702","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"a8b1be72_7cadb50e","updated":"2023-07-19 20:52:25.000000000","message":"Done","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":14,"context_line":"--depth 1 --branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":15,"context_line":"fatal: Remote branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":16,"context_line":"not found in upstream origin"},{"line_number":17,"context_line":"Change-Id: I5e0ca8ff999ea5a807a957d145e9cfb889c863eb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I748354964a133e028e12458cc9014d6d014cbdb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d3db7e0_65f447c0","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":5},"updated":"2023-07-18 14:03:42.000000000","message":"why do you have 2 change-id?","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9402202a2360c76061b192d100aa4ba5b24b9770","unresolved":false,"context_lines":[{"line_number":14,"context_line":"--depth 1 --branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":15,"context_line":"fatal: Remote branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":16,"context_line":"not found in upstream origin"},{"line_number":17,"context_line":"Change-Id: I5e0ca8ff999ea5a807a957d145e9cfb889c863eb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I748354964a133e028e12458cc9014d6d014cbdb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1c432545_8fe99ade","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":5},"in_reply_to":"5d3db7e0_65f447c0","updated":"2023-07-20 08:06:00.000000000","message":"Done","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":15,"context_line":"fatal: Remote branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":16,"context_line":"not found in upstream origin"},{"line_number":17,"context_line":"Change-Id: I5e0ca8ff999ea5a807a957d145e9cfb889c863eb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I748354964a133e028e12458cc9014d6d014cbdb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"00dc1983_a2517f71","line":18,"updated":"2023-07-18 14:03:42.000000000","message":"let\u0027s also add the following so that the patch is automatically linked with the bug you\u0027re working on:\n\nCloses-Bug: #2023020","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"0698fbb5700137c44b08652ef01ae132b109f791","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fatal: Remote branch 03b95a4566a15f7544f4cdf35629dacede4dcf55"},{"line_number":16,"context_line":"not found in upstream origin"},{"line_number":17,"context_line":"Change-Id: I5e0ca8ff999ea5a807a957d145e9cfb889c863eb"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I748354964a133e028e12458cc9014d6d014cbdb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74a3d4a9_1635e3c6","line":18,"in_reply_to":"00dc1983_a2517f71","updated":"2023-07-19 20:52:25.000000000","message":"Done","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9c7ad99_51c16107","updated":"2023-07-18 14:03:42.000000000","message":"the overall idea seems good to me, it seems to be working .. i have a few inline comments","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"428d659832349732530df8b7b1fa369a3c686aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cdc8bd2_0c7f0eec","updated":"2023-07-20 08:08:02.000000000","message":"Jakub please propose this to master branch, only after it\u0027s merged in master branch we can backport (if needed) back to stable branches.","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2e9811d188fbbb7a5e36355c3e6ba18467640a12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7b1d4fc_29038a24","updated":"2023-07-20 08:06:47.000000000","message":"lgtm, thanks","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5f2785cbe65f67ee6271a5a8c93a7b9e9544a865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ccb307a3_4c82ee9d","updated":"2023-08-14 07:26:21.000000000","message":"now we can continue with this","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"234870686936200fd4130b273c620da71a9682a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9b26235_61eb8f61","updated":"2023-08-07 09:57:33.000000000","message":"the master patch has been merged as well as it\u0027s been cherry-picked to other stable branches","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2ae0f22166e3b13eaa9021d17ebe4f7fb145ed85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe5073e7_fd73e236","updated":"2023-07-20 08:07:10.000000000","message":"wait a second, this isn\u0027t on master branch","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fac1b1bda6e083a30a8b0a1e8e9154c0a52a188c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"215ae5f7_cd8f57a7","in_reply_to":"5cdc8bd2_0c7f0eec","updated":"2023-07-20 08:36:19.000000000","message":"we can continue with this patch only after the master one is merged https://review.opendev.org/c/openstack/devstack/+/889012 as well as all newer stable/branches are updated (zed, 2023.1)","commit_id":"0a1ea3ed531a0c331e73d57b318b1d7450a8848f"}],"functions-common":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":646,"context_line":"                echo \"the project to the \\$PROJECTS variable in the job definition.\""},{"line_number":647,"context_line":"                die $LINENO \"ERROR_ON_CLONE is set to True so cloning not allowed in this configuration\""},{"line_number":648,"context_line":"            fi"},{"line_number":649,"context_line":"            git_timed clone --no-checkout $git_clone_flags $git_remote $git_dest"},{"line_number":650,"context_line":"            cd $git_dest"},{"line_number":651,"context_line":"            git_timed fetch $git_clone_flags origin $git_ref"},{"line_number":652,"context_line":"            git_timed checkout FETCH_HEAD"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"36a73e6d_fe2ac99e","line":649,"range":{"start_line":649,"start_character":28,"end_line":649,"end_character":41},"updated":"2023-07-18 14:03:42.000000000","message":"tbh, i\u0027m not entirely sure what this did, i tried it with and without it and i haven\u0027t noticed any difference","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"0698fbb5700137c44b08652ef01ae132b109f791","unresolved":true,"context_lines":[{"line_number":646,"context_line":"                echo \"the project to the \\$PROJECTS variable in the job definition.\""},{"line_number":647,"context_line":"                die $LINENO \"ERROR_ON_CLONE is set to True so cloning not allowed in this configuration\""},{"line_number":648,"context_line":"            fi"},{"line_number":649,"context_line":"            git_timed clone --no-checkout $git_clone_flags $git_remote $git_dest"},{"line_number":650,"context_line":"            cd $git_dest"},{"line_number":651,"context_line":"            git_timed fetch $git_clone_flags origin $git_ref"},{"line_number":652,"context_line":"            git_timed checkout FETCH_HEAD"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"90aa66ae_ccbb7433","line":649,"range":{"start_line":649,"start_character":28,"end_line":649,"end_character":41},"in_reply_to":"36a73e6d_fe2ac99e","updated":"2023-07-19 20:52:25.000000000","message":"This should speed up the process as the default branch would automatically be checked out when calling git clone. But yes, the acceleration is not that significant.","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":648,"context_line":"            fi"},{"line_number":649,"context_line":"            git_timed clone --no-checkout $git_clone_flags $git_remote $git_dest"},{"line_number":650,"context_line":"            cd $git_dest"},{"line_number":651,"context_line":"            git_timed fetch $git_clone_flags origin $git_ref"},{"line_number":652,"context_line":"            git_timed checkout FETCH_HEAD"},{"line_number":653,"context_line":"            cd .."},{"line_number":654,"context_line":"        elif [[ \"$RECLONE\" \u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7b2008a8_fee64271","line":651,"range":{"start_line":651,"start_character":20,"end_line":651,"end_character":57},"updated":"2023-07-18 14:03:42.000000000","message":"this step makes total sense, we have to fetch the desired git_ref to make sure it is downloaded","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"638f8ce36bb7fae3d011a8832104268717060820","unresolved":true,"context_lines":[{"line_number":650,"context_line":"            cd $git_dest"},{"line_number":651,"context_line":"            git_timed fetch $git_clone_flags origin $git_ref"},{"line_number":652,"context_line":"            git_timed checkout FETCH_HEAD"},{"line_number":653,"context_line":"            cd .."},{"line_number":654,"context_line":"        elif [[ \"$RECLONE\" \u003d \"True\" ]]; then"},{"line_number":655,"context_line":"            # if it does exist then simulate what clone does if asked to RECLONE"},{"line_number":656,"context_line":"            cd $git_dest"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"148183e3_4f5865ab","line":653,"range":{"start_line":653,"start_character":12,"end_line":653,"end_character":17},"updated":"2023-07-18 14:03:42.000000000","message":"this isn\u0027t required, after this the code moves to cloning other dir or something else .. regardless the location we\u0027re currently at","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"0698fbb5700137c44b08652ef01ae132b109f791","unresolved":false,"context_lines":[{"line_number":650,"context_line":"            cd $git_dest"},{"line_number":651,"context_line":"            git_timed fetch $git_clone_flags origin $git_ref"},{"line_number":652,"context_line":"            git_timed checkout FETCH_HEAD"},{"line_number":653,"context_line":"            cd .."},{"line_number":654,"context_line":"        elif [[ \"$RECLONE\" \u003d \"True\" ]]; then"},{"line_number":655,"context_line":"            # if it does exist then simulate what clone does if asked to RECLONE"},{"line_number":656,"context_line":"            cd $git_dest"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f0fb8eb8_766e4929","line":653,"range":{"start_line":653,"start_character":12,"end_line":653,"end_character":17},"in_reply_to":"148183e3_4f5865ab","updated":"2023-07-19 20:52:25.000000000","message":"Done","commit_id":"6eb23ab0c761944585fe514b246deb26496f8ba4"}]}