)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add support for zswap and ksmtuned"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"902340e9_822aafe2","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":34},"updated":"2023-10-19 19:43:50.000000000","message":"\"configure_ksm\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"add support for zswap and ksmtuned"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"32e74b57_d2740af8","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":42},"updated":"2023-10-19 19:43:50.000000000","message":"\"function\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add support for zswap and ksmtuned"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4a7dcbf6_73f6b7ac","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":42},"in_reply_to":"32e74b57_d2740af8","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add support for zswap and ksmtuned"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b8104aae_476f5783","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":34},"in_reply_to":"902340e9_822aafe2","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b4805f9f_e6ea5ca2","line":11,"updated":"2023-10-19 19:43:50.000000000","message":"\"Additional support\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"37e25474_28dd57be","line":11,"in_reply_to":"b4805f9f_e6ea5ca2","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"},{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"61170f65_b3db0e0c","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":31},"updated":"2023-10-19 19:43:50.000000000","message":"\"defaults\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change add a new lib/host-mem file and moves the existing"},{"line_number":10,"context_line":"ksm support to a new confiugre_ksm funtion."},{"line_number":11,"context_line":"Addtional supprot for ksmtuned is added with a new flag"},{"line_number":12,"context_line":"\"ENABLE_KSMTUNED\" which default to true."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"},{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"34674b0d_17b1ea8f","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":31},"in_reply_to":"61170f65_b3db0e0c","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"},{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"},{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b6d8743b_7b2df37b","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":20},"updated":"2023-10-19 19:43:50.000000000","message":"\"distros\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This change also adds support for zswap. zswap is disabled"},{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"},{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d2c88607_634ccf9f","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":20},"in_reply_to":"b6d8743b_7b2df37b","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"},{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"a300179b_f65b8451","line":18,"range":{"start_line":18,"start_character":3,"end_line":18,"end_character":4},"updated":"2023-10-19 19:43:50.000000000","message":"Caps","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":15,"context_line":"by default. when enabled on ubuntu lz4 will"},{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"113b7bf9_451ab6cd","line":18,"range":{"start_line":18,"start_character":3,"end_line":18,"end_character":4},"in_reply_to":"a300179b_f65b8451","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"2586faac_ea2b319c","line":19,"range":{"start_line":19,"start_character":47,"end_line":19,"end_character":57},"updated":"2023-10-19 19:43:50.000000000","message":"\"performance\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":16,"context_line":"be used as the default compressor and z3fold as the zpool."},{"line_number":17,"context_line":"on non debian distos the compressor and zpool are not set."},{"line_number":18,"context_line":"the default values should result in very low overhead although"},{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"634ca1e1_c74bdd78","line":19,"range":{"start_line":19,"start_character":47,"end_line":19,"end_character":57},"in_reply_to":"2586faac_ea2b319c","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"855d7390_6a3b744f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":11},"updated":"2023-10-19 19:43:50.000000000","message":"\"Additionally\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"760bbe32_17196754","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":60},"updated":"2023-10-19 19:43:50.000000000","message":"\"optionally\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"48e229ea_703ff774","line":22,"range":{"start_line":22,"start_character":31,"end_line":22,"end_character":37},"updated":"2023-10-19 19:43:50.000000000","message":"\"sysctl\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f8ad8a1d_bef172aa","line":22,"range":{"start_line":22,"start_character":45,"end_line":22,"end_character":46},"updated":"2023-10-19 19:43:50.000000000","message":"\"tuning\"","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1b5e0740_a27fd155","line":22,"range":{"start_line":22,"start_character":31,"end_line":22,"end_character":37},"in_reply_to":"48e229ea_703ff774","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f231bf6_2c2e97f8","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":60},"in_reply_to":"760bbe32_17196754","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d72188db_5a6ef85a","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":11},"in_reply_to":"855d7390_6a3b744f","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f378b4caf8b2fe0a60b538dd369812230bb2153","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the zstd compressor may provide better overall perfroamce in ci"},{"line_number":20,"context_line":"or with slow io due to the higher compression ratio."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"addtionally memory and network sycctl tunnign are optoinally applied"},{"line_number":23,"context_line":"to defer writes, prefer swapping and optimise tcp connection"},{"line_number":24,"context_line":"startup and keepalive. The sysctl tunings are disabled by default"},{"line_number":25,"context_line":"The base devstack job has been modifed to enable zram and sysctl"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"a3a2b47a_3228bedb","line":22,"range":{"start_line":22,"start_character":45,"end_line":22,"end_character":46},"in_reply_to":"f8ad8a1d_bef172aa","updated":"2023-11-08 12:56:52.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"42d3f40a92223ff77bf2c54fe30c613bf2a04512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6790bb97_6659fc8c","updated":"2023-10-19 19:41:06.000000000","message":"I\u0027m in favor of at least having these knobs so we can turn them on in our jobs and then talk about default-on later.","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0018c1fff899ed499b285e892f3a020fd75c1be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cb68cd6e_faba6080","updated":"2023-10-19 19:43:50.000000000","message":"Okay I blew right past the commit message. Please fix those things and *then* I will be +2.","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a23170d9_6670571d","in_reply_to":"6790bb97_6659fc8c","updated":"2023-12-07 21:36:52.000000000","message":"AFAICT the .zuul.yaml change in this patch is already defaulting to on.","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1fa1b3cd_1ba59bea","updated":"2023-12-07 21:36:52.000000000","message":"This looks interesting to try for improving performance in job runs.","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0009a8e9d6659313eba1408a2ff7571175aad40a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9c4e4899_04117286","updated":"2023-12-08 18:06:20.000000000","message":"thanks melaine ill adress the remaining typos on monday.","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6a3452a5ad854087296d4c456f2e22c9e66a1148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a5f3d23e_593e65ba","updated":"2023-12-21 18:44:16.000000000","message":"Changes look good, thanks!","commit_id":"bf054653dfd244379e6e24b270e460275be4d0d6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e0882f2cccb811e616ae4196249fd70c6b8204ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6b8ee693_21fe590e","updated":"2023-12-21 17:44:21.000000000","message":"recheck unrelated oom in tempest-full-py3\n\nwe fully used all swap an only had 20mb avaiabel at the end of the job.\n\ni think its likely time to increate teh base swap to 8G in all jobs","commit_id":"bf054653dfd244379e6e24b270e460275be4d0d6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e765604f60c9a0591bba5796df8f6f32f6617c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b2fddd8f_f6605709","updated":"2023-12-22 13:51:40.000000000","message":"recheck volume snapshot faled on bookwroom","commit_id":"bf054653dfd244379e6e24b270e460275be4d0d6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6a3452a5ad854087296d4c456f2e22c9e66a1148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4a1bd0e1_2877ccd8","in_reply_to":"6b8ee693_21fe590e","updated":"2023-12-21 18:44:16.000000000","message":"I have seen a lot of OOM failures lately too, so +1 to increasing base swap.","commit_id":"bf054653dfd244379e6e24b270e460275be4d0d6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81b6500e7f0495715d64cf5a37ac32e0a13ff6e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a34d95bd_dc183ae8","updated":"2024-01-16 19:55:14.000000000","message":"I think we should at least have this knob to try.","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b25d12566a898e0f0b4374fe51a5429cdbca35af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fe2f480a_6285dc1d","updated":"2024-01-23 09:36:13.000000000","message":"lgtm, thanks!","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce26d3eed8ee8f7dd391caf4e514c8476e245f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"98e6c7dd_b40f0dac","updated":"2024-01-23 18:20:10.000000000","message":"recheck no pip error","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b10367734a0d1d76945449880e90f1e5e0d97505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f158d238_8410c1d7","updated":"2024-01-23 12:48:19.000000000","message":"recheck unrelated failures","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"}],"functions-common":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":246,"context_line":"    xtrace\u003d$(set +o | grep xtrace)"},{"line_number":247,"context_line":"    set +o xtrace"},{"line_number":248,"context_line":"    if [ -z $1 ]; then"},{"line_number":249,"context_line":"        die $LINENO \"Bool value reqired\""},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"    if [[ $1 \u003d\u003d \"True\" ]] ; then"},{"line_number":252,"context_line":"        echo \u00271\u0027"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"a1b92ebc_dd2f5f0c","line":249,"range":{"start_line":249,"start_character":32,"end_line":249,"end_character":39},"updated":"2023-12-07 21:36:52.000000000","message":"required","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    xtrace\u003d$(set +o | grep xtrace)"},{"line_number":247,"context_line":"    set +o xtrace"},{"line_number":248,"context_line":"    if [ -z $1 ]; then"},{"line_number":249,"context_line":"        die $LINENO \"Bool value reqired\""},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"    if [[ $1 \u003d\u003d \"True\" ]] ; then"},{"line_number":252,"context_line":"        echo \u00271\u0027"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"de6ea9db_498a9af6","line":249,"range":{"start_line":249,"start_character":32,"end_line":249,"end_character":39},"in_reply_to":"a1b92ebc_dd2f5f0c","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"}],"lib/host":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97ba3ad80966d10eb03df0c6e1941c784fbf3280","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":16,"context_line":"        install_package \"ksmtuned\""},{"line_number":17,"context_line":"    fi"},{"line_number":18,"context_line":"    local enable_ksm\u003d$(bool_to_int ENABLE_KSM)"},{"line_number":19,"context_line":"    if [[ -f /sys/kernel/mm/ksm/run ]] ; then"},{"line_number":20,"context_line":"        echo ${enable_ksm} | sudo tee /sys/kernel/mm/ksm/run"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"111ca733_3f93aec3","line":18,"updated":"2023-08-08 12:16:20.000000000","message":"i still need to remove this to make bashate happy","commit_id":"2b3fd9e5ab562b5cb177b6c74a004826ec28f741"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5cca741d6908adb7477accf45ae2b52555f20c4e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":16,"context_line":"        install_package \"ksmtuned\""},{"line_number":17,"context_line":"    fi"},{"line_number":18,"context_line":"    local enable_ksm\u003d$(bool_to_int ENABLE_KSM)"},{"line_number":19,"context_line":"    if [[ -f /sys/kernel/mm/ksm/run ]] ; then"},{"line_number":20,"context_line":"        echo ${enable_ksm} | sudo tee /sys/kernel/mm/ksm/run"},{"line_number":21,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ac7a56b_d7d2264a","line":18,"in_reply_to":"111ca733_3f93aec3","updated":"2023-08-09 18:03:57.000000000","message":"Done","commit_id":"2b3fd9e5ab562b5cb177b6c74a004826ec28f741"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"42d3f40a92223ff77bf2c54fe30c613bf2a04512","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        install_package \"ksmtuned\""},{"line_number":17,"context_line":"    fi"},{"line_number":18,"context_line":"    if [[ -f /sys/kernel/mm/ksm/run ]] ; then"},{"line_number":19,"context_line":"        echo $(bool_to_int ENABLE_KSM) | sudo tee /sys/kernel/mm/ksm/run"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"320e38ad_1fd841ee","line":19,"updated":"2023-10-19 19:41:06.000000000","message":"We might need to be robust in our handling of if these are missing, although I guess maybe that\u0027s a good reason to fail - if you asked for it on and we can\u0027t. But then perhaps the default-on things should probe for availability.","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"540c570d7aea0e67dabf29bffff9c08f85259a7b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        install_package \"ksmtuned\""},{"line_number":17,"context_line":"    fi"},{"line_number":18,"context_line":"    if [[ -f /sys/kernel/mm/ksm/run ]] ; then"},{"line_number":19,"context_line":"        echo $(bool_to_int ENABLE_KSM) | sudo tee /sys/kernel/mm/ksm/run"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9e84015c_bee916da","line":19,"in_reply_to":"320e38ad_1fd841ee","updated":"2023-11-08 12:58:44.000000000","message":"Ack, i wanted to enabel it by default but not fail on a host that does not supprot it but i think failing if you request it is also valid.","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"42d3f40a92223ff77bf2c54fe30c613bf2a04512","unresolved":true,"context_lines":[{"line_number":26,"context_line":"# as noted in the kernel docs https://docs.kernel.org/admin-guide/mm/zswap.html"},{"line_number":27,"context_line":"# Zswap is a lightweight compressed cache for swap pages."},{"line_number":28,"context_line":"# It takes pages that are in the process of being swapped out and attempts"},{"line_number":29,"context_line":"#to compress them into a dynamically allocated RAM-based memory pool."},{"line_number":30,"context_line":"# zswap basically trades CPU cycles for potentially reduced swap I/O."},{"line_number":31,"context_line":"# This trade-off can also result in a significant performance improvement"},{"line_number":32,"context_line":"# if reads from the compressed cache are faster than reads from a swap device."}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bc3d2de8_2fec4b2b","line":29,"range":{"start_line":29,"start_character":1,"end_line":29,"end_character":3},"updated":"2023-10-19 19:41:06.000000000","message":"need a leading space here","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"540c570d7aea0e67dabf29bffff9c08f85259a7b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# as noted in the kernel docs https://docs.kernel.org/admin-guide/mm/zswap.html"},{"line_number":27,"context_line":"# Zswap is a lightweight compressed cache for swap pages."},{"line_number":28,"context_line":"# It takes pages that are in the process of being swapped out and attempts"},{"line_number":29,"context_line":"#to compress them into a dynamically allocated RAM-based memory pool."},{"line_number":30,"context_line":"# zswap basically trades CPU cycles for potentially reduced swap I/O."},{"line_number":31,"context_line":"# This trade-off can also result in a significant performance improvement"},{"line_number":32,"context_line":"# if reads from the compressed cache are faster than reads from a swap device."}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"8841a4d7_7a7aa062","line":29,"range":{"start_line":29,"start_character":1,"end_line":29,"end_character":3},"in_reply_to":"bc3d2de8_2fec4b2b","updated":"2023-11-08 12:58:44.000000000","message":"Done","commit_id":"1b83637eff97d6be0f86df57882c0a0cfbd78dd7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"ENABLE_ZSWAP\u003d$(trueorfalse False ENABLE_ZSWAP)"},{"line_number":35,"context_line":"# lz4 is very fast although it does not have the best compression"},{"line_number":36,"context_line":"# zstd has much better compresssion but more latency"},{"line_number":37,"context_line":"ZSWAP_COMPRESSOR\u003d${ZSWAP_COMPRESSOR:\u003d\"lz4\"}"},{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"c7a52aa5_827b4258","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":35},"updated":"2023-12-07 21:36:52.000000000","message":"compression","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"ENABLE_ZSWAP\u003d$(trueorfalse False ENABLE_ZSWAP)"},{"line_number":35,"context_line":"# lz4 is very fast although it does not have the best compression"},{"line_number":36,"context_line":"# zstd has much better compresssion but more latency"},{"line_number":37,"context_line":"ZSWAP_COMPRESSOR\u003d${ZSWAP_COMPRESSOR:\u003d\"lz4\"}"},{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"74115172_0f63a686","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":35},"in_reply_to":"c7a52aa5_827b4258","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"dece7f97_fe3f2d93","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":31},"updated":"2023-12-07 21:36:52.000000000","message":"seems","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"8992b477_b97f44c5","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":46},"updated":"2023-12-07 21:36:52.000000000","message":"support","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"b74b7666_de46b1ca","line":41,"range":{"start_line":41,"start_character":73,"end_line":41,"end_character":80},"updated":"2023-12-07 21:36:52.000000000","message":"tuning","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"a71305f7_9294f55c","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":46},"in_reply_to":"8992b477_b97f44c5","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"434d6b7d_524cbe60","line":41,"range":{"start_line":41,"start_character":73,"end_line":41,"end_character":80},"in_reply_to":"b74b7666_de46b1ca","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"ZSWAP_ZPOOL\u003d${ZSWAP_ZPOOL:\u003d\"z3fold\"}"},{"line_number":39,"context_line":"function configure_zswap {"},{"line_number":40,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":41,"context_line":"        # Centos 9 stream seams to only suport enabling but not run time truning"},{"line_number":42,"context_line":"        # so dont try to choose better default on centos"},{"line_number":43,"context_line":"        if is_ubuntu; then"},{"line_number":44,"context_line":"            echo ${ZSWAP_COMPRESSOR} | sudo tee /sys/module/zswap/parameters/compressor"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"86548eb5_11bbb79a","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":31},"in_reply_to":"dece7f97_fe3f2d93","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            echo ${ZSWAP_ZPOOL} | sudo tee /sys/module/zswap/parameters/zpool"},{"line_number":46,"context_line":"        fi"},{"line_number":47,"context_line":"        echo 1 | sudo tee /sys/module/zswap/parameters/enabled"},{"line_number":48,"context_line":"        # print curent zram kernel config"},{"line_number":49,"context_line":"        sudo grep -R . /sys/module/zswap/parameters || /bin/true"},{"line_number":50,"context_line":"    fi"},{"line_number":51,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"2a2c8e78_ac41bb78","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":27},"updated":"2023-12-07 21:36:52.000000000","message":"zswap?","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            echo ${ZSWAP_ZPOOL} | sudo tee /sys/module/zswap/parameters/zpool"},{"line_number":46,"context_line":"        fi"},{"line_number":47,"context_line":"        echo 1 | sudo tee /sys/module/zswap/parameters/enabled"},{"line_number":48,"context_line":"        # print curent zram kernel config"},{"line_number":49,"context_line":"        sudo grep -R . /sys/module/zswap/parameters || /bin/true"},{"line_number":50,"context_line":"    fi"},{"line_number":51,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"c745bcef_1e5b3188","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":27},"in_reply_to":"2a2c8e78_ac41bb78","updated":"2023-12-21 12:37:57.000000000","message":"yep zram is a diffent thing thanks","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":53,"context_line":"ENABLE_SYSCTL_MEM_TUNING\u003d$(trueorfalse False ENABLE_SYSCTL_MEM_TUNING)"},{"line_number":54,"context_line":"function configure_sysctl_mem_parmaters {"},{"line_number":55,"context_line":"    if [[ $ENABLE_SYSCTL_MEM_TUNING \u003d\u003d \"True\" ]] ; then"},{"line_number":56,"context_line":"        # defer write when memory is avaiable"},{"line_number":57,"context_line":"        sudo sysctl -w vm.dirty_ratio\u003d60"},{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"792e0cd8_52616774","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":45},"updated":"2023-12-07 21:36:52.000000000","message":"available","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"ENABLE_SYSCTL_MEM_TUNING\u003d$(trueorfalse False ENABLE_SYSCTL_MEM_TUNING)"},{"line_number":54,"context_line":"function configure_sysctl_mem_parmaters {"},{"line_number":55,"context_line":"    if [[ $ENABLE_SYSCTL_MEM_TUNING \u003d\u003d \"True\" ]] ; then"},{"line_number":56,"context_line":"        # defer write when memory is avaiable"},{"line_number":57,"context_line":"        sudo sysctl -w vm.dirty_ratio\u003d60"},{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"733212b5_7fd28942","line":56,"range":{"start_line":56,"start_character":37,"end_line":56,"end_character":45},"in_reply_to":"792e0cd8_52616774","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        sudo sysctl -w vm.dirty_ratio\u003d60"},{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"},{"line_number":60,"context_line":"        # assume swap is compressed so on new kerenls"},{"line_number":61,"context_line":"        # give it equal priorot as page cache which is"},{"line_number":62,"context_line":"        # uncompressed. on kernels \u003c 5.8 the max is 100"},{"line_number":63,"context_line":"        # not 200 so it will strongly prefer swapping."}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ff34c4ad_c1149339","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":53},"updated":"2023-12-07 21:36:52.000000000","message":"kernels","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        sudo sysctl -w vm.dirty_ratio\u003d60"},{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"},{"line_number":60,"context_line":"        # assume swap is compressed so on new kerenls"},{"line_number":61,"context_line":"        # give it equal priorot as page cache which is"},{"line_number":62,"context_line":"        # uncompressed. on kernels \u003c 5.8 the max is 100"},{"line_number":63,"context_line":"        # not 200 so it will strongly prefer swapping."}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"505b7948_bbe45730","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":53},"in_reply_to":"ff34c4ad_c1149339","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"},{"line_number":60,"context_line":"        # assume swap is compressed so on new kerenls"},{"line_number":61,"context_line":"        # give it equal priorot as page cache which is"},{"line_number":62,"context_line":"        # uncompressed. on kernels \u003c 5.8 the max is 100"},{"line_number":63,"context_line":"        # not 200 so it will strongly prefer swapping."},{"line_number":64,"context_line":"        sudo sysctl -w vm.swappiness\u003d100"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"dc1ca41d_8abeb1cd","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":31},"updated":"2023-12-07 21:36:52.000000000","message":"priority","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        sudo sysctl -w vm.dirty_background_ratio\u003d10"},{"line_number":59,"context_line":"        sudo sysctl -w vm.vfs_cache_pressure\u003d50"},{"line_number":60,"context_line":"        # assume swap is compressed so on new kerenls"},{"line_number":61,"context_line":"        # give it equal priorot as page cache which is"},{"line_number":62,"context_line":"        # uncompressed. on kernels \u003c 5.8 the max is 100"},{"line_number":63,"context_line":"        # not 200 so it will strongly prefer swapping."},{"line_number":64,"context_line":"        sudo sysctl -w vm.swappiness\u003d100"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"32f7c932_ab3d3ffa","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":31},"in_reply_to":"dc1ca41d_8abeb1cd","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":75,"context_line":"ENABLE_SYSCTL_NET_TUNING\u003d$(trueorfalse False ENABLE_SYSCTL_NET_TUNING)"},{"line_number":76,"context_line":"function configure_sysctl_net_parmaters {"},{"line_number":77,"context_line":"    if [[ $ENABLE_SYSCTL_NET_TUNING \u003d\u003d \"True\" ]] ; then"},{"line_number":78,"context_line":"        #detect dead TCP connections after 120 seconds"},{"line_number":79,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_time\u003d60"},{"line_number":80,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_intvl\u003d10"},{"line_number":81,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_probes\u003d6"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"5bd0b140_5fad255e","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":15},"updated":"2023-12-07 21:36:52.000000000","message":"space between # and detect","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ENABLE_SYSCTL_NET_TUNING\u003d$(trueorfalse False ENABLE_SYSCTL_NET_TUNING)"},{"line_number":76,"context_line":"function configure_sysctl_net_parmaters {"},{"line_number":77,"context_line":"    if [[ $ENABLE_SYSCTL_NET_TUNING \u003d\u003d \"True\" ]] ; then"},{"line_number":78,"context_line":"        #detect dead TCP connections after 120 seconds"},{"line_number":79,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_time\u003d60"},{"line_number":80,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_intvl\u003d10"},{"line_number":81,"context_line":"        sudo sysctl -w net.ipv4.tcp_keepalive_probes\u003d6"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"d10e760e_c95b9a16","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":15},"in_reply_to":"5bd0b140_5fad255e","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d3ffa22e1e5587cbb50db3a2089c9f508e65e8c5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# be memory bound not cpu bound so enable KSM by default but allow people"},{"line_number":11,"context_line":"# to opt out if the CPU time is more important to them."},{"line_number":12,"context_line":"ENABLE_KSM\u003d$(trueorfalse True ENABLE_KSM)"},{"line_number":13,"context_line":"ENABLE_KSMTUNED\u003d$(trueorfalse True ENABLE_KSMTUNED)"},{"line_number":14,"context_line":"function configure_ksm {"},{"line_number":15,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":16,"context_line":"        install_package \"ksmtuned\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"f28ba0d5_8cba2e53","line":13,"updated":"2024-01-16 19:54:03.000000000","message":"Don\u0027t these keep the defaults on?","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81b6500e7f0495715d64cf5a37ac32e0a13ff6e3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# be memory bound not cpu bound so enable KSM by default but allow people"},{"line_number":11,"context_line":"# to opt out if the CPU time is more important to them."},{"line_number":12,"context_line":"ENABLE_KSM\u003d$(trueorfalse True ENABLE_KSM)"},{"line_number":13,"context_line":"ENABLE_KSMTUNED\u003d$(trueorfalse True ENABLE_KSMTUNED)"},{"line_number":14,"context_line":"function configure_ksm {"},{"line_number":15,"context_line":"    if [[ $ENABLE_KSMTUNED \u003d\u003d \"True\" ]] ; then"},{"line_number":16,"context_line":"        install_package \"ksmtuned\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"8e947bca_1499f117","line":13,"in_reply_to":"f28ba0d5_8cba2e53","updated":"2024-01-16 19:55:14.000000000","message":"No, nevermind, KSM was on by default before, the zswap default is below, not here, and disabled by default.","commit_id":"224fe1b09adb3adcdd02d680a46eeed5b271f7e4"}],"stack.sh":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":607,"context_line":"source $TOP_DIR/lib/database"},{"line_number":608,"context_line":"source $TOP_DIR/lib/rpc_backend"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"# load host turning functions and defaults"},{"line_number":611,"context_line":"source $TOP_DIR/lib/host"},{"line_number":612,"context_line":"# tune host memeory early to ensure zswap/ksm are configured before"},{"line_number":613,"context_line":"# doing memory intentisve operation liek cloning replos or unpacking packages."}],"source_content_type":"text/x-sh","patch_set":10,"id":"5a29fa0c_31ed6da4","line":610,"range":{"start_line":610,"start_character":12,"end_line":610,"end_character":19},"updated":"2023-12-07 21:36:52.000000000","message":"tuning","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"# load host turning functions and defaults"},{"line_number":611,"context_line":"source $TOP_DIR/lib/host"},{"line_number":612,"context_line":"# tune host memeory early to ensure zswap/ksm are configured before"},{"line_number":613,"context_line":"# doing memory intentisve operation liek cloning replos or unpacking packages."},{"line_number":614,"context_line":"tune_host"},{"line_number":615,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"b6f895f8_7dace590","line":612,"range":{"start_line":612,"start_character":12,"end_line":612,"end_character":19},"updated":"2023-12-07 21:36:52.000000000","message":"memory","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":610,"context_line":"# load host turning functions and defaults"},{"line_number":611,"context_line":"source $TOP_DIR/lib/host"},{"line_number":612,"context_line":"# tune host memeory early to ensure zswap/ksm are configured before"},{"line_number":613,"context_line":"# doing memory intentisve operation liek cloning replos or unpacking packages."},{"line_number":614,"context_line":"tune_host"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"# Configure Projects"}],"source_content_type":"text/x-sh","patch_set":10,"id":"cc846b3a_a9e5778b","line":613,"range":{"start_line":613,"start_character":15,"end_line":613,"end_character":25},"updated":"2023-12-07 21:36:52.000000000","message":"intensive","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":610,"context_line":"# load host turning functions and defaults"},{"line_number":611,"context_line":"source $TOP_DIR/lib/host"},{"line_number":612,"context_line":"# tune host memeory early to ensure zswap/ksm are configured before"},{"line_number":613,"context_line":"# doing memory intentisve operation liek cloning replos or unpacking packages."},{"line_number":614,"context_line":"tune_host"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"# Configure Projects"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dcd8781d_b0152141","line":613,"range":{"start_line":613,"start_character":36,"end_line":613,"end_character":40},"updated":"2023-12-07 21:36:52.000000000","message":"like","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"99085d7acbc2a3bbada300a5ecef86fae3905fb2","unresolved":true,"context_lines":[{"line_number":610,"context_line":"# load host turning functions and defaults"},{"line_number":611,"context_line":"source $TOP_DIR/lib/host"},{"line_number":612,"context_line":"# tune host memeory early to ensure zswap/ksm are configured before"},{"line_number":613,"context_line":"# doing memory intentisve operation liek cloning replos or unpacking packages."},{"line_number":614,"context_line":"tune_host"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"# Configure Projects"}],"source_content_type":"text/x-sh","patch_set":10,"id":"cb7d9d17_afcefae6","line":613,"range":{"start_line":613,"start_character":49,"end_line":613,"end_character":55},"updated":"2023-12-07 21:36:52.000000000","message":"repos","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"# Configure Projects"},{"line_number":617,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"# Clone all external plugins"},{"line_number":620,"context_line":"fetch_plugins"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"36bb3b90_7f45876c","line":618,"range":{"start_line":618,"start_character":12,"end_line":618,"end_character":19},"in_reply_to":"5a29fa0c_31ed6da4","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":617,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"# Clone all external plugins"},{"line_number":620,"context_line":"fetch_plugins"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Plugin Phase 0: override_defaults - allow plugins to override"},{"line_number":623,"context_line":"# defaults before other services are run"}],"source_content_type":"text/x-sh","patch_set":10,"id":"8bfe6ce8_5289950f","line":620,"range":{"start_line":620,"start_character":12,"end_line":620,"end_character":19},"in_reply_to":"b6f895f8_7dace590","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":"# Clone all external plugins"},{"line_number":620,"context_line":"fetch_plugins"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Plugin Phase 0: override_defaults - allow plugins to override"},{"line_number":623,"context_line":"# defaults before other services are run"},{"line_number":624,"context_line":"run_phase override_defaults"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1824ea21_b6def779","line":621,"range":{"start_line":621,"start_character":49,"end_line":621,"end_character":55},"in_reply_to":"cb7d9d17_afcefae6","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":"# Clone all external plugins"},{"line_number":620,"context_line":"fetch_plugins"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Plugin Phase 0: override_defaults - allow plugins to override"},{"line_number":623,"context_line":"# defaults before other services are run"},{"line_number":624,"context_line":"run_phase override_defaults"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dcd838c6_cea2eaae","line":621,"range":{"start_line":621,"start_character":15,"end_line":621,"end_character":25},"in_reply_to":"cc846b3a_a9e5778b","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d8e8cac6643dd63673f4382188482c341c82dfd","unresolved":false,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":"# Clone all external plugins"},{"line_number":620,"context_line":"fetch_plugins"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# Plugin Phase 0: override_defaults - allow plugins to override"},{"line_number":623,"context_line":"# defaults before other services are run"},{"line_number":624,"context_line":"run_phase override_defaults"}],"source_content_type":"text/x-sh","patch_set":10,"id":"e0d9150a_a8c3ccb9","line":621,"range":{"start_line":621,"start_character":36,"end_line":621,"end_character":40},"in_reply_to":"dcd8781d_b0152141","updated":"2023-12-21 12:37:57.000000000","message":"Done","commit_id":"1c4eb349a5d4fa79ccce600594d7a2c81a75bae7"}],"stackrc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e79ca3d38f8348a36a2c5a1e096a819cdfba79e2","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# load host memroy turning functions and defaults"},{"line_number":126,"context_line":"source lib/host"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Passwords generated by interactive devstack runs"},{"line_number":129,"context_line":"if [[ -r $RC_DIR/.localrc.password ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"30879409_a6e286d9","line":126,"updated":"2023-08-08 15:42:40.000000000","message":"this is causing grenade to fail when it sources the file.\ni need to move this to stack.sh","commit_id":"e71d7883f5867c47f03932797cd4a2ec932081d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5cca741d6908adb7477accf45ae2b52555f20c4e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# load host memroy turning functions and defaults"},{"line_number":126,"context_line":"source lib/host"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Passwords generated by interactive devstack runs"},{"line_number":129,"context_line":"if [[ -r $RC_DIR/.localrc.password ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"53714a7c_526c1022","line":126,"in_reply_to":"30879409_a6e286d9","updated":"2023-08-09 18:03:57.000000000","message":"Done","commit_id":"e71d7883f5867c47f03932797cd4a2ec932081d0"}]}