)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"df420585785d31e20cd1c3edb64a198de116bf93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"129da779_1ed5c542","updated":"2023-08-14 14:15:53.000000000","message":"This needs a nova change to work","commit_id":"4bd72764d56af85b3ff3e1121c915b5a757a5509"}],"lib/nova":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8881f413b74276d2ff8460be6540f635523ce8c7","unresolved":true,"context_lines":[{"line_number":995,"context_line":"            start_tls_proxy nova \u0027*\u0027 $NOVA_SERVICE_PORT $NOVA_SERVICE_HOST $NOVA_SERVICE_PORT_INT"},{"line_number":996,"context_line":"        fi"},{"line_number":997,"context_line":"    else"},{"line_number":998,"context_line":"        run_process \"n-api\" \"$(which uwsgi) --procname-prefix nova-api --ini $NOVA_UWSGI_CONF\""},{"line_number":999,"context_line":"        local unitfile\u003d\"$SYSTEMD_DIR/devstack@n-api.service\""},{"line_number":1000,"context_line":"        iniadd -sudo \"$unitfile\" Service Environment \"OS_NOVA_DISABLE_EVENTLET_PATCHING\u003dtrue\""},{"line_number":1001,"context_line":"        sudo systemctl daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"55b5e9f3_0944df8f","line":998,"updated":"2023-08-14 14:00:23.000000000","message":"you didnt move this to where you have \"sudo systemctl restart devstack@n-api\"\npresumably because the unit file is created as a side effect of run_process?\n\notherwise i woudl just suggest reordering to avoid the restart.","commit_id":"4bd72764d56af85b3ff3e1121c915b5a757a5509"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"df420585785d31e20cd1c3edb64a198de116bf93","unresolved":true,"context_lines":[{"line_number":995,"context_line":"            start_tls_proxy nova \u0027*\u0027 $NOVA_SERVICE_PORT $NOVA_SERVICE_HOST $NOVA_SERVICE_PORT_INT"},{"line_number":996,"context_line":"        fi"},{"line_number":997,"context_line":"    else"},{"line_number":998,"context_line":"        run_process \"n-api\" \"$(which uwsgi) --procname-prefix nova-api --ini $NOVA_UWSGI_CONF\""},{"line_number":999,"context_line":"        local unitfile\u003d\"$SYSTEMD_DIR/devstack@n-api.service\""},{"line_number":1000,"context_line":"        iniadd -sudo \"$unitfile\" Service Environment \"OS_NOVA_DISABLE_EVENTLET_PATCHING\u003dtrue\""},{"line_number":1001,"context_line":"        sudo systemctl daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3cc3d135_ead1dd61","line":998,"in_reply_to":"55b5e9f3_0944df8f","updated":"2023-08-14 14:15:53.000000000","message":"Yeah, I\u0027d need to refactor run_process to take some environment statements or something like that. Since this is a pretty nova-specific case I just kinda hacked it in here. It\u0027s not very expensive and we can do something better if there\u0027s a need/desire.","commit_id":"4bd72764d56af85b3ff3e1121c915b5a757a5509"}]}