)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6b90c57d5ff8c622b01f296471ec4300e843efc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b02cda8_47708823","updated":"2023-08-22 18:58:02.000000000","message":"You should also drop the overrides from the matching platform jobs","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2035f111728379f03e4ee0c5ce84fb56e67a38a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c40922a_99ae0769","in_reply_to":"9b02cda8_47708823","updated":"2023-08-22 19:25:31.000000000","message":"good point! i forgot about that","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"024f94b68cb1b4753454c26f16d9714069eeb369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56e31857_4f24d190","updated":"2023-08-23 06:07:30.000000000","message":"Also looking at rocky failure seems it would need more changes to make it work https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b83/892395/2/check/devstack-platform-rocky-blue-onyx/b8336d7/job-output.txt","commit_id":"1e4291a646550b1d7e07e624cb62fa3d0e8435b6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43d131fd7866c468297a2ddec1a160fd058572d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c413ad34_4029a043","in_reply_to":"56e31857_4f24d190","updated":"2023-08-23 10:20:08.000000000","message":"right, this is set before fixup_stuff is executed and that results in the failure:\nhttps://opendev.org/openstack/devstack/src/commit/21eac99e4e342108d7905f64c3e5474b70c9273f/lib/glance#L51\n\nRight, first we set the projects, glance specifically on line 638:\nhttps://opendev.org/openstack/devstack/src/commit/21eac99e4e342108d7905f64c3e5474b70c9273f/stack.sh#L638\n\nand then fixup things on line 825:\nhttps://opendev.org/openstack/devstack/src/commit/21eac99e4e342108d7905f64c3e5474b70c9273f/stack.sh#L825","commit_id":"1e4291a646550b1d7e07e624cb62fa3d0e8435b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fe3383dd247a74127ab89cad8cdc00d828933ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6abfda04_96cf841d","in_reply_to":"c413ad34_4029a043","updated":"2023-08-23 10:32:50.000000000","message":"Thanks latest PS looks good.","commit_id":"1e4291a646550b1d7e07e624cb62fa3d0e8435b6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c9d03a3a07c5bebb14cf2e2c2c5066d6e5027a1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"042b3a7b_4e54c028","updated":"2023-08-23 15:18:18.000000000","message":"Commented, but can be amended in a follow-up, too.","commit_id":"2733458dc1c0e78d5be889427e53b4cea65ce441"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e62bce03d5e7a071b65432aa7aca1d51ceefdce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4558db0_55bd8e9a","updated":"2023-08-23 17:40:08.000000000","message":"ok with the idea.","commit_id":"7cd3a8eebe1830f94c02bb6ec010c0365f6ab6f1"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c9d03a3a07c5bebb14cf2e2c2c5066d6e5027a1e","unresolved":true,"context_lines":[{"line_number":196,"context_line":"# This couldn\u0027t go to fixup_stuff as that\u0027s called after projects (e.g. certain paths)"},{"line_number":197,"context_line":"# are set taking GLOBAL_VENV into account"},{"line_number":198,"context_line":"if [[ \"$os_VENDOR\" \u003d~ (CentOSStream|Rocky) ]]; then"},{"line_number":199,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":200,"context_line":"fi"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# Enable use of Python virtual environments.  Individual project use of"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"077ff30c_649d59e3","line":199,"updated":"2023-08-23 15:18:18.000000000","message":"This will make overriding for testing potential fixes impossible.\n\nBetter use\n\nGLOBAL_VENV\u003d$(trueorfalse False GLOBAL_VENV)\n\nand move L191 above into an \"else\" after this.","commit_id":"2733458dc1c0e78d5be889427e53b4cea65ce441"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ca53317b4605013f994ef1d295f3f0e3e8700b78","unresolved":true,"context_lines":[{"line_number":196,"context_line":"# This couldn\u0027t go to fixup_stuff as that\u0027s called after projects (e.g. certain paths)"},{"line_number":197,"context_line":"# are set taking GLOBAL_VENV into account"},{"line_number":198,"context_line":"if [[ \"$os_VENDOR\" \u003d~ (CentOSStream|Rocky) ]]; then"},{"line_number":199,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":200,"context_line":"fi"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# Enable use of Python virtual environments.  Individual project use of"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bef09031_578eff55","line":199,"in_reply_to":"077ff30c_649d59e3","updated":"2023-08-23 15:40:53.000000000","message":"that\u0027s smart, let\u0027s do that, thanks!","commit_id":"2733458dc1c0e78d5be889427e53b4cea65ce441"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dc9f979dc34aeb09243d2a2d977165810d9cf170","unresolved":false,"context_lines":[{"line_number":196,"context_line":"# This couldn\u0027t go to fixup_stuff as that\u0027s called after projects (e.g. certain paths)"},{"line_number":197,"context_line":"# are set taking GLOBAL_VENV into account"},{"line_number":198,"context_line":"if [[ \"$os_VENDOR\" \u003d~ (CentOSStream|Rocky) ]]; then"},{"line_number":199,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":200,"context_line":"fi"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# Enable use of Python virtual environments.  Individual project use of"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"34bd68c5_7d1f394b","line":199,"in_reply_to":"bef09031_578eff55","updated":"2023-08-23 15:58:13.000000000","message":"Done","commit_id":"2733458dc1c0e78d5be889427e53b4cea65ce441"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6b90c57d5ff8c622b01f296471ec4300e843efc6","unresolved":true,"context_lines":[{"line_number":107,"context_line":"function fixup_centos_stream {"},{"line_number":108,"context_line":"    # remove once this is fixed"},{"line_number":109,"context_line":"    # https://bugs.launchpad.net/devstack/+bug/2031639"},{"line_number":110,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function fixup_rocky {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8520b3c9_b4f91ce4","line":110,"updated":"2023-08-22 18:58:02.000000000","message":"This will do the override unconditionally","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43d131fd7866c468297a2ddec1a160fd058572d6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"function fixup_centos_stream {"},{"line_number":108,"context_line":"    # remove once this is fixed"},{"line_number":109,"context_line":"    # https://bugs.launchpad.net/devstack/+bug/2031639"},{"line_number":110,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function fixup_rocky {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9eb5c1b3_f4ac1204","line":110,"in_reply_to":"754a0fb5_38631e2d","updated":"2023-08-23 10:20:08.000000000","message":"Done","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2035f111728379f03e4ee0c5ce84fb56e67a38a4","unresolved":true,"context_lines":[{"line_number":107,"context_line":"function fixup_centos_stream {"},{"line_number":108,"context_line":"    # remove once this is fixed"},{"line_number":109,"context_line":"    # https://bugs.launchpad.net/devstack/+bug/2031639"},{"line_number":110,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function fixup_rocky {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"754a0fb5_38631e2d","line":110,"in_reply_to":"8520b3c9_b4f91ce4","updated":"2023-08-22 19:25:31.000000000","message":"aah, I forgot the if statement","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6b90c57d5ff8c622b01f296471ec4300e843efc6","unresolved":true,"context_lines":[{"line_number":113,"context_line":"function fixup_rocky {"},{"line_number":114,"context_line":"    # remove once this is fixed"},{"line_number":115,"context_line":"    # https://bugs.launchpad.net/devstack/+bug/2031639"},{"line_number":116,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"function fixup_ubuntu {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"cf1258cd_4acc5b89","line":116,"updated":"2023-08-22 18:58:02.000000000","message":"twice","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43d131fd7866c468297a2ddec1a160fd058572d6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"function fixup_rocky {"},{"line_number":114,"context_line":"    # remove once this is fixed"},{"line_number":115,"context_line":"    # https://bugs.launchpad.net/devstack/+bug/2031639"},{"line_number":116,"context_line":"    GLOBAL_VENV\u003dFalse"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"function fixup_ubuntu {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f0b7fcae_6e2bd7df","line":116,"in_reply_to":"cf1258cd_4acc5b89","updated":"2023-08-23 10:20:08.000000000","message":"Done","commit_id":"783f45cd4c9adf45bcc819a01520bae8bd1ee351"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"4400d4ecaa20a5ad0ace5aa312b905118aecb559","unresolved":true,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"function fixup_centos_stream {"},{"line_number":108,"context_line":"    if [[ $os_VENDOR !\u003d \"CentOS\" ]]; then"},{"line_number":109,"context_line":"        return"},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":"    # remove once this is fixed"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ebc5551d_29059a99","line":108,"range":{"start_line":108,"start_character":25,"end_line":108,"end_character":31},"updated":"2023-08-23 06:00:59.000000000","message":"should be CentOSStream","commit_id":"1e4291a646550b1d7e07e624cb62fa3d0e8435b6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"43d131fd7866c468297a2ddec1a160fd058572d6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"function fixup_centos_stream {"},{"line_number":108,"context_line":"    if [[ $os_VENDOR !\u003d \"CentOS\" ]]; then"},{"line_number":109,"context_line":"        return"},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":"    # remove once this is fixed"}],"source_content_type":"text/x-sh","patch_set":2,"id":"23739bd7_8d44287c","line":108,"range":{"start_line":108,"start_character":25,"end_line":108,"end_character":31},"in_reply_to":"ebc5551d_29059a99","updated":"2023-08-23 10:20:08.000000000","message":"Done","commit_id":"1e4291a646550b1d7e07e624cb62fa3d0e8435b6"}]}
