)]}'
{"id":"openstack%2Fdevstack~900368","triplet_id":"openstack%2Fdevstack~master~I89d935f56c264e693b6422dbefc084f03d56449f","project":"openstack/devstack","branch":"master","topic":"vnc-config","hashtags":[],"change_id":"I89d935f56c264e693b6422dbefc084f03d56449f","subject":"Use only is_service_enabled n-novnc for console proxy config","status":"NEW","created":"2023-11-07 20:10:02.000000000","updated":"2023-11-07 22:33:43.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"52c8c3f924c26ac660f925eafac6f0daa8e4b489","_number":900368,"virtual_id_number":900368,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-11-07 22:33:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-07 22:33:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"681b9e3d958f0c4d2b69f3817cada449820cdb64","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-11-07 20:10:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"52c8c3f924c26ac660f925eafac6f0daa8e4b489","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-07 22:33:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1edb5502ae374615aa443d627603c704\n\n- grenade https://zuul.opendev.org/t/openstack/build/d9632ae3de61429cb080371678827632 : SUCCESS in 46m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/16fa5449fc904aa2b1fc7b9c719f863f : SUCCESS in 1h 08m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9cc661beff13492f821b65b3b2928c4a : SUCCESS in 4m 53s\n- devstack https://zuul.opendev.org/t/openstack/build/9d733a7b7c944351957c168536e625f1 : SUCCESS in 18m 04s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/93fb1a39c0984ef8801ec18f6ee962a8 : SUCCESS in 18m 08s\n- devstack-enforce-scope https://zuul.opendev.org/t/openstack/build/cbc279999d6841f38eedee58d0ea93ad : SUCCESS in 18m 06s\n- devstack-platform-centos-9-stream https://zuul.opendev.org/t/openstack/build/a66927cc2af6459d9f889fa755d5776f : SUCCESS in 1h 17m 55s (non-voting)\n- devstack-platform-debian-bookworm https://zuul.opendev.org/t/openstack/build/a9f7d9a3ae2947619b1e37f52381d0a4 : SUCCESS in 1h 16m 54s\n- devstack-platform-debian-bullseye https://zuul.opendev.org/t/openstack/build/6ce404417eb4488f873918002a5489e1 : SUCCESS in 1h 24m 26s\n- devstack-platform-rocky-blue-onyx https://zuul.opendev.org/t/openstack/build/7314c31b69014d68aab55bd70bc68071 : SUCCESS in 1h 28m 49s\n- devstack-platform-ubuntu-jammy-ovs https://zuul.opendev.org/t/openstack/build/e981173ea819446289806a0ebd2d6339 : SUCCESS in 1h 16m 57s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/352074af287f4edda385ca6b75c65d76 : SUCCESS in 48m 49s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/3f8feacdcd9243008378aa21bc612dad : SUCCESS in 2m 57s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/e688201bc0254657ba3c1715f25589bd : SUCCESS in 3m 05s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/d0d5c235ad894137919b08ec5f9a478c : SUCCESS in 1h 12m 40s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/c6600fe4aee34ee3a88bee5a24e515d9 : SUCCESS in 49m 53s\n- neutron-ovs-grenade-multinode https://zuul.opendev.org/t/openstack/build/bd3ae4bbb2fc44a5b549ffce81c42bfa : SUCCESS in 48m 01s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/a4750d6290814b21be0ab280b7d009f6 : SUCCESS in 1h 11m 52s (non-voting)\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/a357f09fdcbc4e53800519674eb18630 : SUCCESS in 1h 04m 44s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/fa58d9dfa53e4ab3a8cd317701823fad : SUCCESS in 1h 07m 25s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/840d3681f9db4e1aac092fcbae04f274 : SUCCESS in 51m 43s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/8c45743782dc4b9aa84e6aa8daf12b38 : SUCCESS in 2h 17m 09s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7c16d82767a6ee71f1832cb9d5e022fe5ff0965f","revisions":{"7c16d82767a6ee71f1832cb9d5e022fe5ff0965f":{"kind":"REWORK","_number":1,"created":"2023-11-07 20:10:02.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/68/900368/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/68/900368/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/900368/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/900368/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/68/900368/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/68/900368/1"}}},"commit":{"parents":[{"commit":"3ffcc89d5dda1290c0a3ad6462dd41edb1dc35b7","subject":"Merge \"Enable keystone token caching by OSC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3ffcc89d5dda1290c0a3ad6462dd41edb1dc35b7"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-11-07 19:33:50.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-11-07 20:09:08.000000000","tz":0},"subject":"Use only is_service_enabled n-novnc for console proxy config","message":"Use only is_service_enabled n-novnc for console proxy config\n\nLong ago, the configuration of VNC was not separated between the\ncontroller node vs a compute node, so config for both was included on\nevery node of a multinode configured job despite the fact that the\nnodes could be running (or not running) different services. The\nNOVA_VNC_ENABLED environment variable is available as a way to indicate\nthat VNC should be configured on a compute node that is not running a\nn-novnc service.\n\nLater on, we separated the configs between controller vs compute node\nto enhance clarity and understanding. Since then, we know that the\nconfigure_console_proxies function configures only the proxy, not the\ncompute node -- so we don\u0027t actually need to consider NOVA_VNC_ENABLED\nbecause the proxy will always have the n-novnc service enabled.\n\nCurrently, because we do consider NOVA_VNC_ENABLED when configuring a\nconsole proxy, the nova.conf or nova_cellN.conf  (not the\nnova-cpu.conf) on the subnode of a multinode job that is not running\nn-novnc will end up containing console proxy settings. This is not\nharmful but it could cause confusion for those debugging and looking\nthrough logs and configs.\n\nThis removes consideration of NOVA_VNC_ENABLED when configuring a\nconsole proxy to tidy things up a bit and reduce potential confusion.\n\nChange-Id: I89d935f56c264e693b6422dbefc084f03d56449f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7c16d82767a6ee71f1832cb9d5e022fe5ff0965f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7c16d82767a6ee71f1832cb9d5e022fe5ff0965f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}