)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ab908e64e5e511e549c77ee0a85caa16f9d132b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9cbbf503_1aa49341","updated":"2023-12-11 13:51:53.000000000","message":"Also for reference it\u0027s handling the related issue in as expected https://zuul.openstack.org/build/2c0cd12e3b2f4357b8a32d8ba46ccbda/log/job-output.txt#22375-22406","commit_id":"6b0f055b4ed407f8a190f768d0e654235ac015dd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d4a9d9d27d2655d3825ea8a98d2601de10fb0351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"13448c3c_ec78ed1c","updated":"2023-12-11 14:01:32.000000000","message":"lgtm","commit_id":"6b0f055b4ed407f8a190f768d0e654235ac015dd"}],"functions":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c8624cc573e0bb494ca8accb6429f4d49efa1da","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":139,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"abefd7cc_534f97c1","line":141,"updated":"2023-12-08 08:01:57.000000000","message":"need to declare this variable as local. also I\u0027d think three attempts should be enough","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2088131aeebcf49f846f2e2f47ebbef0b88f4015","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":139,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"12e08cd8_4d42a245","line":141,"in_reply_to":"97ebbe51_c9e821a7","updated":"2023-12-08 12:07:36.000000000","message":"Done","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a88ecf91f139792d8a7e3888a0ac3d00d09ba4bb","unresolved":true,"context_lines":[{"line_number":138,"context_line":"    image_fname\u003d`basename \"$image_url\"`"},{"line_number":139,"context_line":"    if [[ $image_url !\u003d file* ]]; then"},{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"97ebbe51_c9e821a7","line":141,"in_reply_to":"abefd7cc_534f97c1","updated":"2023-12-08 11:25:20.000000000","message":"+1 or could do max 5 attempts too just in case.","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9c8624cc573e0bb494ca8accb6429f4d49efa1da","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":145,"context_line":"                if [[ $? -ne 0 ]]; then"},{"line_number":146,"context_line":"                    echo \"Not found: $image_url\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"44cf55a5_a253a65c","line":143,"updated":"2023-12-08 08:01:57.000000000","message":"I\u0027m not sure if this conditional should actually be within the loop? Rather use the return code of the wget command?","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2088131aeebcf49f846f2e2f47ebbef0b88f4015","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":145,"context_line":"                if [[ $? -ne 0 ]]; then"},{"line_number":146,"context_line":"                    echo \"Not found: $image_url\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"55100591_7c82b168","line":143,"in_reply_to":"3c6c2fc5_5a6763b4","updated":"2023-12-08 12:07:36.000000000","message":"Done","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a88ecf91f139792d8a7e3888a0ac3d00d09ba4bb","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        # Downloads the image (uec ami+akistyle), then extracts it."},{"line_number":141,"context_line":"        max_attempts\u003d10"},{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":145,"context_line":"                if [[ $? -ne 0 ]]; then"},{"line_number":146,"context_line":"                    echo \"Not found: $image_url\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3c6c2fc5_5a6763b4","line":143,"in_reply_to":"44cf55a5_a253a65c","updated":"2023-12-08 11:25:20.000000000","message":"Yes this could be moved out.","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a88ecf91f139792d8a7e3888a0ac3d00d09ba4bb","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":145,"context_line":"                if [[ $? -ne 0 ]]; then"},{"line_number":146,"context_line":"                    echo \"Not found: $image_url\""},{"line_number":147,"context_line":"                    if [[ \"$i\" -eq \"$max_attempts\" ]]; then"},{"line_number":148,"context_line":"                        return"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"eeaee727_b3716d4d","line":145,"updated":"2023-12-08 11:25:20.000000000","message":"i was trying to handle similar issue in another patch https://review.opendev.org/c/openstack/devstack/+/902773, this patch missing that case.\n\nCan you also incorporate changes from that patch here?","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2088131aeebcf49f846f2e2f47ebbef0b88f4015","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        for i in `seq $max_attempts`; do"},{"line_number":143,"context_line":"            if [[ ! -f $FILES/$image_fname || \"$(stat -c \"%s\" $FILES/$image_fname)\" \u003d \"0\" ]]; then"},{"line_number":144,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname"},{"line_number":145,"context_line":"                if [[ $? -ne 0 ]]; then"},{"line_number":146,"context_line":"                    echo \"Not found: $image_url\""},{"line_number":147,"context_line":"                    if [[ \"$i\" -eq \"$max_attempts\" ]]; then"},{"line_number":148,"context_line":"                        return"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3e0da811_7ef6ad6f","line":145,"in_reply_to":"eeaee727_b3716d4d","updated":"2023-12-08 12:07:36.000000000","message":"Done","commit_id":"ce7f94ccb660c1e6f5199f5a9d289e4a214a6a13"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3f655ef6dc0282d53518149edc968239a98ec4ed","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname || rc\u003d$?"},{"line_number":147,"context_line":"                if [[ $rc -ne 0 ]]; then"},{"line_number":148,"context_line":"                    if [[ \"$attempt\" -eq \"$max_attempts\" ]]; then"},{"line_number":149,"context_line":"                        echo \"Not found: $image_url\""},{"line_number":150,"context_line":"                        return"},{"line_number":151,"context_line":"                    fi"},{"line_number":152,"context_line":"                    echo \"Download failed, retrying in $attempt second, attempt: $attempt\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fc3af258_f7e094b7","line":149,"range":{"start_line":149,"start_character":30,"end_line":149,"end_character":39},"updated":"2023-12-11 08:50:05.000000000","message":"Maybe also use \"Download failed:\" here for consistency with the previous attempts?\n\nAlso I\u0027m wondering whether we should error out in this case instead of silently returning and waiting for devstack to fail in some later stage?","commit_id":"6b0f055b4ed407f8a190f768d0e654235ac015dd"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d421e299943de05f3f02def018f24250463a99e0","unresolved":true,"context_lines":[{"line_number":146,"context_line":"                wget --progress\u003ddot:giga -c $image_url -O $FILES/$image_fname || rc\u003d$?"},{"line_number":147,"context_line":"                if [[ $rc -ne 0 ]]; then"},{"line_number":148,"context_line":"                    if [[ \"$attempt\" -eq \"$max_attempts\" ]]; then"},{"line_number":149,"context_line":"                        echo \"Not found: $image_url\""},{"line_number":150,"context_line":"                        return"},{"line_number":151,"context_line":"                    fi"},{"line_number":152,"context_line":"                    echo \"Download failed, retrying in $attempt second, attempt: $attempt\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"de8f9867_ffec5681","line":149,"range":{"start_line":149,"start_character":30,"end_line":149,"end_character":39},"in_reply_to":"fc3af258_f7e094b7","updated":"2023-12-11 08:57:28.000000000","message":"Actually not changed that intentionally as this patch focused only on retry attempts in case of failures, but if there is strong ask can be changed in follow up?","commit_id":"6b0f055b4ed407f8a190f768d0e654235ac015dd"}]}