)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eaedfbb7aaf19fb3d2bb84e6da5b667a557cf469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"297de5c2_28018063","updated":"2023-12-06 10:29:05.000000000","message":"This is untested. To be seen how it works. I can respin accordingly.","commit_id":"316b8bcd91804fde60c94828ab38bc91b7683d40"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a857b1d5d3ba7c1e9eeee8b291b18ed7029b2a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"908ad9d6_f76d7ecd","in_reply_to":"297de5c2_28018063","updated":"2023-12-06 11:07:44.000000000","message":"Tested now. I needed to fix a bug in the nova patch but this otherwise seems to work just fine.","commit_id":"316b8bcd91804fde60c94828ab38bc91b7683d40"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5be550d03e17f357ae69ca00a9d9c238d7c110d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"33a20085_c42c40cc","updated":"2023-12-06 21:16:59.000000000","message":"The lib/apache code change has been tested with a related Octavia code change and succeeded.","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a8d0af70140a2746b8c9d4c83e811d0ea0bc1fec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"141c427b_1535b2ad","updated":"2024-04-19 10:56:45.000000000","message":"lgtm, thanks","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bac5c386e9b3891db7fe883aec698a61141a2e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a695ba5d_087fc8be","updated":"2024-03-05 16:41:42.000000000","message":"we are likely to merge the nova patch this week. this looks correct to me based on the ci results","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"abedd2ce9f9118ba298b77ef451bd7dd0fa5674f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48160824_146475af","updated":"2024-04-19 11:46:01.000000000","message":"digits ... underscores ... nice ;)","commit_id":"b6613b1e71fb6a0efb63ec9346bd2e67131657e0"}],"lib/apache":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"59b7c544520f5a59ac39169f52dbbf44351310f8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    rm -rf $conf"},{"line_number":263,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":264,"context_line":"    # been given"},{"line_number":265,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":266,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":267,"context_line":"    else"},{"line_number":268,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"49d51501_8559c839","line":265,"updated":"2023-12-06 12:07:35.000000000","message":"note: this regex is far from complete but it\u0027s Good Enough (TM) for our purposes IMO","commit_id":"316b8bcd91804fde60c94828ab38bc91b7683d40"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f6de1649fbd53d0395a41a127a10a362d96961d9","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ef863c04_e6bf2cf4","line":268,"updated":"2024-04-09 15:07:22.000000000","message":"I\u0027m not confident that making this dependent on a regex is a good idea. can we have either an explicit parameter for this choice or (given that likely at some point the new version will replace the old one) have different functions where we can make the old one deprecated?\n\nAlso can\u0027t the part after the \":\" also include \"_\"?","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"337791683cf9666682fcef5ad4f0861992dd821e","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a289348c_17f4e52d","line":268,"in_reply_to":"07ad1e3c_e09fa0c7","updated":"2024-04-17 10:32:59.000000000","message":"How about reversing the check then and requiring file references to have an absolute path?\n\n`if [[ $wsgi \u003d /* ]]; then` iniset wsgi-file ...\n\nNote that `[[ ]]` doesn\u0027t require quotes and `\u003d` is the same as `\u003d\u003d` afaict.","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66e01f43d6aa1c8bc13c9f75aeca364e30e82ec8","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"c1ee4a48_134b5794","line":268,"in_reply_to":"a289348c_17f4e52d","updated":"2024-04-17 11:17:22.000000000","message":"`\u003d` is less clear as it not clear that its a comparison so if `\u003d` and `\u003d\u003d` are equivlent we should prefer the latter.","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46004038fc97b3f72e86f8b33d3f3988e1297336","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa7a26cf_956ecd30","line":268,"in_reply_to":"c1ee4a48_134b5794","updated":"2024-04-19 10:03:34.000000000","message":"\u003e How about reversing the check then and requiring file references to have an absolute path?\n\nThat seems more fragile. Is it not possible for us to (mistakenly) pass a relative path? We can guarantee that a module path contains a colon. Can we guarantee a file path starts with a leading slash?","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4641e8e67e5df055749f47cad9a1096986a8ef8","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"07ad1e3c_e09fa0c7","line":268,"in_reply_to":"ef863c04_e6bf2cf4","updated":"2024-04-17 10:18:51.000000000","message":"We already have two \"configure uWSGI conf\" functions here - this one and `write_local_uwsgi_http_config` - and I really wanted to avoid adding a third that would need to be kept in-sync, particularly when the current one is liable to fall out of fashion so quickly as we move into a world without `distutils` (and therefore a world without support for pbr\u0027s `wsgi_scripts`).\n\nI\u0027m thinking the presence of a colon in the string is sufficient to indicate that we are talking about module (I mean, they\u0027re valid on Linux but not recommended and I\u0027ve never seen them). Perhaps I could simplify this to a simple \"contains a colon\" check?\n\n```\nif [[ $wsgi \u003d\u003d *\":\"* ]]; then\n```","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d7f5a3b0ac4339ab6ebae8339033495c8b9fc334","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    rm -rf $conf"},{"line_number":266,"context_line":"    # Set either the module path or wsgi script path depending on what we\u0027ve"},{"line_number":267,"context_line":"    # been given"},{"line_number":268,"context_line":"    if [[ \"$wsgi\" \u003d~ ^[a-zA-Z_.]+:[a-zA-Z]+$ ]]; then"},{"line_number":269,"context_line":"        iniset \"$conf\" uwsgi module \"$wsgi\""},{"line_number":270,"context_line":"    else"},{"line_number":271,"context_line":"        iniset \"$conf\" uwsgi wsgi-file \"$wsgi\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"dccf6dd8_1e8f1f8c","line":268,"in_reply_to":"fa7a26cf_956ecd30","updated":"2024-04-19 11:08:19.000000000","message":"Ok, so let\u0027s just stick with this","commit_id":"a2b8f8835550083ae28ce72eb8c7823a70f5097a"}]}