)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8874a1de802a82ae4d70ec1e18b14664fd939150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfb2bb98_a57a7a16","updated":"2024-02-07 10:54:11.000000000","message":"any chance you have a patch depending on this change so that we can verify it works as intended?","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4b24f3cc69e87ec8f94d220dfdad9cc72b955922","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e0d3490_27674fee","in_reply_to":"3203c0a7_0b714a97","updated":"2024-12-10 22:23:04.000000000","message":"As I found a proper use for this in Heat (want to enable some backup-dependent heat tempest test w/o installing Swift or Ceph) I might just do that.","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9501fd75c8d27c1aa1059b7d0410eeeef4083055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d38bffa_6c6a9814","in_reply_to":"3e0d3490_27674fee","updated":"2024-12-11 13:37:21.000000000","message":"Done","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"27e03b8975192475a00f701281d0e67222a57649","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3203c0a7_0b714a97","in_reply_to":"bfb2bb98_a57a7a16","updated":"2024-02-08 15:28:51.000000000","message":"no, not actually. TBH not even sure how to start with that - some DNM patch to cinder\u0027s zuul config to set up some job to use this backup driver and see if cinder backup tests pass?","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3c8aaa4bf9b63bec436eb6e0cf05023e2fbea5c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"32df10bc_48b50d45","updated":"2024-12-11 13:42:00.000000000","message":"Effectively I am trying to (re)enable and improve some backup-restore related tests in Heat, for which I\u0027d like to have cinder-backup w/o any additional backend services.\n\nPath that enabled cinder-backup with posix driver on heat-functional tests \nhttps://review.opendev.org/c/openstack/heat/+/937533","commit_id":"a90f9ea93a7b4c1cd34de3626eea454193b3241d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"85b3086260e119243ff65e3937b7ad972692d0df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e58af041_870fbfb6","in_reply_to":"32df10bc_48b50d45","updated":"2024-12-11 14:36:43.000000000","message":"Do you also have a review which runs the full set of cinder tests (maybe in  cinder or cinder-tempest-plugin), just to ensure that everything is fine? I suspect this is not the most tested drivers, so there could be surprises.","commit_id":"a90f9ea93a7b4c1cd34de3626eea454193b3241d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2a3a81ab960d76d54ad592bcb04adf0a9a4d1ec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d1ae792_0e560a1c","in_reply_to":"e58af041_870fbfb6","updated":"2024-12-14 10:07:28.000000000","message":"I\u0027ll do some for sure","commit_id":"a90f9ea93a7b4c1cd34de3626eea454193b3241d"}],"lib/cinder_backups/posix":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8874a1de802a82ae4d70ec1e18b14664fd939150","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.posix.PosixBackupDriver\""},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: delete backup files on cleanup or init?"},{"line_number":25,"context_line":"# init_cinder_backup_posix: nothing to do"},{"line_number":26,"context_line":"# cleanup_cinder_backup_posix: nothing to do"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"47799c73_cd9c1802","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":6},"updated":"2024-02-07 10:54:11.000000000","message":"is this a TODO on this patch or a general one that may be addressed later?","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"27e03b8975192475a00f701281d0e67222a57649","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.posix.PosixBackupDriver\""},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: delete backup files on cleanup or init?"},{"line_number":25,"context_line":"# init_cinder_backup_posix: nothing to do"},{"line_number":26,"context_line":"# cleanup_cinder_backup_posix: nothing to do"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f2fdf47_2d9ff77d","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":6},"in_reply_to":"47799c73_cd9c1802","updated":"2024-02-08 15:28:51.000000000","message":"that\u0027s something I am not sure if we should do and was hoping for some comments if it is really needed :-)","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4b24f3cc69e87ec8f94d220dfdad9cc72b955922","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.posix.PosixBackupDriver\""},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: delete backup files on cleanup or init?"},{"line_number":25,"context_line":"# init_cinder_backup_posix: nothing to do"},{"line_number":26,"context_line":"# cleanup_cinder_backup_posix: nothing to do"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"c2294db2_da0b2e61","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":6},"in_reply_to":"5f2fdf47_2d9ff77d","updated":"2024-12-10 22:23:04.000000000","message":"I think I\u0027ll see what lvm volume driver does and try to do the same","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9501fd75c8d27c1aa1059b7d0410eeeef4083055","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    iniset $CINDER_CONF DEFAULT backup_driver \"cinder.backup.drivers.posix.PosixBackupDriver\""},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# TODO: delete backup files on cleanup or init?"},{"line_number":25,"context_line":"# init_cinder_backup_posix: nothing to do"},{"line_number":26,"context_line":"# cleanup_cinder_backup_posix: nothing to do"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e27f948e_aa91c247","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":6},"in_reply_to":"c2294db2_da0b2e61","updated":"2024-12-11 13:37:21.000000000","message":"Done","commit_id":"525acbdbfe8508f7514761a1a8660203e4e2d8de"}]}