)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b692dbc8cb5f38d452cd27c5861e79c3979adaec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9aa670a_5c5e35b2","updated":"2023-12-19 10:38:16.000000000","message":"Good catch, comments inline","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"e1776a1cd62872453cf4c578253cc525e3e99b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e2af5c1_2dba83de","updated":"2024-01-08 09:20:36.000000000","message":"Opened the change in https://review.opendev.org/c/openstack/devstack/+/904950","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6617a029e08176eaccbbbc63309fdb87353c71fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fc36dad_28ffaa35","updated":"2024-01-03 17:02:53.000000000","message":"good catch, thanks!","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb0d8e75917ab179ed43ee2918f29eb0d523ccf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac1ed0bf_7d5fa25c","updated":"2023-12-19 18:53:29.000000000","message":"thx","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"56b610af7373ecfcaa564c3d3d966cb1a62dcec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcfed968_c74b825a","in_reply_to":"9e2af5c1_2dba83de","updated":"2024-01-08 20:57:39.000000000","message":"Thanks :)","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b692dbc8cb5f38d452cd27c5861e79c3979adaec","unresolved":true,"context_lines":[{"line_number":207,"context_line":"USE_VENV\u003d$(trueorfalse False USE_VENV)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirmenets files here, in a comma-separated list"},{"line_number":211,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-${ADITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"# This can be used to turn database query logging on and off"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b6977a2c_1bbbfdbe","line":210,"range":{"start_line":210,"start_character":2,"end_line":210,"end_character":14},"updated":"2023-12-19 10:38:16.000000000","message":"can you please fix this typo, too?","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"5acb3bc99298ad7a2f14b0c43c1f765a6b3416f3","unresolved":false,"context_lines":[{"line_number":207,"context_line":"USE_VENV\u003d$(trueorfalse False USE_VENV)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirmenets files here, in a comma-separated list"},{"line_number":211,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-${ADITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"# This can be used to turn database query logging on and off"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0b0c35db_031559f9","line":210,"range":{"start_line":210,"start_character":2,"end_line":210,"end_character":14},"in_reply_to":"b6977a2c_1bbbfdbe","updated":"2023-12-19 12:45:12.000000000","message":"Done","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b692dbc8cb5f38d452cd27c5861e79c3979adaec","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirmenets files here, in a comma-separated list"},{"line_number":211,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-${ADITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":214,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b865dbbb_040d97a4","line":211,"updated":"2023-12-19 10:38:16.000000000","message":"Checking with codesearch, this doesn\u0027t seem to be used anywhere within an official openstack project at least. So not sure whether we really need to keep the backwards compat. If we do however, a comment explaining it would be nice.\n\nIn general I think we can deprecate and drop the whole support for per project venvs now that we have a global venv. But that\u0027s something for another patch I guess.","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"5acb3bc99298ad7a2f14b0c43c1f765a6b3416f3","unresolved":true,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirmenets files here, in a comma-separated list"},{"line_number":211,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-${ADITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":214,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c5edbb2f_d4560ba9","line":211,"in_reply_to":"b865dbbb_040d97a4","updated":"2023-12-19 12:45:12.000000000","message":"I just stumbled over that, as I need to install network drivers via packages.\nI was looking into creating a PR to make use of that var in the global venv.","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"f38af4f0c93e39d1c39ef61d1c155e8f513ba0e4","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirmenets files here, in a comma-separated list"},{"line_number":211,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-${ADITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":214,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"17c3bbcb_8141de2f","line":211,"in_reply_to":"c5edbb2f_d4560ba9","updated":"2023-12-19 16:56:58.000000000","message":"I opted just dropping the backwards compatibility.","commit_id":"08fb3f70738283651bca88af20ea35b2a0cfdf39"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"31daab51f74e538423bafe5c64649489dee7897c","unresolved":true,"context_lines":[{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirements files here, in a comma-separated list."},{"line_number":211,"context_line":"# Currently only used when USE_VENV is true (individual project venvs)"},{"line_number":212,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":215,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a5bc6248_a20431d1","line":212,"range":{"start_line":212,"start_character":56,"end_line":212,"end_character":57},"updated":"2024-01-07 15:17:37.000000000","message":"hmm, isn\u0027t this bracket extra?","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"32dbd42ea71fa04b6a85b742ae6856acdb2cdf6b","unresolved":true,"context_lines":[{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirements files here, in a comma-separated list."},{"line_number":211,"context_line":"# Currently only used when USE_VENV is true (individual project venvs)"},{"line_number":212,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":215,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a7a69b61_99dc8238","line":212,"range":{"start_line":212,"start_character":56,"end_line":212,"end_character":57},"in_reply_to":"a5bc6248_a20431d1","updated":"2024-01-08 09:16:58.000000000","message":"You\u0027re right... I\u0027ll create a patch for that.","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"e1776a1cd62872453cf4c578253cc525e3e99b2a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":210,"context_line":"# requirements files here, in a comma-separated list."},{"line_number":211,"context_line":"# Currently only used when USE_VENV is true (individual project venvs)"},{"line_number":212,"context_line":"ADDITIONAL_VENV_PACKAGES\u003d${ADDITIONAL_VENV_PACKAGES:-\"\"}}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# This can be used to turn database query logging on and off"},{"line_number":215,"context_line":"# (currently only implemented for MySQL backend)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d0159a6e_94d541de","line":212,"range":{"start_line":212,"start_character":56,"end_line":212,"end_character":57},"in_reply_to":"a7a69b61_99dc8238","updated":"2024-01-08 09:20:36.000000000","message":"Done","commit_id":"6fc0e74aa7369ed1503e2d0f12d7543d4835212e"}]}