)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6d06424dab191ba76ae4121ae4b1345a86938e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"46b441df_d34c7ed8","updated":"2024-01-10 07:40:38.000000000","message":"recheck \"test_tagged_attachment\"","commit_id":"12f892c47a06cf5917b66256cbcea6c9876320e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c6a89c694586f970c6138a328cba6d0b43b3e48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2bcbbbc9_7a4aa59d","updated":"2024-01-15 06:42:30.000000000","message":"The new job in the test patch is still failing with a timeout, so not sure if this should be merged yet?","commit_id":"72c727ff763ac9de0498b29e4e4f81cac99ee5a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"56918e3a795666a12ba27c8c1f7c20e2c84f144f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"696f8c7a_62db59f4","in_reply_to":"2bcbbbc9_7a4aa59d","updated":"2024-01-15 07:58:43.000000000","message":"I\u0027m still checking that. Meanwhile I\u0027ll leave this patch with a -W.","commit_id":"72c727ff763ac9de0498b29e4e4f81cac99ee5a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6852b51bb0917ed432d2e2f710137bc4e9814b19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f53a5552_f667a284","in_reply_to":"696f8c7a_62db59f4","updated":"2024-01-15 09:59:51.000000000","message":"The issue was in [1]: the \"extensions\" configuration parameter must be under [agent], not in [DEFAULT]. The Neutron patch is checking it again now.\n\n[1]https://review.opendev.org/c/openstack/devstack/+/904171/12..13/lib/neutron_plugins/ovn_agent","commit_id":"72c727ff763ac9de0498b29e4e4f81cac99ee5a0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0cbc23a85fba3d359bdb14efe55b16b9cbccae83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"72f0b7d6_acfd499f","in_reply_to":"f53a5552_f667a284","updated":"2024-01-15 15:50:12.000000000","message":"--\u003e https://zuul.opendev.org/t/openstack/build/e24f4d1ed4d64d0287c366c75dc703f7","commit_id":"72c727ff763ac9de0498b29e4e4f81cac99ee5a0"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"803ac2e6acb69bad8eee4f21bd219d1622a55473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f5fd94d9_9fb223aa","updated":"2024-01-17 16:51:29.000000000","message":"lgtm","commit_id":"6091df25a39c9b17883d86ccb091bf2b9c39aa15"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3a4816f0b7692b6da3e148db734ee0bc8b9dd547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"16b4dd38_bced5a91","updated":"2024-01-15 12:28:40.000000000","message":"recheck tempest-full-py3","commit_id":"6091df25a39c9b17883d86ccb091bf2b9c39aa15"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0db930af6aa7980bc400c5020ab9018480993a1e","unresolved":true,"context_lines":[{"line_number":501,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE ovn ovn_metadata_enabled\u003dTrue"},{"line_number":502,"context_line":"        else"},{"line_number":503,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE ovn ovn_metadata_enabled\u003dFalse"},{"line_number":504,"context_line":"        fi"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if is_service_enabled q-dns neutron-dns ; then"},{"line_number":507,"context_line":"            iniset $NEUTRON_CONF DEFAULT dns_domain openstackgate.local"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"dfe0b71c_be192a8e","line":504,"updated":"2024-01-10 13:46:17.000000000","message":"one of these will always overwrite the result of the if/else block before, this doesn\u0027t look right to me. rather do some if/elif construct like for n-api-meta below?","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8baba2011e9c63868d2cf24516f36240945bc83f","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE ovn ovn_metadata_enabled\u003dTrue"},{"line_number":502,"context_line":"        else"},{"line_number":503,"context_line":"            populate_ml2_config /$Q_PLUGIN_CONF_FILE ovn ovn_metadata_enabled\u003dFalse"},{"line_number":504,"context_line":"        fi"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        if is_service_enabled q-dns neutron-dns ; then"},{"line_number":507,"context_line":"            iniset $NEUTRON_CONF DEFAULT dns_domain openstackgate.local"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"dd839b16_f2e4cced","line":504,"in_reply_to":"dfe0b71c_be192a8e","updated":"2024-01-10 15:42:32.000000000","message":"And I think this is what is causing the issue in the CI. Good catch!","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0db930af6aa7980bc400c5020ab9018480993a1e","unresolved":true,"context_lines":[{"line_number":562,"context_line":"        sample_file\u003d$NEUTRON_DIR/etc/neutron_ovn_metadata_agent.ini.sample"},{"line_number":563,"context_line":"        config_file\u003d$OVN_META_CONF"},{"line_number":564,"context_line":"    fi"},{"line_number":565,"context_line":"    if [ ! -z config_file ]; then"},{"line_number":566,"context_line":"        sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        mkdir -p $NEUTRON_DIR/etc/neutron/plugins/ml2"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3eb96f9e_1a5dd7e8","line":565,"updated":"2024-01-10 13:46:17.000000000","message":"\"! -z\" is the same as \"-n\", I\u0027d prefer to use the latter for simplicity\n\nalso you want \"${config_file}\" I guess?","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8baba2011e9c63868d2cf24516f36240945bc83f","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        sample_file\u003d$NEUTRON_DIR/etc/neutron_ovn_metadata_agent.ini.sample"},{"line_number":563,"context_line":"        config_file\u003d$OVN_META_CONF"},{"line_number":564,"context_line":"    fi"},{"line_number":565,"context_line":"    if [ ! -z config_file ]; then"},{"line_number":566,"context_line":"        sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        mkdir -p $NEUTRON_DIR/etc/neutron/plugins/ml2"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"79286d57_8a70787d","line":565,"in_reply_to":"3eb96f9e_1a5dd7e8","updated":"2024-01-10 15:42:32.000000000","message":"Yeah, I usually don\u0027t write bash scripts and I\u0027m little rusty","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0db930af6aa7980bc400c5020ab9018480993a1e","unresolved":true,"context_lines":[{"line_number":585,"context_line":"            iniset $config_file ovn \\"},{"line_number":586,"context_line":"                ovn_sb_private_key $INT_CA_DIR/private/$DEVSTACK_CERT_NAME.key"},{"line_number":587,"context_line":"        fi"},{"line_number":588,"context_line":"        if [[ \"$config_file\" \u003d\u003d $OVN_AGENT_CONF ]]; then"},{"line_number":589,"context_line":"            iniset $config_file DEFAULT extensions $OVN_AGENT_EXTENSIONS"},{"line_number":590,"context_line":"            iniset $config_file ovn ovn_nb_connection $OVN_NB_REMOTE"},{"line_number":591,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3609d409_0676c58f","line":588,"updated":"2024-01-10 13:46:17.000000000","message":"unless you are using \"\" around $config_file everywhere, you don\u0027t need them here either","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8baba2011e9c63868d2cf24516f36240945bc83f","unresolved":false,"context_lines":[{"line_number":585,"context_line":"            iniset $config_file ovn \\"},{"line_number":586,"context_line":"                ovn_sb_private_key $INT_CA_DIR/private/$DEVSTACK_CERT_NAME.key"},{"line_number":587,"context_line":"        fi"},{"line_number":588,"context_line":"        if [[ \"$config_file\" \u003d\u003d $OVN_AGENT_CONF ]]; then"},{"line_number":589,"context_line":"            iniset $config_file DEFAULT extensions $OVN_AGENT_EXTENSIONS"},{"line_number":590,"context_line":"            iniset $config_file ovn ovn_nb_connection $OVN_NB_REMOTE"},{"line_number":591,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"6ae1fc1e_5fb37856","line":588,"in_reply_to":"3609d409_0676c58f","updated":"2024-01-10 15:42:32.000000000","message":"Done","commit_id":"708b95dd0eff4e6e97d78838f68e4a1e6a8d9cf8"}]}