)]}'
{"id":"openstack%2Fdevstack~90553","triplet_id":"openstack%2Fdevstack~master~I828cb331dfb578889c66eff6ed76bde6be65b20c","project":"openstack/devstack","branch":"master","topic":"master","hashtags":[],"change_id":"I828cb331dfb578889c66eff6ed76bde6be65b20c","subject":"Set osapi_compute_extensions default value","status":"ABANDONED","created":"2014-04-26 17:04:16.000000000","updated":"2014-07-22 09:20:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"66aa0c3f63c4c97dbf890fcf18f017f1886dac33","_number":90553,"virtual_id_number":90553,"owner":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-04-26 18:09:26.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2014-04-26 18:25:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":-1,"date":"2014-04-28 20:13:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":-2,"date":"2014-04-27 20:38:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-04-26 17:06:33.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"date":"2014-04-27 20:38:47.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-04-26 18:09:26.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-04-26 18:25:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-04-27 20:38:47.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-04-28 20:13:12.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"}],"messages":[{"id":"ad9f19916d3bcbf96082c69cf0a94d3e12d9700e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-26 17:04:16.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"68f4fa9af78f2b07eb25191b265be9235dc33698","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2014-04-26 17:06:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7198b3530cce6b3ac6a6db0826cf8661c8c29237","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-26 17:06:34.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9077460e4a4390080e023a0557a94ebe7f2e6c4b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-04-26 18:09:26.000000000","message":"Patch Set 2: Works for me\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/53/90553/2/6113/results.html\n\nStandard recheck supported; use \"recheck xenserver\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":2},{"id":"f5c6d5e3a7fbc9cabc9a5fcf28cd636bd361191b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-26 18:25:34.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-full/49b305f : SUCCESS in 54m 48s\n- check-tempest-dsvm-neutron http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-neutron/7d70587 : SUCCESS in 59m 24s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-neutron-heat-slow/0cc8a50 : SUCCESS in 24m 18s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/53/90553/2/check/check-grenade-dsvm/2710dc3 : SUCCESS in 41m 39s\n- check-grenade-dsvm-neutron http://logs.openstack.org/53/90553/2/check/check-grenade-dsvm-neutron/3648a51 : FAILURE in 27m 11s (non-voting)\n- gate-devstack-bash8 http://logs.openstack.org/53/90553/2/check/gate-devstack-bash8/00e5517 : SUCCESS in 2m 02s\n- check-devstack-dsvm-cells http://logs.openstack.org/53/90553/2/check/check-devstack-dsvm-cells/7755bfd : SUCCESS in 13m 59s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-postgres-full/83d9279 : SUCCESS in 51m 22s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-neutron-full/4193ea9 : SUCCESS in 1h 18m 55s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/53/90553/2/check/gate-tempest-dsvm-large-ops/617f0fe : SUCCESS in 26m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/53/90553/2/check/gate-tempest-dsvm-neutron-large-ops/ea60a1b : SUCCESS in 23m 51s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/53/90553/2/check/check-grenade-dsvm-partial-ncpu/880c5d7 : SUCCESS in 31m 41s\n- check-neutron-dsvm-functional http://logs.openstack.org/53/90553/2/check/check-neutron-dsvm-functional/3b9f88a : SUCCESS in 12m 47s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/53/90553/2/check/check-swift-dsvm-functional/36d66a0 : SUCCESS in 14m 00s\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-ironic-nv/a4a758e : SUCCESS in 35m 18s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/53/90553/2/check/check-tempest-dsvm-ironic-postgres-nv/31719bb : SUCCESS in 34m 47s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"a79578c08f62da8e13c5e50c8c6c78217cc711fe","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-04-27 20:38:47.000000000","message":"Patch Set 2: Do not merge\n\ndevstack shouldn\u0027t set values we can default to. I think climate was taking advantage of a bad configuration we had, and needs to work in a more typical one.","accounts_in_message":[],"_revision_number":2},{"id":"19de6316dd14a9614960b80d222eefdf3f2d5592","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2014-04-28 10:52:42.000000000","message":"Patch Set 2:\n\nI think we still need the fix.\n\nFor single string, we do not need to set values in devstack and can use default values.\n\nBut for multiple string option, it is better to set default values, as the value in nova.conf will be simply overwrite the default value in nova but not appending the value.","accounts_in_message":[],"_revision_number":2},{"id":"bb89f7d4225ae0db1708fc02a38d9dd90ac453f7","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-04-28 20:13:12.000000000","message":"Patch Set 2: Code-Review-1\n\nI agree with Sean. devstack shouldn\u0027t set default values, even for multi string options, which are a little strange themselves.","accounts_in_message":[],"_revision_number":2},{"id":"f226e6fd74fa1a2f8ca6b4dee5a97e4e28f50806","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2014-04-29 03:12:19.000000000","message":"Patch Set 2:\n\nThis will bring some trouble for developers who is using devstack.\n\nI think that multi string options should be treated as an exception for devstack, it was now bring trouble to climate and may bring trouble to other projects in future. The devstack should make less trouble to developers.\n\nAlso I do not know why not remove the default values such as force_dhcp_release, instance_name_template etc as we also already have default value for those attributes.","accounts_in_message":[],"_revision_number":2},{"id":"0b710be1ba9749abe3558bb004bed1a44a57b63a","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2014-07-22 09:20:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f5b9ce00b61beb1940378a194f8c3e637cf217bf","revisions":{"edee25997df5a3dfce6e5af7cf4a42de2d4fb3be":{"kind":"REWORK","_number":1,"created":"2014-04-26 17:04:16.000000000","uploader":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"ref":"refs/changes/53/90553/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/53/90553/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/53/90553/1"}}},"commit":{"parents":[{"commit":"b61fc03102ca49d4b8c41710f5c9d7fcf7805ec7","subject":"Merge \"Replace DEFAULT section with service_credentials\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b61fc03102ca49d4b8c41710f5c9d7fcf7805ec7"}]}],"author":{"name":"Jay Lau","email":"liugya@cn.ibm.com","date":"2014-04-26 16:58:59.000000000","tz":480},"committer":{"name":"Jay Lau","email":"liugya@cn.ibm.com","date":"2014-04-26 17:04:08.000000000","tz":480},"subject":"Set osapi_compute_extensions default value","message":"Set osapi_compute_extensions default value\n\nThe Devstack commit 3317437caca5eb769ab4c6d3ea7c5d3e062517e2 removed\nthe osapi_compute_extensions configuration option from lib/nova.\n\nThis caused a bug of Climate 1312368, I think that we should not remove\ndefault value of osapi_compute_extension from devstack in nova as this\nvalue is a multiple string option. Once the default value is removed,\nthen when we add another value of osapi_compute_extension in nova.conf,\nthe default value of nova.api.openstack.compute.contrib.standard_extensions\nwill be overwritted and this will causes a lot of HTTP 404 at Nova API.\n\nChange-Id: I828cb331dfb578889c66eff6ed76bde6be65b20c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/edee25997df5a3dfce6e5af7cf4a42de2d4fb3be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/edee25997df5a3dfce6e5af7cf4a42de2d4fb3be"}]},"branch":"refs/heads/master"},"f5b9ce00b61beb1940378a194f8c3e637cf217bf":{"kind":"REWORK","_number":2,"created":"2014-04-26 17:06:33.000000000","uploader":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"ref":"refs/changes/53/90553/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/53/90553/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/53/90553/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/53/90553/2"}}},"commit":{"parents":[{"commit":"b61fc03102ca49d4b8c41710f5c9d7fcf7805ec7","subject":"Merge \"Replace DEFAULT section with service_credentials\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b61fc03102ca49d4b8c41710f5c9d7fcf7805ec7"}]}],"author":{"name":"Jay Lau","email":"liugya@cn.ibm.com","date":"2014-04-26 16:58:59.000000000","tz":480},"committer":{"name":"Jay Lau","email":"liugya@cn.ibm.com","date":"2014-04-26 17:06:16.000000000","tz":480},"subject":"Set osapi_compute_extensions default value","message":"Set osapi_compute_extensions default value\n\nThe Devstack commit 3317437caca5eb769ab4c6d3ea7c5d3e062517e2 removed\nthe osapi_compute_extensions configuration option from lib/nova.\n\nThis caused a bug of Climate 1312368, I think that we should not remove\ndefault value of osapi_compute_extension from devstack in nova as this\nvalue is a multiple string option. Once the default value is removed,\nthen when we add another value of osapi_compute_extension in nova.conf,\nthe default value of nova.api.openstack.compute.contrib.standard_extensions\nwill be overwritted and this will causes a lot of HTTP 404 at Nova API.\n\nChange-Id: I828cb331dfb578889c66eff6ed76bde6be65b20c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f5b9ce00b61beb1940378a194f8c3e637cf217bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f5b9ce00b61beb1940378a194f8c3e637cf217bf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}