)]}'
{"id":"openstack%2Fdevstack~906504","triplet_id":"openstack%2Fdevstack~master~I76ba139de69fb1710bcb96cc9f638260463e2032","project":"openstack/devstack","branch":"master","topic":"zswap","attention_set":{},"removed_from_attention_set":{"4393":{"account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"last_update":"2024-01-24 15:04:58.000000000","reason":"Change was submitted"},"22873":{"account":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"last_update":"2024-01-24 15:04:58.000000000","reason":"Change was submitted"},"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-01-24 15:04:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I76ba139de69fb1710bcb96cc9f638260463e2032","subject":"fix zswap enable flag","status":"MERGED","created":"2024-01-24 10:54:32.000000000","updated":"2024-01-24 15:06:02.000000000","submitted":"2024-01-24 15:04:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"906504-zswap","meta_rev_id":"49303e6aa4e1c3063f2c34b2eec2cdd6c24938e2","_number":906504,"virtual_id_number":906504,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-01-24 15:04:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-01-24 10:58:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-01-24 10:58:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-01-24 10:58:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-24 10:57:25.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"},{"updated":"2024-01-24 10:57:25.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2024-01-24 10:58:58.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2024-01-24 13:02:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ce5a15b1d7685382c28aefd84ff51ccb33251fb9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-01-24 10:54:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cd43fba9091cf2d1004c565e630f40ebd117de6","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-01-24 10:57:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"32f67663dfc2001120402dc4e1655dd4104e6da9","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2024-01-24 10:58:58.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ad6acd96c4ad35979e5bce7061040f2814b8340b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-24 13:02:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6607cc883bc143f8a052875b364317b8\n\n- grenade https://zuul.opendev.org/t/openstack/build/12f907b032b64cf4b71a8f7ca35dbcf3 : SUCCESS in 1h 09m 33s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5f7828417b0449f3983e3a55b0057470 : SUCCESS in 1h 29m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d5c99b97ff14a5694e9dc09ea0c3c62 : SUCCESS in 4m 44s\n- devstack https://zuul.opendev.org/t/openstack/build/3f1d3490127a4ef3b09e4c97d1fa87c5 : SUCCESS in 33m 19s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/4c992d7e10114b94b0a08b6abf3c819a : SUCCESS in 19m 26s\n- devstack-enforce-scope https://zuul.opendev.org/t/openstack/build/a6c902af6b884e00af79d55d310aec0e : SUCCESS in 30m 31s\n- devstack-platform-centos-9-stream https://zuul.opendev.org/t/openstack/build/a6e07b6826354a9d9497aea68765d9e6 : SUCCESS in 1h 28m 47s (non-voting)\n- devstack-platform-debian-bookworm https://zuul.opendev.org/t/openstack/build/a6fa5a3573cb49d9b3430ec94886c2df : SUCCESS in 1h 44m 29s\n- devstack-platform-debian-bullseye https://zuul.opendev.org/t/openstack/build/d17c9664006d4c688358eb5eed58f28f : SUCCESS in 1h 35m 16s\n- devstack-platform-rocky-blue-onyx https://zuul.opendev.org/t/openstack/build/9c8bfb54bfc6404380a4ad277acde686 : SUCCESS in 1h 33m 29s\n- devstack-platform-ubuntu-jammy-ovs https://zuul.opendev.org/t/openstack/build/548878dbeebc49c69c7e22c2503e88b1 : SUCCESS in 1h 36m 44s (non-voting)\n- devstack-platform-openEuler-22.03-ovn-source https://zuul.opendev.org/t/openstack/build/8f5d17c3cb72403ebaa7095cacde426b : SUCCESS in 1h 33m 29s (non-voting)\n- devstack-platform-openEuler-22.03-ovs https://zuul.opendev.org/t/openstack/build/9d73ebbddf644a019a40cdb1e17486d3 : FAILURE in 1h 23m 37s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/6278f5eadade45479b28082c2db24e57 : SUCCESS in 31m 44s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/e8c668f69eee42539389ceae781fc86e : SUCCESS in 3m 08s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/32f90ccd0ddd4545b79beaae26b9dad7 : SUCCESS in 2m 14s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/cbea67be08ba488eb91f5de912e95b36 : SUCCESS in 50m 11s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e5c815b7aa3942bba066f062ed32f156 : SUCCESS in 51m 21s\n- neutron-ovs-grenade-multinode https://zuul.opendev.org/t/openstack/build/0360af21ec8d4769b3828576635d35ef : SUCCESS in 1h 05m 11s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/0ed372602b0a42f398467fee6c3fcd24 : SUCCESS in 1h 06m 14s (non-voting)\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/3149b982af3b49deb3392620e4806ccd : SUCCESS in 1h 10m 30s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2772b174e2de43ed8d5faf34e3261414 : SUCCESS in 26m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1245a72b83fa43d096ad37b851baf90a : SUCCESS in 1h 09m 17s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/742f9cbe075e41df99008532d633fd06 : SUCCESS in 1h 58m 20s","accounts_in_message":[],"_revision_number":1},{"id":"19d01689a34013d8d78a82a2c2f6fe0c336aa5a8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-24 13:02:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8d7f4e546929780efd6fed109e60b1619108fc66","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-24 15:04:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f1ca43503c044b298757784e49e42458\n\n- grenade https://zuul.opendev.org/t/openstack/build/161b931628b74912879aec5a30a71ea3 : SUCCESS in 1h 11m 28s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/af3461b7daef4f9e9b863174414f0a22 : SUCCESS in 1h 41m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f8ee00bcabd4d6e968c43f49655a888 : SUCCESS in 4m 22s\n- devstack https://zuul.opendev.org/t/openstack/build/f8aac1ccbaf647e3a1037c7db2be185b : SUCCESS in 29m 19s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/d2fda2b9d3c64c2d9e2c6989a690d1df : SUCCESS in 34m 50s\n- devstack-platform-debian-bookworm https://zuul.opendev.org/t/openstack/build/63978301937c4cab97e9ee167068f562 : SUCCESS in 1h 37m 19s\n- devstack-platform-debian-bullseye https://zuul.opendev.org/t/openstack/build/b974255b20364bdb8b7916bf1130a7da : SUCCESS in 1h 12m 22s\n- devstack-platform-rocky-blue-onyx https://zuul.opendev.org/t/openstack/build/51b11e917c154d3ab94c754dbfc0c14f : SUCCESS in 1h 16m 46s\n- devstack-enforce-scope https://zuul.opendev.org/t/openstack/build/3ef333ccf68449b09d2bb99a16f7448d : SUCCESS in 17m 12s\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/92a90e938b5847019bdf69edd0a90972 : SUCCESS in 40m 40s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/76271876587d4e1c9aaa11a6817516a0 : SUCCESS in 3m 03s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/c0fa83b8de2440c092efc0fb1a68c1b3 : SUCCESS in 3m 20s\n- neutron-ovs-grenade-multinode https://zuul.opendev.org/t/openstack/build/248dde689dc946f58e592ac7685b5429 : SUCCESS in 47m 01s\n- ironic-tempest-bios-ipmi-direct-tinyipa https://zuul.opendev.org/t/openstack/build/4cfc7c298beb4d618f654910f5146e0f : SUCCESS in 1h 02m 29s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9ad140102de140e8a11443a40c70a802 : SUCCESS in 53m 43s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f2919583a5824485986ad34e4cc32d69 : SUCCESS in 23m 45s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/02cb5ab0ad9e4a1aaf2f8013a51934da : SUCCESS in 57m 01s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/524aa3df82bb409db1ff19761063f037 : SUCCESS in 1h 56m 24s","accounts_in_message":[],"_revision_number":1},{"id":"b8b0bbe31464ea4177149cfb36ba6d3378e51315","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-24 15:04:58.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"49303e6aa4e1c3063f2c34b2eec2cdd6c24938e2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-24 15:06:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d97717b02c1b4433baecb373a269b92c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/429cff1ec7634c139c4a9a2fb29edeb3 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5c1736b78256f5da86a91c4489f43f8ba1bce224","revisions":{"5c1736b78256f5da86a91c4489f43f8ba1bce224":{"kind":"REWORK","_number":1,"created":"2024-01-24 10:54:32.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/04/906504/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/04/906504/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/906504/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/906504/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/04/906504/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/04/906504/1"}}},"commit":{"parents":[{"commit":"031732998ab86206ff2762af8e7f1d0596021036","subject":"Merge \"add support for zswap and ksmtuned\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/031732998ab86206ff2762af8e7f1d0596021036"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-01-24 10:53:12.000000000","tz":0},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-01-24 10:53:12.000000000","tz":0},"subject":"fix zswap enable flag","message":"fix zswap enable flag\n\nzswap should only be enabled if ENABLE_ZSWAP is true.\nThe if condition was checking ENABLE_KSMTUNED.\nThat is now fixed.\n\nChange-Id: I76ba139de69fb1710bcb96cc9f638260463e2032\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5c1736b78256f5da86a91c4489f43f8ba1bce224"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5c1736b78256f5da86a91c4489f43f8ba1bce224"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}