)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd15cb4455793ae8e4b1dcd09e0e98d300a1f34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"128f86ff_ebcc1e33","updated":"2024-02-08 05:13:53.000000000","message":"it does not seems setting the host in tempest change in https://review.opendev.org/c/openstack/tempest/+/891123","commit_id":"b78185bd5d834aa715200b64a325b1c1170ad275"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"846d32c2aa3673881b8a5b19d5eb530114e64945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48ff6994_80d3463a","updated":"2024-02-12 15:13:51.000000000","message":"recheck - not sure why i don\u0027t see the jobs running o.O","commit_id":"5bc852ddb0a553d2b4b70409562009c3d50eb709"}],"lib/tempest":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dd15cb4455793ae8e4b1dcd09e0e98d300a1f34b","unresolved":true,"context_lines":[{"line_number":490,"context_line":"    if [\"$TEMEPST_SET_SRC_DEST_HOST\" \u003d\u003d \"True\"]; then"},{"line_number":491,"context_line":"        # get available hosts"},{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list -f value -c \"Hypervisor Hostname\")"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # split the hosts into an array"},{"line_number":496,"context_line":"        read -r -d \u0027\u0027 -a array \u003c\u003c\u003c \"$hosts\""},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        # set the source and destination host for live migration (hosts are not same, length \u003e 1)"},{"line_number":499,"context_line":"        if [ ${#hosts[@]} -gt 1 ]; then"},{"line_number":500,"context_line":"            iniset $TEMPEST_CONFIG compute migration_source_host ${hosts[0]}"},{"line_number":501,"context_line":"            iniset $TEMPEST_CONFIG compute migration_dest_host ${hosts[1]}"},{"line_number":502,"context_line":"        fi"},{"line_number":503,"context_line":"    fi"},{"line_number":504,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"200533fe_ec70cb9c","line":501,"range":{"start_line":493,"start_character":0,"end_line":501,"end_character":74},"updated":"2024-02-08 05:13:53.000000000","message":"I am not able to see the set host in tempest change. can we add logs to dump hosts and the host we are setting in tempest conf.\n\n- https://zuul.opendev.org/t/openstack/build/f2fdeea985124b7da860932e5ddf20c6/log/controller/logs/tempest_conf.txt\n\n- https://zuul.opendev.org/t/openstack/build/988060f223704869a1a94d97863b37c1/log/controller/logs/tempest_conf.txt","commit_id":"b78185bd5d834aa715200b64a325b1c1170ad275"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b9320796e024239af5b7e24ce787328a25c867fb","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        iniset $TEMPEST_CONFIG compute max_microversion $tempest_compute_max_microversion"},{"line_number":488,"context_line":"    fi"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ \"$TEMEPST_SET_SRC_DEST_HOST\" ]; then"},{"line_number":491,"context_line":"        # get available hosts"},{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list -f value -c \"Hypervisor Hostname\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"8c1fbff6_a6131f23","line":490,"range":{"start_line":490,"start_character":7,"end_line":490,"end_character":8},"updated":"2024-02-08 23:31:06.000000000","message":"also, use double brackets [[ ]], it\u0027s done like that in other ifs in this file plus if i remember bash class correctly, it\u0027s safer to use double brackets, something with evaluation of the content in between\n\nyou may also need to specifically compare the var to TRUE , like\n\nif [[ $TEMPEST_SET_SRC_DEST_HOST \u003d\u003d \"True\" ]]; then","commit_id":"6ecf3c41f2c57a3d445c33594d81f8a16f55f5da"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b9320796e024239af5b7e24ce787328a25c867fb","unresolved":true,"context_lines":[{"line_number":487,"context_line":"        iniset $TEMPEST_CONFIG compute max_microversion $tempest_compute_max_microversion"},{"line_number":488,"context_line":"    fi"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ \"$TEMEPST_SET_SRC_DEST_HOST\" ]; then"},{"line_number":491,"context_line":"        # get available hosts"},{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list -f value -c \"Hypervisor Hostname\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"8ba242a3_193b8916","line":490,"range":{"start_line":490,"start_character":11,"end_line":490,"end_character":36},"updated":"2024-02-08 23:31:06.000000000","message":"there is a typo - TEMEPST -\u003e TEMPEST","commit_id":"6ecf3c41f2c57a3d445c33594d81f8a16f55f5da"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4124284013bf02a903017e1bdd8b42ae8ff56585","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        iniset $TEMPEST_CONFIG compute max_microversion $tempest_compute_max_microversion"},{"line_number":488,"context_line":"    fi"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ \"$TEMEPST_SET_SRC_DEST_HOST\" ]; then"},{"line_number":491,"context_line":"        # get available hosts"},{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list -f value -c \"Hypervisor Hostname\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"6bd25d0c_bbcbcaf0","line":490,"range":{"start_line":490,"start_character":11,"end_line":490,"end_character":36},"in_reply_to":"8ba242a3_193b8916","updated":"2024-02-12 14:03:39.000000000","message":"Done","commit_id":"6ecf3c41f2c57a3d445c33594d81f8a16f55f5da"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4124284013bf02a903017e1bdd8b42ae8ff56585","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        iniset $TEMPEST_CONFIG compute max_microversion $tempest_compute_max_microversion"},{"line_number":488,"context_line":"    fi"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    if [ \"$TEMEPST_SET_SRC_DEST_HOST\" ]; then"},{"line_number":491,"context_line":"        # get available hosts"},{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list -f value -c \"Hypervisor Hostname\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fd178925_fe3cc90a","line":490,"range":{"start_line":490,"start_character":7,"end_line":490,"end_character":8},"in_reply_to":"8c1fbff6_a6131f23","updated":"2024-02-12 14:03:39.000000000","message":"Done","commit_id":"6ecf3c41f2c57a3d445c33594d81f8a16f55f5da"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1a14e7d5e7bf5b0c639feb828a321cb0792873e9","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list --os-cloud\u003ddevstack-admin -f value -c \"Hypervisor Hostname\")"},{"line_number":494,"context_line":"        # add logs to debug"},{"line_number":495,"context_line":"        echo \"Available hosts: $hosts\""},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        # split the hosts into an array"},{"line_number":498,"context_line":"        read -r -d \u0027\u0027 -a array \u003c\u003c\u003c \"$hosts\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"507c0980_c2e90ae9","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":2},"updated":"2024-02-12 20:41:06.000000000","message":"hmm, so it sees only one host:\n```\necho \u0027Available hosts: np0036730222\u0027\n```\n\nhttps://e5a63862163a03c1e338-88861b9d9400d056d1e59097cbe450ee.ssl.cf5.rackcdn.com/891123/25/check/tempest-multinode-full-py3/bcf5eb4/job-output.txt\nfrom this patch https://review.opendev.org/c/openstack/tempest/+/891123\n\nseems like we need another approach .. although I\u0027m starting to think this outweighs the benefits","commit_id":"5bc852ddb0a553d2b4b70409562009c3d50eb709"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"05c7deb21abab31fe12b64d3dde570e2bed3653a","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list --os-cloud\u003ddevstack-admin -f value -c \"Hypervisor Hostname\")"},{"line_number":494,"context_line":"        # add logs to debug"},{"line_number":495,"context_line":"        echo \"Available hosts: $hosts\""},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        # split the hosts into an array"},{"line_number":498,"context_line":"        read -r -d \u0027\u0027 -a array \u003c\u003c\u003c \"$hosts\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3418e2f5_c1ad59fc","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":2},"in_reply_to":"4e90e121_991ac592","updated":"2024-02-16 10:08:32.000000000","message":"\u0027openstack hypervisor list\u0027 isn\u0027t a nova api call? it must contact the nova api eventually , it\u0027s a user-facing client","commit_id":"5bc852ddb0a553d2b4b70409562009c3d50eb709"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d91779f86fd25a3f43359d448cbca5765809e9fb","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list --os-cloud\u003ddevstack-admin -f value -c \"Hypervisor Hostname\")"},{"line_number":494,"context_line":"        # add logs to debug"},{"line_number":495,"context_line":"        echo \"Available hosts: $hosts\""},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        # split the hosts into an array"},{"line_number":498,"context_line":"        read -r -d \u0027\u0027 -a array \u003c\u003c\u003c \"$hosts\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"8f0f740e_64ad85be","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":2},"in_reply_to":"507c0980_c2e90ae9","updated":"2024-02-13 10:54:55.000000000","message":"this approach is working fine:\nhttps://review.opendev.org/c/openstack/tempest/+/908866/\nwe can see that the dest and source hosts were set as intended:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_afb/908866/4/check/tempest-multinode-full-py3/afb874d/controller/logs/tempest_conf.txt","commit_id":"5bc852ddb0a553d2b4b70409562009c3d50eb709"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01a3ab8c50424e454952359ac3174b25fb5aea02","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        local hosts"},{"line_number":493,"context_line":"        hosts\u003d$(openstack hypervisor list --os-cloud\u003ddevstack-admin -f value -c \"Hypervisor Hostname\")"},{"line_number":494,"context_line":"        # add logs to debug"},{"line_number":495,"context_line":"        echo \"Available hosts: $hosts\""},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        # split the hosts into an array"},{"line_number":498,"context_line":"        read -r -d \u0027\u0027 -a array \u003c\u003c\u003c \"$hosts\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4e90e121_991ac592","line":495,"range":{"start_line":495,"start_character":0,"end_line":495,"end_character":2},"in_reply_to":"8f0f740e_64ad85be","updated":"2024-02-15 18:36:56.000000000","message":"I will suggest to get host name via nova service APIs there you can filter node with compute service is enabled and running and then get the host name form that node.","commit_id":"5bc852ddb0a553d2b4b70409562009c3d50eb709"}]}