)]}'
{"functions":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f6937879c86d7a2dd78edc3ce24d58ba2f0b520e","unresolved":false,"context_lines":[{"line_number":530,"context_line":"# create_disk - Create backing disk"},{"line_number":531,"context_line":"#function create_disk($DISK_IMAGE,$STORAGE_DATA_DIR,$LOOPBACK_DISK_SIZE) {"},{"line_number":532,"context_line":"function create_disk {"},{"line_number":533,"context_line":"    local node_number"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    # Create a loopback disk and format it to XFS."},{"line_number":536,"context_line":"    if [[ -e ${1} ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9ad9bd40_9744af75","line":533,"updated":"2014-04-30 10:18:08.000000000","message":"all local variables should be called out at the beginning. ${1} etc should never be used passed the initial declarations.","commit_id":"22695530cc31108b24138ec534e57cefb2896e74"}],"lib/cinder":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f6937879c86d7a2dd78edc3ce24d58ba2f0b520e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"# cleanup_cinder() - Remove residual data files, anything left over from previous"},{"line_number":138,"context_line":"# runs that a clean run would need to clean up"},{"line_number":139,"context_line":"function cleanup_cinder {"},{"line_number":140,"context_line":"    is_service_enabled ceph \u0026\u0026 return 0"},{"line_number":141,"context_line":"    # ensure the volume group is cleared up because fails might"},{"line_number":142,"context_line":"    # leave dead volumes in the group"},{"line_number":143,"context_line":"    TARGETS\u003d$(sudo tgtadm --op show --mode target)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9ad9bd40_172fbfa2","line":140,"updated":"2014-04-30 10:18:08.000000000","message":"this is not the right way to handle this. if we need to refactor cinder to make this call path optional, then that\u0027s what should be done.","commit_id":"22695530cc31108b24138ec534e57cefb2896e74"}],"lib/cinder_plugins/ceph":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f6937879c86d7a2dd78edc3ce24d58ba2f0b520e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # CINDER_BAK_CEPH_POOL_PGP\u003d\u003cpgp-num\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    iniset $CINDER_CONF DEFAULT volume_driver \"cinder.volume.drivers.rbd.RBDDriver\""},{"line_number":46,"context_line":"    iniset $CINDER_CONF DEFAULT rbd_ceph_conf \"$CEPH_CONF\""},{"line_number":47,"context_line":"    iniset $CINDER_CONF DEFAULT rbd_pool \"$CINDER_CEPH_POOL\""},{"line_number":48,"context_line":"    iniset $CINDER_CONF DEFAULT rbd_user \"$CINDER_CEPH_USER\""},{"line_number":49,"context_line":"    iniset $CINDER_CONF DEFAULT rbd_uuid \"$CINDER_CEPH_UUID\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9ad9bd40_b717f350","line":46,"updated":"2014-04-30 10:18:08.000000000","message":"these should have sane defaults","commit_id":"22695530cc31108b24138ec534e57cefb2896e74"}],"lib/nova":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f6937879c86d7a2dd78edc3ce24d58ba2f0b520e","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        # The group **$LIBVIRT_GROUP** is added to the current user in this script."},{"line_number":712,"context_line":"        # Use \u0027sg\u0027 to execute nova-compute as a member of the **$LIBVIRT_GROUP** group."},{"line_number":713,"context_line":"        screen_it n-cpu \"cd $NOVA_DIR \u0026\u0026 sg $LIBVIRT_GROUP \u0027$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\u0027\""},{"line_number":714,"context_line":"    if is_service_enabled ceph; then"},{"line_number":715,"context_line":"        # NOTE (leseb): YES this is ugly..."},{"line_number":716,"context_line":"        # We have to do this here because libvirt-bin must be started"},{"line_number":717,"context_line":"        # We add the secret to virsh to be able to connect to the ceph cluster"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9ad9bd40_92091d2f","line":714,"updated":"2014-04-30 10:18:08.000000000","message":"why can\u0027t this be done when all is said and done?","commit_id":"22695530cc31108b24138ec534e57cefb2896e74"}],"stack.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f6937879c86d7a2dd78edc3ce24d58ba2f0b520e","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        create_heat_accounts"},{"line_number":945,"context_line":"    fi"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    if is_service_enabled radosgw; then"},{"line_number":948,"context_line":"        create_radosgw_accounts"},{"line_number":949,"context_line":"    fi"},{"line_number":950,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad9bd40_37a76351","line":947,"updated":"2014-04-30 10:18:08.000000000","message":"if this is being done via extras, it shouldn\u0027t need to modify stack.sh","commit_id":"22695530cc31108b24138ec534e57cefb2896e74"}]}