)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e40d248dfcf3e6439aefad0f77db19d6cc634e50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d810b904_291a0e0a","updated":"2024-02-22 15:04:00.000000000","message":"recheck nova-ceph-multistore failed\nnot sure if the glance failures are related but this change is specific to cinder so i don\u0027t think they should be","commit_id":"53280529eb52c521e31ed367884331697022e439"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c1af42426c07efd6a468ce5363915387a818c180","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77ebf64d_491a756f","updated":"2024-06-26 19:44:16.000000000","message":"lgtm,\n\nThese new configs are enabled in\n-  https://review.opendev.org/c/openstack/cinder/+/909847\n\nand job passing fine\n- https://zuul.opendev.org/t/openstack/build/b6682634e6b74d87b62a47670c142936","commit_id":"2d3047307abd919bdeda8a42dfc1cb2b4651bf92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d03b88c11d0c296d7af54861c37a4eff95d4cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fc5bde27_23937adc","updated":"2024-08-08 16:04:13.000000000","message":"Sorry for the delay in responding and sorry for having some further change suggestions","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1a294aec4e9ed8deaf60d93503552da776c29724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5e4dabe_c1319e8b","updated":"2024-07-15 08:47:14.000000000","message":"Thanks Jens!","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"899c05ce596aaf51032979a49a39fa58cb29270a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"408be91f_445a7876","updated":"2024-08-13 19:37:48.000000000","message":"Thanks Jens!","commit_id":"d6e3d06001e7c4bb092cf9dc77188627bd2b9358"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc22c6b0b40d34fe00b6fd0c1ffa14a6a2d015bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a7897275_dde42580","updated":"2024-08-16 07:39:48.000000000","message":"recheck I can see similar failures in other gates as well (nova, glance)\ngoing through the build history, the issue doesn\u0027t seem to persist now\n\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dnova-ceph-multistore","commit_id":"d6e3d06001e7c4bb092cf9dc77188627bd2b9358"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2585ccb6964a3497383e7b98197ceae6567f1835","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15c58a69_c5749c40","updated":"2024-08-14 10:23:00.000000000","message":"recheck image tests failed with compute \u003c-\u003e glance interaction which is unrelated to this patch\n\ntempest.api.image.v2.test_images_formats.ImagesFormatTest","commit_id":"d6e3d06001e7c4bb092cf9dc77188627bd2b9358"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba51122b7c0d6a739b8a2c247a5e4d333a357fdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"59e8fbc4_0909ebdb","updated":"2024-08-16 13:50:49.000000000","message":"recheck unrelated failure in debian","commit_id":"d6e3d06001e7c4bb092cf9dc77188627bd2b9358"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"34205651f536be7935e790f6d431472a434ea516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ee8e5ca_883832b3","updated":"2024-08-16 13:50:32.000000000","message":"thx","commit_id":"d6e3d06001e7c4bb092cf9dc77188627bd2b9358"}],"lib/cinder":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2ddb8f5319385bb18c1c1938b25df468682b572a","unresolved":true,"context_lines":[{"line_number":749,"context_line":"    # Expect UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS to be a list of backends"},{"line_number":750,"context_line":"    # similar to CINDER_ENABLED_BACKENDS with NAME:TYPE where NAME will"},{"line_number":751,"context_line":"    # be the backend specific configuration stanza in cinder.conf."},{"line_number":752,"context_line":"    for be in ${UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS//,/ }; do"},{"line_number":753,"context_line":"        local be_name\u003d${be##*:}"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        iniset $CINDER_CONF $be_name image_upload_use_cinder_backend $UPLOAD_VOLUME_OPTIMIZED_ENABLED"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d47a9329_6b9b77ce","line":752,"updated":"2024-07-09 16:26:54.000000000","message":"`be` should also be declared local","commit_id":"2d3047307abd919bdeda8a42dfc1cb2b4651bf92"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1a294aec4e9ed8deaf60d93503552da776c29724","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    # Expect UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS to be a list of backends"},{"line_number":750,"context_line":"    # similar to CINDER_ENABLED_BACKENDS with NAME:TYPE where NAME will"},{"line_number":751,"context_line":"    # be the backend specific configuration stanza in cinder.conf."},{"line_number":752,"context_line":"    for be in ${UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS//,/ }; do"},{"line_number":753,"context_line":"        local be_name\u003d${be##*:}"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        iniset $CINDER_CONF $be_name image_upload_use_cinder_backend $UPLOAD_VOLUME_OPTIMIZED_ENABLED"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"96a87bcd_a1b5fe46","line":752,"in_reply_to":"d47a9329_6b9b77ce","updated":"2024-07-15 08:47:14.000000000","message":"Done","commit_id":"2d3047307abd919bdeda8a42dfc1cb2b4651bf92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d03b88c11d0c296d7af54861c37a4eff95d4cfb","unresolved":true,"context_lines":[{"line_number":184,"context_line":"CINDER_IMG_CACHE_ENABLED\u003d${CINDER_IMG_CACHE_ENABLED:-True}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Environment variables to configure the optimized volume upload"},{"line_number":187,"context_line":"UPLOAD_VOLUME_OPTIMIZED_ENABLED\u003d${UPLOAD_VOLUME_OPTIMIZED_ENABLED:-False}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Environment variables to configure the internal tenant during optimized volume upload"},{"line_number":190,"context_line":"UPLOAD_VOLUME_INTERNAL_TENANT\u003d${UPLOAD_VOLUME_INTERNAL_TENANT:-False}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"92cd1677_c8ec4a8e","line":187,"updated":"2024-08-08 16:04:13.000000000","message":"Can we use a name with CINDER_ prefix without getting too long? Maybe\nCINDER_UPLOAD_OPTIMIZED?","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"899c05ce596aaf51032979a49a39fa58cb29270a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"CINDER_IMG_CACHE_ENABLED\u003d${CINDER_IMG_CACHE_ENABLED:-True}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Environment variables to configure the optimized volume upload"},{"line_number":187,"context_line":"UPLOAD_VOLUME_OPTIMIZED_ENABLED\u003d${UPLOAD_VOLUME_OPTIMIZED_ENABLED:-False}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Environment variables to configure the internal tenant during optimized volume upload"},{"line_number":190,"context_line":"UPLOAD_VOLUME_INTERNAL_TENANT\u003d${UPLOAD_VOLUME_INTERNAL_TENANT:-False}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"59353393_3202fb48","line":187,"in_reply_to":"92cd1677_c8ec4a8e","updated":"2024-08-13 19:37:48.000000000","message":"Done","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d03b88c11d0c296d7af54861c37a4eff95d4cfb","unresolved":true,"context_lines":[{"line_number":187,"context_line":"UPLOAD_VOLUME_OPTIMIZED_ENABLED\u003d${UPLOAD_VOLUME_OPTIMIZED_ENABLED:-False}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Environment variables to configure the internal tenant during optimized volume upload"},{"line_number":190,"context_line":"UPLOAD_VOLUME_INTERNAL_TENANT\u003d${UPLOAD_VOLUME_INTERNAL_TENANT:-False}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# For limits, if left unset, it will use cinder defaults of 0 for unlimited"},{"line_number":193,"context_line":"CINDER_IMG_CACHE_SIZE_GB\u003d${CINDER_IMG_CACHE_SIZE_GB:-}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d5ab47af_732dd826","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":29},"updated":"2024-08-08 16:04:13.000000000","message":"CINDER_UPLOAD_INTERNAL_TENANT?","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"899c05ce596aaf51032979a49a39fa58cb29270a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"UPLOAD_VOLUME_OPTIMIZED_ENABLED\u003d${UPLOAD_VOLUME_OPTIMIZED_ENABLED:-False}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# Environment variables to configure the internal tenant during optimized volume upload"},{"line_number":190,"context_line":"UPLOAD_VOLUME_INTERNAL_TENANT\u003d${UPLOAD_VOLUME_INTERNAL_TENANT:-False}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# For limits, if left unset, it will use cinder defaults of 0 for unlimited"},{"line_number":193,"context_line":"CINDER_IMG_CACHE_SIZE_GB\u003d${CINDER_IMG_CACHE_SIZE_GB:-}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"faba5d33_f11d07eb","line":190,"range":{"start_line":190,"start_character":0,"end_line":190,"end_character":29},"in_reply_to":"d5ab47af_732dd826","updated":"2024-08-13 19:37:48.000000000","message":"Done","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d03b88c11d0c296d7af54861c37a4eff95d4cfb","unresolved":true,"context_lines":[{"line_number":201,"context_line":"# Configure which cinder backends will have optimized volume upload, this takes the same"},{"line_number":202,"context_line":"# form as the CINDER_ENABLED_BACKENDS config option. By default it will"},{"line_number":203,"context_line":"# enable the cache for all cinder backends."},{"line_number":204,"context_line":"UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS\u003d${UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS:-$CINDER_ENABLED_BACKENDS}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# Flag to set the oslo_policy.enforce_scope. This is used to switch"},{"line_number":207,"context_line":"# the  Volume API policies to start checking the scope of token. by default,"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"092abd00_accfe2f5","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":36},"updated":"2024-08-08 16:04:13.000000000","message":"CINDER_UPLOAD_OPTIMIZED_BACKENDS?","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"899c05ce596aaf51032979a49a39fa58cb29270a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"# Configure which cinder backends will have optimized volume upload, this takes the same"},{"line_number":202,"context_line":"# form as the CINDER_ENABLED_BACKENDS config option. By default it will"},{"line_number":203,"context_line":"# enable the cache for all cinder backends."},{"line_number":204,"context_line":"UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS\u003d${UPLOAD_VOLUME_OPTIMIZED_FOR_BACKENDS:-$CINDER_ENABLED_BACKENDS}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# Flag to set the oslo_policy.enforce_scope. This is used to switch"},{"line_number":207,"context_line":"# the  Volume API policies to start checking the scope of token. by default,"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"763793b2_88016f9d","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":36},"in_reply_to":"092abd00_accfe2f5","updated":"2024-08-13 19:37:48.000000000","message":"Done","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6d03b88c11d0c296d7af54861c37a4eff95d4cfb","unresolved":true,"context_lines":[{"line_number":365,"context_line":"        fi"},{"line_number":366,"context_line":"        configure_cinder_image_volume_cache"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":369,"context_line":"            # Configure optimized volume upload"},{"line_number":370,"context_line":"            configure_cinder_volume_upload"},{"line_number":371,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9b5e33e1_e60fb138","line":368,"updated":"2024-08-08 16:04:13.000000000","message":"Since (at least to me) it is not obvious, why the optimized upload is only being configured in this scenario, adding a bit of context from the commit message as comment here might be helpful for future readers","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"899c05ce596aaf51032979a49a39fa58cb29270a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        fi"},{"line_number":366,"context_line":"        configure_cinder_image_volume_cache"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":369,"context_line":"            # Configure optimized volume upload"},{"line_number":370,"context_line":"            configure_cinder_volume_upload"},{"line_number":371,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"df505a04_0ae72bd0","line":368,"in_reply_to":"9b5e33e1_e60fb138","updated":"2024-08-13 19:37:48.000000000","message":"Done","commit_id":"401ccb820aed9d2dcb43edbdde4f46e799b34e4f"}]}
