)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"55b9d20d27d52d7f8b61f07639e4291ff61dc99d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dcbaff74_ea7780af","updated":"2025-04-25 21:05:55.000000000","message":"Maybe frickler\u0027s suggestion could be a follow up?  This patch has been sitting a long time, and we actually need it to merge for a cinder CI job we want to introduce, https://review.opendev.org/c/openstack/cinder/+/909847","commit_id":"02c3f4218eb7e518974404c1e372626ee55c2353"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"40b31ac010548175b2fd6b494f3299cde33c510b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d12502b_71a57662","updated":"2025-04-25 21:22:56.000000000","message":"OK, I take it back, this has been superseded by https://review.opendev.org/c/openstack/devstack/+/910473 , although it doesn\u0027t do as thorough a job as you do here to set opts in the cinder.conf.  Not sure if all those fields are needed, but you can take a look and maybe refactor this patch along the lines frickler suggests.","commit_id":"02c3f4218eb7e518974404c1e372626ee55c2353"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9ad505d2dd83e5028d821642d89272e5123180c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab1c09f6_40e2c008","updated":"2025-03-28 17:28:05.000000000","message":"maybe avoid adding redundant code right away?","commit_id":"02c3f4218eb7e518974404c1e372626ee55c2353"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c6549a358095a0f4fa5049c3afbcb8ba2cc5b5ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d531c03_37bac991","updated":"2024-04-17 01:26:23.000000000","message":"recheck kernel crash in the instance","commit_id":"02c3f4218eb7e518974404c1e372626ee55c2353"}],"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9ad505d2dd83e5028d821642d89272e5123180c1","unresolved":true,"context_lines":[{"line_number":829,"context_line":"        --user-domain $SERVICE_DOMAIN_NAME --system all reader"},{"line_number":830,"context_line":"}"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"function init_nova_service_user_conf {"},{"line_number":833,"context_line":"    iniset $NOVA_CONF service_user send_service_user_token True"},{"line_number":834,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":835,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_URI\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a527150b_7fdb5b05","line":832,"updated":"2025-03-28 17:28:05.000000000","message":"I think it would make sense to move this to a global function taking config_filename and service_username as parameters that could then be used from nova and cinder and optionally other services later","commit_id":"02c3f4218eb7e518974404c1e372626ee55c2353"}]}