)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9e17e6c030578bf464a8b386bc20c18c2bbdd43","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-19 12:34:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lib/apache: Pass name, not path, to write_uwsgi_conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027d like to move from configuring uWSGI with \u0027.wsgi\u0027 files to"},{"line_number":10,"context_line":"configuring with module paths. Do this for all in-tree services and log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f5653a7_7fde6cf2","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":52},"updated":"2024-04-24 07:49:58.000000000","message":"remove_uwsgi_config is what this patch changes","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2371107d4a23625b68b67f4cee6f5f72f3892f33","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-19 12:34:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lib/apache: Pass name, not path, to write_uwsgi_conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027d like to move from configuring uWSGI with \u0027.wsgi\u0027 files to"},{"line_number":10,"context_line":"configuring with module paths. Do this for all in-tree services and log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2785ea59_cebbc315","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":52},"in_reply_to":"5f5653a7_7fde6cf2","updated":"2024-05-14 13:09:48.000000000","message":"Done","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ab2def5e74584ba50a0fccfe077edbcbb181973b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"83e9721c_7b91c108","updated":"2024-04-24 07:15:00.000000000","message":"lgtm","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2f0591d02efebe6e8a99c93aede824410d0442a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76c02644_96bc3cfb","updated":"2024-05-16 12:17:48.000000000","message":"lgtm","commit_id":"d5182ce3fcf5caf8f7dca84217b2c3cb70993df7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6ff99f3d433641bb0f2ec391c906717cc6b79694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19355b95_0729a865","updated":"2024-05-16 11:50:32.000000000","message":"lgtm, thx","commit_id":"d5182ce3fcf5caf8f7dca84217b2c3cb70993df7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"90e9dab974c3cca17b2a7fe3eb946da72dce376c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2abb61a3_4d0c1b0d","updated":"2024-05-15 09:48:32.000000000","message":"recheck nova-ceph-multistore failed on test_volume_boot_pattern with \"cat: can\u0027t open \u0027/tmp/timestamp\u0027: No such file or directory\"","commit_id":"d5182ce3fcf5caf8f7dca84217b2c3cb70993df7"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8ad840901dbc0b05e06b503392e8976df0eded97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a8a2e2d_0dd9b00c","updated":"2024-05-15 12:31:51.000000000","message":"recheck nova-ceph-multistore timed out","commit_id":"d5182ce3fcf5caf8f7dca84217b2c3cb70993df7"}],"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9e17e6c030578bf464a8b386bc20c18c2bbdd43","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    stop_process \"n-api\""},{"line_number":250,"context_line":"    stop_process \"n-api-meta\""},{"line_number":251,"context_line":"    remove_uwsgi_config \"$NOVA_UWSGI_CONF\" \"nova-api-uwsgi\""},{"line_number":252,"context_line":"    remove_uwsgi_config \"$NOVA_METADATA_UWSGI_CONF\" \"nova-metadata-wsgi\""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    if [[ \"$NOVA_BACKEND\" \u003d\u003d \"LVM\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bc943316_3bd4f7c4","line":251,"range":{"start_line":251,"start_character":44,"end_line":251,"end_character":58},"updated":"2024-04-24 07:49:58.000000000","message":"This seems inconsistent, see below","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2371107d4a23625b68b67f4cee6f5f72f3892f33","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    stop_process \"n-api\""},{"line_number":250,"context_line":"    stop_process \"n-api-meta\""},{"line_number":251,"context_line":"    remove_uwsgi_config \"$NOVA_UWSGI_CONF\" \"nova-api-uwsgi\""},{"line_number":252,"context_line":"    remove_uwsgi_config \"$NOVA_METADATA_UWSGI_CONF\" \"nova-metadata-wsgi\""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    if [[ \"$NOVA_BACKEND\" \u003d\u003d \"LVM\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e09000a2_b7f89901","line":251,"range":{"start_line":251,"start_character":44,"end_line":251,"end_character":58},"in_reply_to":"bc943316_3bd4f7c4","updated":"2024-05-14 13:09:48.000000000","message":"Acknowledged","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9e17e6c030578bf464a8b386bc20c18c2bbdd43","unresolved":true,"context_lines":[{"line_number":549,"context_line":"    iniset $NOVA_CONF upgrade_levels compute \"auto\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    if is_service_enabled n-api; then"},{"line_number":552,"context_line":"        write_uwsgi_config \"$NOVA_UWSGI_CONF\" \"$NOVA_UWSGI\" \"/compute\" \"\" \"nova-api\""},{"line_number":553,"context_line":"    fi"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    if is_service_enabled n-api-meta; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c6d45e6e_00f76d74","line":552,"updated":"2024-04-24 07:49:58.000000000","message":"Here you are using only \"nova-api\" as name","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2371107d4a23625b68b67f4cee6f5f72f3892f33","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    iniset $NOVA_CONF upgrade_levels compute \"auto\""},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    if is_service_enabled n-api; then"},{"line_number":552,"context_line":"        write_uwsgi_config \"$NOVA_UWSGI_CONF\" \"$NOVA_UWSGI\" \"/compute\" \"\" \"nova-api\""},{"line_number":553,"context_line":"    fi"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    if is_service_enabled n-api-meta; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"83d135b4_09527fb4","line":552,"in_reply_to":"c6d45e6e_00f76d74","updated":"2024-05-14 13:09:48.000000000","message":"Whoops, this is a mistake introduced in the previous patch (I057dc635c01e54740ee04dfe7b39ef83db5dc180). Nothing seems to have broken so let\u0027s stick with the new shorter name","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"}],"lib/placement":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d9e17e6c030578bf464a8b386bc20c18c2bbdd43","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    create_placement_conf"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    if [[ \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":116,"context_line":"        write_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\" \"/placement\""},{"line_number":117,"context_line":"    else"},{"line_number":118,"context_line":"        _config_placement_apache_wsgi"},{"line_number":119,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0e2a2ebd_6e5b4a45","line":116,"updated":"2024-04-24 07:49:58.000000000","message":"Maybe switch this to the new style before deprecating it?","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"87a42bfba794e7ff9577b5bb21cc0e3f188d294b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    create_placement_conf"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    if [[ \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":116,"context_line":"        write_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\" \"/placement\""},{"line_number":117,"context_line":"    else"},{"line_number":118,"context_line":"        _config_placement_apache_wsgi"},{"line_number":119,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"98f26f8e_75d3428d","line":116,"in_reply_to":"0e2a2ebd_6e5b4a45","updated":"2024-05-14 13:15:28.000000000","message":"Sure. Separate change though (as you note we\u0027re changing `remove_uwsgi_config` here)","commit_id":"afddbcafc659bfa63b9b13505754ce13494acbc7"}]}