)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"96b68f295b57b44a1d77503251a2b7e1e1affa22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd6d5683_fbecc233","updated":"2024-05-01 18:38:07.000000000","message":"Hi Takashi, thank you so much for your feedback. I\u0027ve uploaded patch 2, please take a look.","commit_id":"5947ba1775adec54303e2d540d68d9b8f2325ffa"},{"author":{"_account_id":35378,"name":"Sang Tran","email":"SangTQ8@fpt.com","username":"sang.tran"},"change_message_id":"a4143158b7b1ed77afc42262a18e7f6bbf271711","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f68acd92_c9f2ddc1","updated":"2024-05-03 17:43:06.000000000","message":"LGTM","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"a317f680efbc61f723dd1151b8931878353f61b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"26c833bc_cdf51a1e","updated":"2024-05-04 02:29:35.000000000","message":"Nice","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"109c32fea75893d81fda214105170fa4be610f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2300c0ab_3261f527","updated":"2024-05-22 07:16:04.000000000","message":"lgtm","commit_id":"6971ccc49ad97216d97be46c70c241c5473aff92"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"646809ee77dad77a632c5d3448341e01406070a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1684ea28_9f819297","updated":"2024-05-22 08:57:09.000000000","message":"recheck fail tempest-full-py3","commit_id":"6971ccc49ad97216d97be46c70c241c5473aff92"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca194c973c579856a3ffc9479f4474e029b4d8c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a3d0820b_69d57f46","updated":"2024-05-16 04:39:49.000000000","message":"thank you","commit_id":"6971ccc49ad97216d97be46c70c241c5473aff92"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"ddb95ee83231b6027f822c8b2131308341c23209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8eb846d_c35cfd8e","in_reply_to":"a3d0820b_69d57f46","updated":"2024-05-19 15:37:25.000000000","message":"Thank you sir. Is this patch now ready to be merged or does it need any further adjustment?","commit_id":"6971ccc49ad97216d97be46c70c241c5473aff92"}],"lib/horizon":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"77bc38ca97b979a8471bacbdbabaf1affb81c9d1","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"\t    _horizon_config_set $local_settings \"\" OPENSTACK_CINDER_FEATURES \"{\u0027enable_backup\u0027: True}\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"92686ab3_70d40111","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":24},"updated":"2024-05-01 15:25:24.000000000","message":"According to the implementation of _horizon_config_set, I think you can try `_horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\"`","commit_id":"93570b39f8a157a70d1de839c4575be4ced3b1d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"77bc38ca97b979a8471bacbdbabaf1affb81c9d1","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"\t    _horizon_config_set $local_settings \"\" OPENSTACK_CINDER_FEATURES \"{\u0027enable_backup\u0027: True}\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fdd3be68_0085fdc4","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":1},"updated":"2024-05-01 15:25:24.000000000","message":"tab here needs to be replaced by spaces.","commit_id":"93570b39f8a157a70d1de839c4575be4ced3b1d9"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"96b68f295b57b44a1d77503251a2b7e1e1affa22","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"\t    _horizon_config_set $local_settings \"\" OPENSTACK_CINDER_FEATURES \"{\u0027enable_backup\u0027: True}\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"42125ddc_83c30755","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":24},"in_reply_to":"92686ab3_70d40111","updated":"2024-05-01 18:38:07.000000000","message":"Done","commit_id":"93570b39f8a157a70d1de839c4575be4ced3b1d9"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"96b68f295b57b44a1d77503251a2b7e1e1affa22","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"\t    _horizon_config_set $local_settings \"\" OPENSTACK_CINDER_FEATURES \"{\u0027enable_backup\u0027: True}\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c0121ef5_0d567f6d","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":1},"in_reply_to":"fdd3be68_0085fdc4","updated":"2024-05-01 18:38:07.000000000","message":"Done","commit_id":"93570b39f8a157a70d1de839c4575be4ced3b1d9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d43e8d00029fd3b1315498da0162086e5e121111","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"6f6fb0f6_1689ab4d","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"updated":"2024-05-13 09:09:35.000000000","message":"IMHO this extra option is not needed, if the c-bak service is there, we can tell horizon about it, or is there a scenario where this would be not wanted?","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"9920574d97fd4d3441c17185537e4d8057c93f7d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"306e2f72_d1541f13","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"in_reply_to":"3aa05402_bb5e9c19","updated":"2024-05-15 17:42:32.000000000","message":"I got your idea. I\u0027ve updated patchset 6. Please take a look. Thank you so much!","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"9739ba3787f53e1f49b43d20289969237c007067","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a36877e_46f8a7e0","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"in_reply_to":"596aea05_2705d4d2","updated":"2024-05-14 16:52:56.000000000","message":"The fact that this option is not used anywhere because I add it. 😄 Basically if a user specify this opt in local.conf, the code read it and execute the logic. By default, it does not need to appear anywhere else (in stackrc for example).","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d67806e647f9d8b94016d2456a9eb3ecdcb2cad6","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aa05402_bb5e9c19","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"in_reply_to":"5a36877e_46f8a7e0","updated":"2024-05-15 11:37:22.000000000","message":"Yes, we are arguing that this variable isn\u0027t needed, not that your patch is not needed at all. This line could simply be:\n\n```\nif is_service_enabled c-bak; then\n```","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaa11dc1815f5ee02db283a0f54b1328e9672dde","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"d5d50d3b_d9965076","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"in_reply_to":"6f6fb0f6_1689ab4d","updated":"2024-05-14 15:08:39.000000000","message":"it\u0027s not used anywhere - https://codesearch.openstack.org/?q\u003dENABLE_BACKUP_DASHBOARD\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nfrickler has a good point","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"e77857e22fc3a1ea6f694d41416f97308e2f4a60","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        _horizon_config_set $local_settings \"\" OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \"True\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ $ENABLE_BACKUP_DASHBOARD \u003d\u003d \"True\" ]]; then"},{"line_number":113,"context_line":"        _horizon_config_set $local_settings OPENSTACK_CINDER_FEATURES enable_backup \"True\""},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"596aea05_2705d4d2","line":112,"range":{"start_line":112,"start_character":35,"end_line":112,"end_character":75},"in_reply_to":"d5d50d3b_d9965076","updated":"2024-05-14 16:23:21.000000000","message":"When I install devstack with cinder backup enabled, after the installation completes, I go check the Horizon and the backup tab (expected to be seen right under \"Volume\") is not there. \nIt is true that cinder backup is still there, but no display section for it by default on Horizon, so normally it have go to horizon local setting.py and set the OPENSTACK_CINDER_FEATURES to enable_backup then restart horizon.\n\nSo I think this patch can help avoid another manual step to show cinder backup on Horizon.\n\nI don\u0027t know any other ways I can enable it. Please let me what you think. Thank you so much!","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"}],"releasenotes/notes/add-option-enable-backup-dashboard-71d95ad5f836a2e3.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d43e8d00029fd3b1315498da0162086e5e121111","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option to show backup dashboard on Horizon when enable service"},{"line_number":5,"context_line":"    c-bak by defining variable ENABLE_BACKUP_DASHBOARD\u003dTrue in local.conf."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b263ccb_7fbf39c2","line":5,"updated":"2024-05-13 09:09:35.000000000","message":"Devstack doesn\u0027t do release notes. The one that is in place currently was created in error, see https://review.opendev.org/c/openstack/devstack/+/919485\n\nSo please drop this, the referenced bug report is good enough","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aaa11dc1815f5ee02db283a0f54b1328e9672dde","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option to show backup dashboard on Horizon when enable service"},{"line_number":5,"context_line":"    c-bak by defining variable ENABLE_BACKUP_DASHBOARD\u003dTrue in local.conf."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"95cbbaab_bc1b3195","line":5,"in_reply_to":"1b263ccb_7fbf39c2","updated":"2024-05-14 15:08:39.000000000","message":"+1","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"9920574d97fd4d3441c17185537e4d8057c93f7d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option to show backup dashboard on Horizon when enable service"},{"line_number":5,"context_line":"    c-bak by defining variable ENABLE_BACKUP_DASHBOARD\u003dTrue in local.conf."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"09b9dde0_7eb4f0e4","line":5,"in_reply_to":"4d0c4fed_cb36254a","updated":"2024-05-15 17:42:32.000000000","message":"Done","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"},{"author":{"_account_id":36898,"name":"Nguyen Luu Hoang Minh","display_name":"Minh Nguyen","email":"minh.nlh.work@gmail.com","username":"MinhNLH2"},"change_message_id":"518f4d460699c3bcb8a5303a6cef3bc3f3ecb04d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option to show backup dashboard on Horizon when enable service"},{"line_number":5,"context_line":"    c-bak by defining variable ENABLE_BACKUP_DASHBOARD\u003dTrue in local.conf."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4d0c4fed_cb36254a","line":5,"in_reply_to":"95cbbaab_bc1b3195","updated":"2024-05-14 16:28:48.000000000","message":"+1. I will drop it in my next patch.","commit_id":"59f5acfc6ff8e37ef2d08bcaabeaab3335953229"}]}