)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"951d64cc576fbb8744401a71e29bbfeb7acd88f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"685689ca_7bbb1b35","updated":"2024-07-19 09:09:02.000000000","message":"who would set rpc_workers\u003d0 in this scenario and why?\n\nIMO the solution looks pretty hacky, maybe instead we can not automatically do `enable_service neutron-rpc-server` and rely on consumers to do it when needed?","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7c055a3b6d685fc96595b689c07dc20a2ec6424f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5e42fb2_063713f0","in_reply_to":"0c1d8d3e_39c30dee","updated":"2024-07-21 22:57:12.000000000","message":"makes sense to me, if the dependency is not met, the service can\u0027t be deployed as it would fail so let\u0027s not deploy it","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c0aecc68cdb85e5b2f6c4196573b0867041b1ae1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6768ba41_469c5ec8","in_reply_to":"29f3d3cd_076a1942","updated":"2024-07-19 09:29:55.000000000","message":"IMO the concept of devstack is to explicitly enable/disable services by configuration, not have some custom logic that automates this, and I would like to keep things that way. Will defer for other reviewer\u0027s opinion though","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d4959ac8572899ebae6129e89092c687a1bd361","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c1d8d3e_39c30dee","in_reply_to":"6768ba41_469c5ec8","updated":"2024-07-19 09:56:04.000000000","message":"If that is the case, I\u0027ll propose this change. But this service should also depend on the configuration value. If rpc_workers\u003d0, the service cannot be executed or it will fail.","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"473c0406ce10d6c193e05b6c95c1754a70f30eca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29f3d3cd_076a1942","in_reply_to":"685689ca_7bbb1b35","updated":"2024-07-19 09:16:37.000000000","message":"In ML2/OVN, without any other ML2 driver, for example SR-IOV, that requires agents with RPC communication, there is no need for RPC workers. The OVN metadata agent, that is the only agent deployed by Neutron and located in the compute nodes, access directly to the OVN SB database.\n\nWe should not allow to enable/disable the service itself but rely on the configuration parameter (rpc_workers). The RPC workers service will run along with the WSGI API processes, in the same node (controller). But if we explicitly set rpc_workers\u003d0, then the service will fail (as seen in the CI [1][2]).\n\n[1]https://review.opendev.org/c/openstack/neutron/+/924317?tab\u003dchange-view-tab-header-zuul-results-summary\n[2]For example: https://zuul.opendev.org/t/openstack/build/35384da95f5c4fe8ba754c06999aecc1 (note that this job has rpc_workers\u003d0 explicitly defined)","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7ccba9afa2668d6ee58131e58ca23fa0b1945589","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"018eae1c_72ae184e","updated":"2024-07-22 08:22:46.000000000","message":"looks ok","commit_id":"aaaa03718bdc05df197708f9354e985936f96853"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7c055a3b6d685fc96595b689c07dc20a2ec6424f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"976c386e_4baeb431","updated":"2024-07-21 22:57:12.000000000","message":"makes sense to me","commit_id":"aaaa03718bdc05df197708f9354e985936f96853"}],"lib/neutron":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"464587eb8f243bb2680e7a3559c1eadeefa47f15","unresolved":true,"context_lines":[{"line_number":665,"context_line":"        enable_service neutron-periodic-workers"},{"line_number":666,"context_line":"        _enable_ovn_maintenance"},{"line_number":667,"context_line":"        if [[ \"$_Q_RUN_RPC_WORKERS\" \u003d True ]]; then"},{"line_number":668,"context_line":"            run_process neutron-rpc-server \"$NEUTRON_BIN_DIR/neutron-rpc-server $cfg_file_options\"\\"},{"line_number":669,"context_line":"        fi"},{"line_number":670,"context_line":"        run_process neutron-periodic-workers \"$NEUTRON_BIN_DIR/neutron-periodic-workers $cfg_file_options\""},{"line_number":671,"context_line":"        _run_ovn_maintenance"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b7d2f646_33eac2a6","line":668,"range":{"start_line":668,"start_character":98,"end_line":668,"end_character":99},"updated":"2024-07-19 09:31:17.000000000","message":"the syntax error below is actually caused by this","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"438acd438625642d60bc35d04d885cb4be7c092d","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        enable_service neutron-periodic-workers"},{"line_number":666,"context_line":"        _enable_ovn_maintenance"},{"line_number":667,"context_line":"        if [[ \"$_Q_RUN_RPC_WORKERS\" \u003d True ]]; then"},{"line_number":668,"context_line":"            run_process neutron-rpc-server \"$NEUTRON_BIN_DIR/neutron-rpc-server $cfg_file_options\"\\"},{"line_number":669,"context_line":"        fi"},{"line_number":670,"context_line":"        run_process neutron-periodic-workers \"$NEUTRON_BIN_DIR/neutron-periodic-workers $cfg_file_options\""},{"line_number":671,"context_line":"        _run_ovn_maintenance"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4af8505f_bba21d5d","line":668,"range":{"start_line":668,"start_character":98,"end_line":668,"end_character":99},"in_reply_to":"b7d2f646_33eac2a6","updated":"2024-07-19 11:04:30.000000000","message":"Done","commit_id":"bd33bc8564a04c5b43040ec156d5c72802eb2428"}]}