)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d078b7dcf4a4fbb270525ca15034f94909be92bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8e0c641_86aedf63","updated":"2024-08-07 19:36:52.000000000","message":"I will push an update since Rodolfo is on PTO and we want and try to land this sooner than later.","commit_id":"0ad02fa16943a9d09127412c5e8592f1ef5eb5c8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c6fc51a9046924532ad23694cf0f196d6ca71273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8c76e04_35a6b00e","updated":"2024-08-05 09:19:09.000000000","message":"Looks ok","commit_id":"0ad02fa16943a9d09127412c5e8592f1ef5eb5c8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8a07b3564e25d341c641c560689c950b1ff37406","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de563ce8_a9da491f","updated":"2024-08-20 15:08:55.000000000","message":"lgtm, thanks","commit_id":"79a812a69e4015f6c911aa54989970e35bfc241f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1342a7e6a6bf15e90ad30de159a1f01e96a97e04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"470dcbff_ef13a424","updated":"2024-08-08 06:42:25.000000000","message":"thx. does this need further testing on some neutron jobs?","commit_id":"79a812a69e4015f6c911aa54989970e35bfc241f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"634997f4aa208444889d0ad3a397cbb58ef8d201","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79708184_18c92525","in_reply_to":"32142b26_4b217094","updated":"2024-08-19 12:49:51.000000000","message":"This is now working. For example: https://zuul.opendev.org/t/openstack/build/b09a155b9ac24a4b87eba45103e60f8d. This job is using Neutron WSGI module and no RPC workers.","commit_id":"79a812a69e4015f6c911aa54989970e35bfc241f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c7521d8edf2ca895cc9ee9bb795591173d3e4dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae754724_c64bc899","in_reply_to":"470dcbff_ef13a424","updated":"2024-08-08 14:42:54.000000000","message":"This neutron patch was testing the previous version, I can update the depends-on, but it\u0027s broken due to another neutron patch that\u0027s still in-progress.\n\nhttps://review.opendev.org/c/openstack/neutron/+/924317","commit_id":"79a812a69e4015f6c911aa54989970e35bfc241f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5dc285dc12d8cef92b723bf8cb60cfccade10fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32142b26_4b217094","in_reply_to":"ae754724_c64bc899","updated":"2024-08-19 07:15:02.000000000","message":"I\u0027ve updated https://review.opendev.org/c/openstack/neutron/+/924317. CI results will be in 2 hours.","commit_id":"79a812a69e4015f6c911aa54989970e35bfc241f"}],"lib/neutron":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7535eb834aad45eab0338cc9ea072ce29e608eff","unresolved":true,"context_lines":[{"line_number":657,"context_line":"    rpc_workers\u003d$(iniget_multiline $NEUTRON_CONF DEFAULT rpc_workers)"},{"line_number":658,"context_line":"    if [ \"$rpc_workers\" \u003d\u003d \"0\" ]; then"},{"line_number":659,"context_line":"        _Q_RUN_RPC_SERVER\u003dFalse"},{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # Start the Neutron service"},{"line_number":663,"context_line":"    if [ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7d675007_0ccd79ff","line":660,"updated":"2024-08-07 09:13:02.000000000","message":"why not move this into the `if ... then` block below, it isn\u0027t needed in the `else` case and also nowhere else.\n\nyou can also stop setting `_Q_RUN_RPC_SERVER` and replace the `\"$_Q_RUN_RPC_SERVER\" \u003d True` checks by `\"$rpc_workers\" \u003d\u003d \"0\"`","commit_id":"0ad02fa16943a9d09127412c5e8592f1ef5eb5c8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64797acb68ef2e741d4e1875ee501aa522e4deac","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    rpc_workers\u003d$(iniget_multiline $NEUTRON_CONF DEFAULT rpc_workers)"},{"line_number":658,"context_line":"    if [ \"$rpc_workers\" \u003d\u003d \"0\" ]; then"},{"line_number":659,"context_line":"        _Q_RUN_RPC_SERVER\u003dFalse"},{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # Start the Neutron service"},{"line_number":663,"context_line":"    if [ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8df16154_b4a0cedc","line":660,"in_reply_to":"411859e3_e2c4947b","updated":"2024-08-07 22:07:25.000000000","message":"Done","commit_id":"0ad02fa16943a9d09127412c5e8592f1ef5eb5c8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d078b7dcf4a4fbb270525ca15034f94909be92bf","unresolved":true,"context_lines":[{"line_number":657,"context_line":"    rpc_workers\u003d$(iniget_multiline $NEUTRON_CONF DEFAULT rpc_workers)"},{"line_number":658,"context_line":"    if [ \"$rpc_workers\" \u003d\u003d \"0\" ]; then"},{"line_number":659,"context_line":"        _Q_RUN_RPC_SERVER\u003dFalse"},{"line_number":660,"context_line":"    fi"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    # Start the Neutron service"},{"line_number":663,"context_line":"    if [ \"$NEUTRON_DEPLOY_MOD_WSGI\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"411859e3_e2c4947b","line":660,"in_reply_to":"7d675007_0ccd79ff","updated":"2024-08-07 19:36:52.000000000","message":"I assume you meant !\u003d 0 there :)","commit_id":"0ad02fa16943a9d09127412c5e8592f1ef5eb5c8"}]}