)]}'
{".zuul.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89ef7cf04868c16c6fef084acf2c68c432538c15","unresolved":true,"context_lines":[{"line_number":510,"context_line":"      - opendev.org/openstack/nova"},{"line_number":511,"context_line":"      - opendev.org/openstack/placement"},{"line_number":512,"context_line":"      - opendev.org/openstack/swift"},{"line_number":513,"context_line":"      - opendev.org/openstack/os-test-images"},{"line_number":514,"context_line":"    timeout: 7200"},{"line_number":515,"context_line":"    vars:"},{"line_number":516,"context_line":"      # based on observation of the integrated gate"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a79896ac_87bb2cec","line":513,"updated":"2024-08-12 15:54:30.000000000","message":"I wonder if this will be needed or used anywhere outside of tempest jobs. if it is only for tempest, maybe better only add this as required for the tempest job definitions in `tempest/zuul.d/base.yaml`?\n\nalso can we please keep this list sorted?","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c218f696278b229eeff09b9ee265419b21aa99d1","unresolved":true,"context_lines":[{"line_number":510,"context_line":"      - opendev.org/openstack/nova"},{"line_number":511,"context_line":"      - opendev.org/openstack/placement"},{"line_number":512,"context_line":"      - opendev.org/openstack/swift"},{"line_number":513,"context_line":"      - opendev.org/openstack/os-test-images"},{"line_number":514,"context_line":"    timeout: 7200"},{"line_number":515,"context_line":"    vars:"},{"line_number":516,"context_line":"      # based on observation of the integrated gate"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ca6de83_3c977a17","line":513,"in_reply_to":"a79896ac_87bb2cec","updated":"2024-08-12 18:11:18.000000000","message":"It\u0027s useful outside of tempest for devstack (i.e. locally), but I guess your point is that we\u0027ll clone this repo for devstack-only jobs. I guess I\u0027m not sure what the impact of that is really, but perhaps this is just a \"contextual purity\" concern?\n\nAre you suggesting that this go to on `devstack-tempest` instead of `devstack`?\n\nI wouldn\u0027t rule out some jobs that just do some tests against the services with openstackclient and not tempest, but based on the way it\u0027s implemented right now maybe that makes sense.\n\nAre we to assume that any job that enables tempest must inherit from `devstack-tempest`?","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9eb2b304be72a5e01d91b6b8a81dee1b1cf9f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c5316dcc_52d96910","updated":"2024-08-09 00:26:41.000000000","message":"It is tested in https://review.opendev.org/c/openstack/tempest/+/925431\n\nDevstack generating all the 15 images \n\n- https://opendev.org/openstack/os-test-images/src/branch/master/manifest.yaml\n\n- https://zuul.opendev.org/t/openstack/build/c8bb9add437d4c7d817e183232ec69ff/log/controller/logs/devstacklog.txt#20716-20742\n\n15 tests are generated correctly and passing\n- https://zuul.opendev.org/t/openstack/build/c8bb9add437d4c7d817e183232ec69ff/log/job-output.txt#24512-24526","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ea667709934e8f51ce80d7df5503282703a4121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"becdab11_4f11f23b","updated":"2024-08-02 13:49:57.000000000","message":"recheck unrelated failure","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c218f696278b229eeff09b9ee265419b21aa99d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2478a02a_230c0bbd","updated":"2024-08-12 18:11:18.000000000","message":"This and three tempest patches are behind this in the gate. I\u0027ll follow-up after it merges, or revise if it gets kicked out.","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8acbf10780a2a703cb855f448259041d5dc83756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f1c7170_a8381f1c","updated":"2024-08-09 17:16:35.000000000","message":"lgtm","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"}],"lib/tempest":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9eb2b304be72a5e01d91b6b8a81dee1b1cf9f11","unresolved":true,"context_lines":[{"line_number":106,"context_line":"TEMPEST_FLAVOR_ALT_RAM\u003d${TEMPEST_FLAVOR_ALT_RAM:-256}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7947fc2d_e75b2438","line":109,"range":{"start_line":109,"start_character":44,"end_line":109,"end_character":57},"updated":"2024-08-09 00:26:41.000000000","message":"Are you going to branch os-test-images ? if not then you should use the BRANCHLESS_TARGET_BRANCH here, which we keep as \u0027master\u0027 on stable branches also (used for branchless Tempest).\n\nIf not decided yet, we can change it later also.","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c218f696278b229eeff09b9ee265419b21aa99d1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"TEMPEST_FLAVOR_ALT_RAM\u003d${TEMPEST_FLAVOR_ALT_RAM:-256}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"59e8aacf_53ecadb8","line":109,"range":{"start_line":109,"start_character":44,"end_line":109,"end_character":57},"in_reply_to":"1455542a_74c8d903","updated":"2024-08-12 18:11:18.000000000","message":"Done","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"678255e347cd6e2c4fbd6b3e5ca7bf4319945a40","unresolved":true,"context_lines":[{"line_number":106,"context_line":"TEMPEST_FLAVOR_ALT_RAM\u003d${TEMPEST_FLAVOR_ALT_RAM:-256}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"c6d83067_67c6e9fd","line":109,"range":{"start_line":109,"start_character":44,"end_line":109,"end_character":57},"in_reply_to":"7947fc2d_e75b2438","updated":"2024-08-09 13:51:19.000000000","message":"I was hoping not to have to do any of that stuff for it. I definitely want to always have all the images available. Meaning, just because we didn\u0027t test some scenario against 2023.1 doesn\u0027t mean we don\u0027t need to *start* testing it once we realize there\u0027s a bug. For some benign formats, usable\u003dFalse might indicate \"this was not supported back then\" but I think I\u0027d rather handle that elsewhere. Like, I would not want to indicate that some image format is \"safe\" in 2023.1 because we didn\u0027t start testing for that issue until 2023.2. Anything in here that indicates a problem probably means a backport is required.\n\nSo, my gut tells me branchless. Sound reasonable?","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8acbf10780a2a703cb855f448259041d5dc83756","unresolved":true,"context_lines":[{"line_number":106,"context_line":"TEMPEST_FLAVOR_ALT_RAM\u003d${TEMPEST_FLAVOR_ALT_RAM:-256}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1455542a_74c8d903","line":109,"range":{"start_line":109,"start_character":44,"end_line":109,"end_character":57},"in_reply_to":"c6d83067_67c6e9fd","updated":"2024-08-09 17:16:35.000000000","message":"yeah. if we endup doing branch we can change it here but your explanation make sense for branchless.","commit_id":"a49afd0d71c26832f36a6ce302e7ce5cd5005f30"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89ef7cf04868c16c6fef084acf2c68c432538c15","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"},{"line_number":113,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3cd75715_e2214a91","line":110,"updated":"2024-08-12 15:54:30.000000000","message":"this block should be in stackrc in the \"Testing Components\" section","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c218f696278b229eeff09b9ee265419b21aa99d1","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"OSTESTIMAGES_REPO\u003d${OSTESTIMAGES_REPO:-${GIT_BASE}/openstack/os-test-images.git}"},{"line_number":109,"context_line":"OSTESTIMAGES_BRANCH\u003d${OSTESTIMAGES_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":110,"context_line":"OSTESTIMAGES_DIR\u003d${DEST}/os-test-images"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Functions"},{"line_number":113,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"a066a1af_d449da43","line":110,"in_reply_to":"3cd75715_e2214a91","updated":"2024-08-12 18:11:18.000000000","message":"Acknowledged","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"89ef7cf04868c16c6fef084acf2c68c432538c15","unresolved":true,"context_lines":[{"line_number":369,"context_line":"        iniset $TEMPEST_CONFIG image images_manifest_file ${OSTESTIMAGES_DIR}/images/manifest.yaml"},{"line_number":370,"context_line":"        local image_conversion"},{"line_number":371,"context_line":"        image_conversion\u003d$(iniget $GLANCE_IMAGE_IMPORT_CONF image_conversion output_format)"},{"line_number":372,"context_line":"        if [[ \"$image_conversion\" ]]; then"},{"line_number":373,"context_line":"            iniset $TEMPEST_CONFIG image-feature-enabled image_conversion True"},{"line_number":374,"context_line":"        fi"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"64860ac0_7c838fb2","line":372,"updated":"2024-08-12 15:54:30.000000000","message":"Please use `-n` for readability","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c218f696278b229eeff09b9ee265419b21aa99d1","unresolved":true,"context_lines":[{"line_number":369,"context_line":"        iniset $TEMPEST_CONFIG image images_manifest_file ${OSTESTIMAGES_DIR}/images/manifest.yaml"},{"line_number":370,"context_line":"        local image_conversion"},{"line_number":371,"context_line":"        image_conversion\u003d$(iniget $GLANCE_IMAGE_IMPORT_CONF image_conversion output_format)"},{"line_number":372,"context_line":"        if [[ \"$image_conversion\" ]]; then"},{"line_number":373,"context_line":"            iniset $TEMPEST_CONFIG image-feature-enabled image_conversion True"},{"line_number":374,"context_line":"        fi"},{"line_number":375,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"864798e2_eb0e2ada","line":372,"in_reply_to":"64860ac0_7c838fb2","updated":"2024-08-12 18:11:18.000000000","message":"It\u0027s not more readable to me (`-n` makes me think \"nonzero\") and the docs for test show:\n```\n       -n STRING\n              the length of STRING is nonzero\n\n       STRING equivalent to -n STRING\n```\nBut, I see several uses of `-n` below, and even some `! -z` (which I assume is for reasons similar to above), so I\u0027ll change it.","commit_id":"84ce1984b1f0639025af599b426019a4b140fcb4"}]}