)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc7ac8263ebbf78fb7ceaaf44247af26a81adafe","unresolved":true,"context_lines":[{"line_number":14,"context_line":"debugging more difficult when developing with DevStack."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This adds a DevStack variable for log color which defaults to True"},{"line_number":17,"context_line":"to color logs by default."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: If10aada573eb4360e81585d4fb7e5d97f15bc52b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"792602c9_fd0a1de4","line":17,"updated":"2024-08-05 08:04:15.000000000","message":"This sentence no longer matches the current PS","commit_id":"76d967626fd7d108e5738cc24abc2db6d62cc713"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76bc4883c97d934533cee7d309a6da2c29f4f18c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b10801a6_054d6940","updated":"2024-08-02 06:51:22.000000000","message":"I\u0027m wondering whether this really needs a new variable or whether we could simply extend the scope of the LOG_COLOR variable that currently controls output from devstack itself","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dd4821a959b077ba39b14565fa5c08e168a6e1cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e5447e3_3e545e99","in_reply_to":"b10801a6_054d6940","updated":"2024-08-02 20:44:51.000000000","message":"Oh yeah, I think it would make more sense to control it with LOG_COLOR. That way if someone says LOG_COLOR\u003dfalse they won\u0027t get surprise oslo.log color that they probably didn\u0027t want.","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc7ac8263ebbf78fb7ceaaf44247af26a81adafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02fdb89d_03cd376a","updated":"2024-08-05 08:04:15.000000000","message":"thx for the update, can you please update the commit message accordingly?","commit_id":"76d967626fd7d108e5738cc24abc2db6d62cc713"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5f0e30b5a146c5968478736cadd618a1c61db13c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31c924b0_1e9696af","updated":"2024-08-08 05:19:17.000000000","message":"thx. single-approving since it seems low risk","commit_id":"38dea33fe9a5e6bef39566295cc8d05fb1d88223"}],"functions":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76bc4883c97d934533cee7d309a6da2c29f4f18c","unresolved":true,"context_lines":[{"line_number":680,"context_line":"# setup_standard_logging_identity. Since we always run with systemd now,"},{"line_number":681,"context_line":"# this could be cleaned up, but the other functions may still be in use"},{"line_number":682,"context_line":"# by plugins. Since deprecations haven\u0027t worked in the past, we\u0027ll just"},{"line_number":683,"context_line":"# leave them in place."},{"line_number":684,"context_line":"function setup_logging {"},{"line_number":685,"context_line":"    setup_systemd_logging $1"},{"line_number":686,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"82a5c45e_ba293a13","line":683,"updated":"2024-08-02 06:51:22.000000000","message":"It\u0027s been 4 years now, I wonder whether we can drop this old stuff by now even if it wasn\u0027t formally deprecated. Mostly unrelated to this patch though","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc7ac8263ebbf78fb7ceaaf44247af26a81adafe","unresolved":false,"context_lines":[{"line_number":680,"context_line":"# setup_standard_logging_identity. Since we always run with systemd now,"},{"line_number":681,"context_line":"# this could be cleaned up, but the other functions may still be in use"},{"line_number":682,"context_line":"# by plugins. Since deprecations haven\u0027t worked in the past, we\u0027ll just"},{"line_number":683,"context_line":"# leave them in place."},{"line_number":684,"context_line":"function setup_logging {"},{"line_number":685,"context_line":"    setup_systemd_logging $1"},{"line_number":686,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1398af49_f3398bb9","line":683,"in_reply_to":"170bb987_335a413d","updated":"2024-08-05 08:04:15.000000000","message":"Hmm, ok, maybe next time, then ...","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dd4821a959b077ba39b14565fa5c08e168a6e1cb","unresolved":true,"context_lines":[{"line_number":680,"context_line":"# setup_standard_logging_identity. Since we always run with systemd now,"},{"line_number":681,"context_line":"# this could be cleaned up, but the other functions may still be in use"},{"line_number":682,"context_line":"# by plugins. Since deprecations haven\u0027t worked in the past, we\u0027ll just"},{"line_number":683,"context_line":"# leave them in place."},{"line_number":684,"context_line":"function setup_logging {"},{"line_number":685,"context_line":"    setup_systemd_logging $1"},{"line_number":686,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"170bb987_335a413d","line":683,"in_reply_to":"82a5c45e_ba293a13","updated":"2024-08-02 20:44:51.000000000","message":"I wondered about it too. Only potentially useful to keep for devstack plugins out in the wild, I think. I see several hits on codesearch:\nhttps://codesearch.openstack.org/?q\u003dsetup_colorized_logging\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76bc4883c97d934533cee7d309a6da2c29f4f18c","unresolved":true,"context_lines":[{"line_number":686,"context_line":"}"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"# Enable or disable color in oslo.log logs"},{"line_number":689,"context_line":"OSLO_LOG_COLOR\u003d${OSLO_LOG_COLOR:-True}"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"# This function sets log formatting options for colorizing log"},{"line_number":692,"context_line":"# output to stdout. It is meant to be called by lib modules."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f7574266_fdb6790d","line":689,"updated":"2024-08-02 06:51:22.000000000","message":"please use our trueorfalse helper func:\n\nOSLO_LOG_COLOR\u003d$(trueorfalse True OSLO_LOG_COLOR)","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc7ac8263ebbf78fb7ceaaf44247af26a81adafe","unresolved":false,"context_lines":[{"line_number":686,"context_line":"}"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"# Enable or disable color in oslo.log logs"},{"line_number":689,"context_line":"OSLO_LOG_COLOR\u003d${OSLO_LOG_COLOR:-True}"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"# This function sets log formatting options for colorizing log"},{"line_number":692,"context_line":"# output to stdout. It is meant to be called by lib modules."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"acbe4cde_760c8f67","line":689,"in_reply_to":"461e05b3_26689464","updated":"2024-08-05 08:04:15.000000000","message":"Done","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dd4821a959b077ba39b14565fa5c08e168a6e1cb","unresolved":true,"context_lines":[{"line_number":686,"context_line":"}"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"# Enable or disable color in oslo.log logs"},{"line_number":689,"context_line":"OSLO_LOG_COLOR\u003d${OSLO_LOG_COLOR:-True}"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"# This function sets log formatting options for colorizing log"},{"line_number":692,"context_line":"# output to stdout. It is meant to be called by lib modules."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"461e05b3_26689464","line":689,"in_reply_to":"f7574266_fdb6790d","updated":"2024-08-02 20:44:51.000000000","message":"Oops.. I _thought_ there was something like that but didn\u0027t immediately see it when I looked for examples under /lib.","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"76bc4883c97d934533cee7d309a6da2c29f4f18c","unresolved":true,"context_lines":[{"line_number":722,"context_line":"    iniset $conf_file DEFAULT logging_exception_prefix \"ERROR %(name)s \u001b[01;35m%(instance)s\u001b[00m\""},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    # Enable or disable color for oslo.log"},{"line_number":725,"context_line":"    iniset $conf_file DEFAULT log_color $OSLO_LOG_COLOR"},{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"function setup_standard_logging_identity {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5e785fc3_45b82c5d","line":725,"updated":"2024-08-02 06:51:22.000000000","message":"This doesn\u0027t seem to have any effect on the logs that devstack produces, did you confirm that this actually works in a local deployment?","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bc7ac8263ebbf78fb7ceaaf44247af26a81adafe","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    iniset $conf_file DEFAULT logging_exception_prefix \"ERROR %(name)s \u001b[01;35m%(instance)s\u001b[00m\""},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    # Enable or disable color for oslo.log"},{"line_number":725,"context_line":"    iniset $conf_file DEFAULT log_color $OSLO_LOG_COLOR"},{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"function setup_standard_logging_identity {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fedd939_cca307d2","line":725,"in_reply_to":"2ac332d6_aa48e9e2","updated":"2024-08-05 08:04:15.000000000","message":"ok, that sounds fine to me, then","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dd4821a959b077ba39b14565fa5c08e168a6e1cb","unresolved":true,"context_lines":[{"line_number":722,"context_line":"    iniset $conf_file DEFAULT logging_exception_prefix \"ERROR %(name)s \u001b[01;35m%(instance)s\u001b[00m\""},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    # Enable or disable color for oslo.log"},{"line_number":725,"context_line":"    iniset $conf_file DEFAULT log_color $OSLO_LOG_COLOR"},{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"function setup_standard_logging_identity {"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2ac332d6_aa48e9e2","line":725,"in_reply_to":"5e785fc3_45b82c5d","updated":"2024-08-02 20:44:51.000000000","message":"Hm, yeah.. I think that may be because journalctl has some smartness and colors are only outputted to a tty:\n\u003e When outputting to a tty, lines are colored according to\n       priority: lines of level ERROR and higher are colored red; lines\n       of level WARNING are colored yellow; lines of level NOTICE are\n       highlighted; lines of level INFO are displayed normally; lines of\n       level DEBUG are colored grey.\n       \nhttps://man7.org/linux/man-pages/man1/journalctl.1.html#DESCRIPTION\n\nI did test on my local devstack where it works.","commit_id":"f31fe3bad040656c767b298e7b4a67b1b8629e4c"}]}