)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ef1cdb244d98225539a6e0e5cd9f6f8bba63abb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a933c037_7860509d","updated":"2024-10-04 17:08:13.000000000","message":"cinder-tempest-plugin also has more test and configuration to tests, testing the series here https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/931512","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4f9e6e6a60cddc21b09cf82e5fa5cbb864c07d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7937ed2_5d3bfce6","updated":"2024-10-10 05:54:50.000000000","message":"lgtm","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"}],"lib/cinder":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e64c1f49996dde71677dd75bf7aceabcd274a021","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            get_or_create_endpoint \\"},{"line_number":488,"context_line":"                \"block-storage\" \\"},{"line_number":489,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":490,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v3\""},{"line_number":491,"context_line":"        fi"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        configure_cinder_internal_tenant"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3b2b4609_47447025","line":490,"range":{"start_line":490,"start_character":64,"end_line":490,"end_character":75},"updated":"2024-10-04 17:07:33.000000000","message":"Initially, I thought they still needed project-id in the URL, but micro version 3.67 removed it[1]; but older micro versions still need it in the URL, and these micro version tests will fail, right?\n\n\n[1] https://docs.openstack.org/cinder/latest/contributor/api_microversion_history.html#id57","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9742a3e5f1496c7afce70e7ce5bcbc4db8a605a","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            get_or_create_endpoint \\"},{"line_number":488,"context_line":"                \"block-storage\" \\"},{"line_number":489,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":490,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v3\""},{"line_number":491,"context_line":"        fi"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        configure_cinder_internal_tenant"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5895ca9d_24bed3ed","line":490,"range":{"start_line":490,"start_character":64,"end_line":490,"end_character":75},"in_reply_to":"3b2b4609_47447025","updated":"2024-10-04 17:41:24.000000000","message":"I am a little confused as with the older microversion \u00273.55\u0027 (which still needs project id in url) passing without project-id\n\nhttps://zuul.opendev.org/t/openstack/build/e71212553297431da71116b8555cd6c2/log/controller/logs/tempest_log.txt#67026-67032","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e6d38a877a09e11cc5025f867d4376b1e45720e","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            get_or_create_endpoint \\"},{"line_number":488,"context_line":"                \"block-storage\" \\"},{"line_number":489,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":490,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v3\""},{"line_number":491,"context_line":"        fi"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        configure_cinder_internal_tenant"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e6423df1_b3ef3a2e","line":490,"range":{"start_line":490,"start_character":64,"end_line":490,"end_character":75},"in_reply_to":"5895ca9d_24bed3ed","updated":"2024-10-07 18:45:34.000000000","message":"The way the removal of project IDs was implemented in Cinder was by adding a helper than added *two* paths for each resource: one with the project ID parameter and one without. However, both paths resolve to the same API method, rather than the path without project ID pointing towards a different API method that checked for a minimum microversion. As such, this microversion behaves more like Glance\u0027s API versions or Neutron\u0027s extensions, in that presence of the microversion indicates that the server supports paths without project IDs, and requesting an older microversion does not remove this capability. It\u0027s far from ideal, but the ship sailed a long time ago 😞\n\nhttps://github.com/openstack/cinder/blob/774d784a/cinder/api/openstack/__init__.py#L84-L101","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a516cdad930362b988f8390d02e7dd2e5c774431","unresolved":true,"context_lines":[{"line_number":487,"context_line":"            get_or_create_endpoint \\"},{"line_number":488,"context_line":"                \"block-storage\" \\"},{"line_number":489,"context_line":"                \"$REGION_NAME\" \\"},{"line_number":490,"context_line":"                \"$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST/volume/v3\""},{"line_number":491,"context_line":"        fi"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        configure_cinder_internal_tenant"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"36010357_c0acf9c1","line":490,"range":{"start_line":490,"start_character":64,"end_line":490,"end_character":75},"in_reply_to":"e6423df1_b3ef3a2e","updated":"2024-10-09 01:08:47.000000000","message":"yeah, this is what interop issue is with microversion implemented serviecs. The new way wihtout project-id will work on newer cloud but not on older one and not sure if there is way to detect those.\n\nAnyways as you said ship is sailed, we cannot do much in that. Doing it in new way in devatack lgtm","commit_id":"2d487d8c7b424a76eb484d09f09530e24b7207fb"}]}
