)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"34a76b3e47f0a448776e5d2ae015d8d0ba964bc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26a3697b_fea622f4","updated":"2024-10-25 06:25:07.000000000","message":"lgtm, i\u0027m ok with letting the execution die if there is a different wsgi mode used and we can completely remove WSGI_MODE and hardcode \"uwsgi\" later","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b11f3349f2cd60a028e60a6de37ded3ed871533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f59efd3_b19a5ac3","updated":"2024-10-16 09:30:17.000000000","message":"recheck unrelated failure","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"}],"stackrc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"02f5d4d82c8de320f83260dc04fc9c55cd3b41cd","unresolved":true,"context_lines":[{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d78fa55c_3dda0db1","line":228,"updated":"2024-10-18 13:29:32.000000000","message":"does ironic support gunicorn?","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5c96d4dd3de6dfb37eaee87c2165f54665a30303","unresolved":true,"context_lines":[{"line_number":218,"context_line":"# Zero disables timeouts"},{"line_number":219,"context_line":"GIT_TIMEOUT\u003d${GIT_TIMEOUT:-0}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# How should we be handling WSGI deployments. By default we\u0027re going"},{"line_number":222,"context_line":"# to allow for 2 modes, which is \"uwsgi\" which runs with an apache"},{"line_number":223,"context_line":"# proxy uwsgi in front of it, or \"mod_wsgi\", which runs in"},{"line_number":224,"context_line":"# apache. mod_wsgi is deprecated, don\u0027t use it."},{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8fb0cce5_907d18fa","line":228,"range":{"start_line":221,"start_character":0,"end_line":228,"end_character":2},"updated":"2024-10-20 18:35:03.000000000","message":"in that case, can we remove the WSGI_MODE option itself and hardcode \u0027uwsgi\u0027 ?","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e2c24505c283e4617446fbc5bd1d270e8c4a1d8f","unresolved":true,"context_lines":[{"line_number":218,"context_line":"# Zero disables timeouts"},{"line_number":219,"context_line":"GIT_TIMEOUT\u003d${GIT_TIMEOUT:-0}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# How should we be handling WSGI deployments. By default we\u0027re going"},{"line_number":222,"context_line":"# to allow for 2 modes, which is \"uwsgi\" which runs with an apache"},{"line_number":223,"context_line":"# proxy uwsgi in front of it, or \"mod_wsgi\", which runs in"},{"line_number":224,"context_line":"# apache. mod_wsgi is deprecated, don\u0027t use it."},{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e946504f_3a5d99fb","line":228,"range":{"start_line":221,"start_character":0,"end_line":228,"end_character":2},"in_reply_to":"26b122e2_1060a67f","updated":"2024-10-22 17:06:01.000000000","message":"many of the pluggins have cargo culted this code\n\nhttps://codesearch.opendev.org/?q\u003dWSGI_MODE\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\n\nmonasca api looks like it overrieds this when using java\n\nhttps://opendev.org/openstack/monasca-api/src/branch/master/devstack/override-defaults#L2\n\nand i dont see anything else setting this.\n\nso likely we can move forward and fix that one plugin or just have it stop using that var.","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"db4a3ab107aed72295193cf022f7db3ef3c7275d","unresolved":true,"context_lines":[{"line_number":218,"context_line":"# Zero disables timeouts"},{"line_number":219,"context_line":"GIT_TIMEOUT\u003d${GIT_TIMEOUT:-0}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# How should we be handling WSGI deployments. By default we\u0027re going"},{"line_number":222,"context_line":"# to allow for 2 modes, which is \"uwsgi\" which runs with an apache"},{"line_number":223,"context_line":"# proxy uwsgi in front of it, or \"mod_wsgi\", which runs in"},{"line_number":224,"context_line":"# apache. mod_wsgi is deprecated, don\u0027t use it."},{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"26b122e2_1060a67f","line":228,"range":{"start_line":221,"start_character":0,"end_line":228,"end_character":2},"in_reply_to":"8fb0cce5_907d18fa","updated":"2024-10-21 10:08:00.000000000","message":"I was concerned about devstack plugins. If they are setting `WSGI_MODE` to a different value then I figured we should know about it early? Maybe I can just remove it and they will break?","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"34a76b3e47f0a448776e5d2ae015d8d0ba964bc5","unresolved":true,"context_lines":[{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d0e0b59f_9a8de087","line":228,"in_reply_to":"d78fa55c_3dda0db1","updated":"2024-10-25 06:25:07.000000000","message":"seems so:\nhttps://opendev.org/openstack/ironic/src/commit/1f740c8a90e1c9bcdd2fb7ee589a5b38d16f8e1e/devstack/lib/ironic#L1125-L1144","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"205c64604161383b2ca3d4a13b0598d94f8bc3bc","unresolved":true,"context_lines":[{"line_number":218,"context_line":"# Zero disables timeouts"},{"line_number":219,"context_line":"GIT_TIMEOUT\u003d${GIT_TIMEOUT:-0}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# How should we be handling WSGI deployments. By default we\u0027re going"},{"line_number":222,"context_line":"# to allow for 2 modes, which is \"uwsgi\" which runs with an apache"},{"line_number":223,"context_line":"# proxy uwsgi in front of it, or \"mod_wsgi\", which runs in"},{"line_number":224,"context_line":"# apache. mod_wsgi is deprecated, don\u0027t use it."},{"line_number":225,"context_line":"WSGI_MODE\u003d${WSGI_MODE:-\"uwsgi\"}"},{"line_number":226,"context_line":"if [[ \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"},{"line_number":227,"context_line":"    die $LINENO \"$WSGI_MODE is no longer a supported WSGI mode. Only uwsgi is valid.\""},{"line_number":228,"context_line":"fi"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Repositories"},{"line_number":231,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2860230f_f78e0a84","line":228,"range":{"start_line":221,"start_character":0,"end_line":228,"end_character":2},"in_reply_to":"e946504f_3a5d99fb","updated":"2024-10-22 17:09:15.000000000","message":"the default for monasca is python not java\n\nhttps://opendev.org/openstack/monasca-api/src/branch/master/devstack/settings#L24\n\nbut there is one job that use java\n\nhttps://opendev.org/openstack/monasca-api/src/branch/master/.zuul.yaml#L162-L172\n\nthat job is used by a differnt repo but there is a python version fo it too\n\nhttps://opendev.org/openstack/monasca-persister/src/branch/master/.zuul.yaml#L10-L11\n\nso im not sure if we need to catehr for this going forward.","commit_id":"851d82ccca40d61cbfd2319c38e0128bdaea247e"}]}