)]}'
{"tools/build_venv.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2f732b2b31c725acd1ba3ad225e0bbfb5e3fc643","unresolved":true,"context_lines":[{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Build new venv"},{"line_number":41,"context_line":"python$PYTHON3_VERSION -m venv --system-site-packages $VENV_DEST"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Install modern pip"},{"line_number":44,"context_line":"PIP_VIRTUAL_ENV\u003d$VENV_DEST pip_install -U pip"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6fd44214_d746edb4","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":53},"updated":"2024-12-10 22:57:05.000000000","message":"Adding site packages is a behavior change compared to what was being done with virtualenv. That said we use system-site-packages with GLOBAL_VENV because some things cannot be installed from pypi and this gives us an out for those. For that reason this is probably fine, but I wanted to call it out.","commit_id":"2fdb729e04e8227ac5bfe619df20c1854bf255bc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cebcfaa318e0f49b372fc8893e808e4bb80cb46e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"fi"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Build new venv"},{"line_number":41,"context_line":"python$PYTHON3_VERSION -m venv --system-site-packages $VENV_DEST"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Install modern pip"},{"line_number":44,"context_line":"PIP_VIRTUAL_ENV\u003d$VENV_DEST pip_install -U pip"}],"source_content_type":"text/x-sh","patch_set":2,"id":"50b34afd_87c5de16","line":41,"range":{"start_line":41,"start_character":31,"end_line":41,"end_character":53},"in_reply_to":"6fd44214_d746edb4","updated":"2025-01-08 13:02:20.000000000","message":"I agree, we can make it optional once we find some consumer that is broken by it","commit_id":"2fdb729e04e8227ac5bfe619df20c1854bf255bc"}]}