)]}'
{"lib/neutron":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c956dd09d8ee075cdd49879888746c4d6a123033","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    elif is_provider_network; then"},{"line_number":404,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type $PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" --provider:segmentation_id \"$SEGMENTATION_ID\" --router:external\u003dtrue --shared | grep \u0027 id \u0027 | get_field 2)"},{"line_number":405,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --name $PROVIDER_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":406,"context_line":"        SUBNET_V6_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 6 --ipv6-address-mode slaac ${ALLOCATION_POOL_V6:+--allocation-pool $ALLOCATION_POOL_V6} --gateway $V6_NETWORK_GATEWAY --name $PROVIDER_SUBNET_NAME_V6 $NET_ID $FIXED_RANGE_V6 | grep \u0027id\u0027 | get_field 2)"},{"line_number":407,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":408,"context_line":"        sudo ip link set br-int up"},{"line_number":409,"context_line":"        sudo ip link set $PUBLIC_INTERFACE up"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_a828f786","line":406,"updated":"2014-05-15 11:51:36.000000000","message":"ummmm, is there a way to break up at least the conditionals out of this? This is a pretty long line and gets weird to review.\n\nMy suggestion would be to pull out the allocation pool assignment.\n\nI also wonder if we could get some neutron functions written for some of these long lines.","commit_id":"91e6383f0a7b5686f0a66b1c649b8e713dc9e2b6"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4c61966f3b747ca51bd5379ec024d7da00d8a878","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    elif is_provider_network; then"},{"line_number":404,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type $PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" --provider:segmentation_id \"$SEGMENTATION_ID\" --router:external\u003dtrue --shared | grep \u0027 id \u0027 | get_field 2)"},{"line_number":405,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --name $PROVIDER_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":406,"context_line":"        SUBNET_V6_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 6 --ipv6-address-mode slaac ${ALLOCATION_POOL_V6:+--allocation-pool $ALLOCATION_POOL_V6} --gateway $V6_NETWORK_GATEWAY --name $PROVIDER_SUBNET_NAME_V6 $NET_ID $FIXED_RANGE_V6 | grep \u0027id\u0027 | get_field 2)"},{"line_number":407,"context_line":"        sudo ip link set $OVS_PHYSICAL_BRIDGE up"},{"line_number":408,"context_line":"        sudo ip link set br-int up"},{"line_number":409,"context_line":"        sudo ip link set $PUBLIC_INTERFACE up"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7adec928_63745036","line":406,"in_reply_to":"7adec928_a828f786","updated":"2014-05-15 13:19:11.000000000","message":"I will remove the allocation pool assignment","commit_id":"91e6383f0a7b5686f0a66b1c649b8e713dc9e2b6"}]}