)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a2b21e9f272188c5fc3129d9ae68bdf6b8a0735e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f77da0e9_704611ea","updated":"2024-12-03 08:15:39.000000000","message":"lgtm","commit_id":"97ea68ec4611391de2e245a1def655cbebc7649d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f7e5071282e6b4ea5a7e10177f3a83b3397e79c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c84da90a_03e86b02","updated":"2024-12-03 08:53:42.000000000","message":"verified in https://review.opendev.org/c/openstack/neutron/+/936853 so lgtm","commit_id":"97ea68ec4611391de2e245a1def655cbebc7649d"}],"lib/databases/mysql":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a814efbe357cb7313cc3768ca0c7b83deb9d80f","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    # as root so it works only as sudo. To restore old \"mysql like\" behaviour,"},{"line_number":123,"context_line":"    # we need to change auth plugin for root user"},{"line_number":124,"context_line":"    # TODO(frickler): simplify this logic"},{"line_number":125,"context_line":"    if is_ubuntu \u0026\u0026 [[ ! \"$DISTRO\" \u003d~ bookworm|bullseye ]] \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"},{"line_number":126,"context_line":"        # For Ubuntu 22.04+ (jammy) we follow the model outlined in"},{"line_number":127,"context_line":"        # https://mariadb.org/authentication-in-mariadb-10-4/"},{"line_number":128,"context_line":"        sudo mysql -e \"ALTER USER $DATABASE_USER@localhost IDENTIFIED VIA mysql_native_password USING PASSWORD(\u0027$DATABASE_PASSWORD\u0027);\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8e27544d_b549c757","line":125,"range":{"start_line":125,"start_character":20,"end_line":125,"end_character":58},"updated":"2024-12-02 15:27:54.000000000","message":"Is that needed with the previous check \"is_ubuntu\"?","commit_id":"1c8a1116b4f93a9aa13551ac5d7c259757dfffb5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e01743570ddeb8a5ad242604b8bae2728607c507","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    # as root so it works only as sudo. To restore old \"mysql like\" behaviour,"},{"line_number":123,"context_line":"    # we need to change auth plugin for root user"},{"line_number":124,"context_line":"    # TODO(frickler): simplify this logic"},{"line_number":125,"context_line":"    if is_ubuntu \u0026\u0026 [[ ! \"$DISTRO\" \u003d~ bookworm|bullseye ]] \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"},{"line_number":126,"context_line":"        # For Ubuntu 22.04+ (jammy) we follow the model outlined in"},{"line_number":127,"context_line":"        # https://mariadb.org/authentication-in-mariadb-10-4/"},{"line_number":128,"context_line":"        sudo mysql -e \"ALTER USER $DATABASE_USER@localhost IDENTIFIED VIA mysql_native_password USING PASSWORD(\u0027$DATABASE_PASSWORD\u0027);\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"661abf80_afc239eb","line":125,"range":{"start_line":125,"start_character":20,"end_line":125,"end_character":58},"in_reply_to":"8e27544d_b549c757","updated":"2024-12-02 15:29:21.000000000","message":"This is actually not touched in this patch so maybe this comment is not relevant.","commit_id":"1c8a1116b4f93a9aa13551ac5d7c259757dfffb5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f6ae837f65e6a4f6d9c2616d530ad7c50d73d7a5","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    # as root so it works only as sudo. To restore old \"mysql like\" behaviour,"},{"line_number":123,"context_line":"    # we need to change auth plugin for root user"},{"line_number":124,"context_line":"    # TODO(frickler): simplify this logic"},{"line_number":125,"context_line":"    if is_ubuntu \u0026\u0026 [[ ! \"$DISTRO\" \u003d~ bookworm|bullseye ]] \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"},{"line_number":126,"context_line":"        # For Ubuntu 22.04+ (jammy) we follow the model outlined in"},{"line_number":127,"context_line":"        # https://mariadb.org/authentication-in-mariadb-10-4/"},{"line_number":128,"context_line":"        sudo mysql -e \"ALTER USER $DATABASE_USER@localhost IDENTIFIED VIA mysql_native_password USING PASSWORD(\u0027$DATABASE_PASSWORD\u0027);\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cda9fcdc_a918ae09","line":125,"range":{"start_line":125,"start_character":20,"end_line":125,"end_character":58},"in_reply_to":"8e27544d_b549c757","updated":"2024-12-02 15:30:19.000000000","message":"yes is_ubuntu applies to both ubuntu and debian so have to filter debian ones","commit_id":"1c8a1116b4f93a9aa13551ac5d7c259757dfffb5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f7e5071282e6b4ea5a7e10177f3a83b3397e79c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # In mariadb e.g. on Ubuntu socket plugin is used for authentication"},{"line_number":123,"context_line":"    # as root so it works only as sudo. To restore old \"mysql like\" behaviour,"},{"line_number":124,"context_line":"    # we need to change auth plugin for root user"},{"line_number":125,"context_line":"    # TODO(frickler): simplify this logic"},{"line_number":126,"context_line":"    if is_ubuntu \u0026\u0026 [[ ! \"$DISTRO\" \u003d~ bookworm|bullseye ]] \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"},{"line_number":127,"context_line":"        # For Ubuntu 22.04+ we follow the model outlined in"},{"line_number":128,"context_line":"        # https://mariadb.org/authentication-in-mariadb-10-4/"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"06bf72f5_10f4e353","line":125,"updated":"2024-12-03 08:53:42.000000000","message":"this still seems to be needed, but this change is good enough for now I guess","commit_id":"97ea68ec4611391de2e245a1def655cbebc7649d"}]}