)]}'
{"functions":[{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"4aec9c14f1c0356cbcafe3fa0472d8663cf7c1e3","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"# remove extra commas from the input string (ENABLED_SERVICES)"},{"line_number":354,"context_line":"function _cleanup_service_list () {"},{"line_number":355,"context_line":"\techo \"$1\" | sed \u0027s/,,/,/g\u0027 | sed \u0027s/^,//\u0027 | sed \u0027s/,$//\u0027"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"# enable_service() adds the services passed as argument to the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAKH%2F%2F%2Bvw%3D","line":355,"updated":"2012-07-06 07:34:52.000000000","message":"Any reason to use multiple sed instead of:\n  sed \u0027s/,,/,/g;s/^,//;s/,$//\u0027\n(which can be done on multiple lines for readability, see the sed for \"Configure apache to run horizon in stack.sh)\n\nBtw, you\u0027re using a tab here (and on several other lines); moving to spaces-only would be cool ;-)","commit_id":"a594561e1ac71ddd315ff169ebb2f2d769b337f8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"80e6d75eb30f83e9a1814ede696009305646a993","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"# remove extra commas from the input string (ENABLED_SERVICES)"},{"line_number":354,"context_line":"function _cleanup_service_list () {"},{"line_number":355,"context_line":"\techo \"$1\" | sed \u0027s/,,/,/g\u0027 | sed \u0027s/^,//\u0027 | sed \u0027s/,$//\u0027"},{"line_number":356,"context_line":"}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"# enable_service() adds the services passed as argument to the"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAKH%2F%2F%2Bm4%3D","line":355,"in_reply_to":"AAAAKH%2F%2F%2Bvw%3D","updated":"2012-07-06 13:54:04.000000000","message":"I didn\u0027t know you could do that with sed, that\u0027s much nicer.\n\nI blame emacs for the tabs, they should be fixed in the new patch. :-)","commit_id":"a594561e1ac71ddd315ff169ebb2f2d769b337f8"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"4aec9c14f1c0356cbcafe3fa0472d8663cf7c1e3","unresolved":false,"context_lines":[{"line_number":363,"context_line":"function enable_service() {"},{"line_number":364,"context_line":"\tlocal tmpsvcs\u003d\"${ENABLED_SERVICES}\""},{"line_number":365,"context_line":"    for service in $@"},{"line_number":366,"context_line":"    do"},{"line_number":367,"context_line":"        if ! is_service_enabled $service"},{"line_number":368,"context_line":"        then"},{"line_number":369,"context_line":"            tmpsvcs+\u003d\",$service\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAKH%2F%2F%2Bvs%3D","line":366,"updated":"2012-07-06 07:34:52.000000000","message":"Formatting detail: it seems the code is generally putting this on just one line: \"for foo in bar; do\"\n\nSame for \"if foo; then\".","commit_id":"a594561e1ac71ddd315ff169ebb2f2d769b337f8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"80e6d75eb30f83e9a1814ede696009305646a993","unresolved":false,"context_lines":[{"line_number":363,"context_line":"function enable_service() {"},{"line_number":364,"context_line":"\tlocal tmpsvcs\u003d\"${ENABLED_SERVICES}\""},{"line_number":365,"context_line":"    for service in $@"},{"line_number":366,"context_line":"    do"},{"line_number":367,"context_line":"        if ! is_service_enabled $service"},{"line_number":368,"context_line":"        then"},{"line_number":369,"context_line":"            tmpsvcs+\u003d\",$service\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAKH%2F%2F%2Bm0%3D","line":366,"in_reply_to":"AAAAKH%2F%2F%2Bvs%3D","updated":"2012-07-06 13:54:04.000000000","message":"Done","commit_id":"a594561e1ac71ddd315ff169ebb2f2d769b337f8"}]}