)]}'
{"id":"openstack%2Fdevstack~9407","triplet_id":"openstack%2Fdevstack~master~I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873","project":"openstack/devstack","branch":"master","topic":"feature/service-manager-function","hashtags":[],"change_id":"I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873","subject":"add functions to manipulate ENABLED_SERVICES","status":"MERGED","created":"2012-07-05 21:15:17.000000000","updated":"2012-07-14 00:17:16.000000000","submitted":"2012-07-14 00:17:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a5318c8a9c0033c6f3bb69c223cf4cf7bf8b7738","_number":9407,"virtual_id_number":9407,"owner":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2012-07-14 00:17:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"recommended":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"all":[{"value":1,"date":"2012-07-06 20:13:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":2,"date":"2012-07-13 23:59:41.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-07-13 15:15:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":1,"date":"2012-07-13 15:26:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},{"value":2,"date":"2012-07-09 20:32:38.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":1,"date":"2012-07-13 23:59:41.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},{"value":0,"date":"2012-07-09 20:32:38.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-07-05 21:26:03.000000000","updated_by":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"reviewer":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"state":"REVIEWER"},{"updated":"2012-07-06 14:05:02.000000000","updated_by":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"reviewer":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"state":"REVIEWER"},{"updated":"2012-07-06 20:13:54.000000000","updated_by":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"reviewer":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"state":"REVIEWER"},{"updated":"2012-07-09 20:32:38.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2012-07-13 15:26:19.000000000","updated_by":{"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},"reviewer":{"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},"state":"REVIEWER"},{"updated":"2012-07-13 23:59:41.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-07-14 00:17:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6039af917c05cb8fba82ab0922ae27d82a6979e7","author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"date":"2012-07-05 21:26:03.000000000","message":"Patch Set 1:\n\nDoug: Mixing tabs and spaces. Can you cleanup?","accounts_in_message":[],"_revision_number":1},{"id":"66d1f3c71794e657e5f8c16cd3fb38f3660ddd84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-05 21:35:04.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/593/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/7341/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"4aec9c14f1c0356cbcafe3fa0472d8663cf7c1e3","author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"date":"2012-07-06 07:34:52.000000000","message":"Patch Set 1: (2 inline comments)\n\nThat looks like a good idea to me. I\u0027ve added some comments about the formatting itself.\n\nTwo things:\n\n - we probably want to handle the case of \"ENABLED_SERVICES+\u003d,-swift\" which was added recently (in c4cd4140). If someone does \"ENABLED_SERVICES+\u003d,-swift\" and then \"enable_service swift\", I think this won\u0027t work as expected.\n\n - I\u0027d love to be able to support enabling/disabling nova, glance, quantum, and other services that are using the n-* magic. Disabling is actually not too difficult, but enabling is another story... Does it make sense to support disabling without enabling?","accounts_in_message":[],"_revision_number":1},{"id":"fb6d5582288af4a11a40d58f5d5a0b1c83e9b8cf","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 13:53:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80e6d75eb30f83e9a1814ede696009305646a993","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 13:54:04.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"929ad4fb2bdee6e472dd92c99084a20fb8fd17b0","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 13:57:25.000000000","message":"Patch Set 2:\n\nVincent, I don\u0027t know what \"ENABLED_SERVICES+\u003d,-swift\" does. Can you point me toward something more detailed to explain it?\n\nAs far as enabling/disabling the service bundles for nova, et al, Dean specifically asked that I not include that feature. One compromise would be to create enable_nova, enable_glance, etc. as separate functions. If that\u0027s acceptable, I would like to do it in another changeset.","accounts_in_message":[],"_revision_number":2},{"id":"1ef4241d28158d0b55ece0e5842da65a67481055","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-06 14:02:50.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/596/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/7386/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"721d7fc52638a56314e5581ad9804c4af9bbe30f","author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"date":"2012-07-06 14:05:02.000000000","message":"Patch Set 2:\n\nRe \"ENABLED_SERVICES+\u003d,-swift\", see the following commit: https://github.com/openstack-dev/devstack/commit/c4cd4140d3bb64a02321918df2f0f9258c6c4148","accounts_in_message":[],"_revision_number":2},{"id":"5a98d7e23048521cfe4666bd5d63687c4b3dba65","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 14:54:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f59aad832cd94cdaf74e6118d26d35471176bd83","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 14:55:27.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"cae6384a6a06ba122cf7738675ed62bca8b8c1fa","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 14:56:06.000000000","message":"Patch Set 4:\n\nPatch 4 includes fixes for the negated services feature along with some new tests and cleans up the whitespace in functions.sh which wasn\u0027t cleaned up in the earlier patches.","accounts_in_message":[],"_revision_number":4},{"id":"dfd2af10e3c5a6319ae3b3613ac112d2f1f718e7","author":{"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},"date":"2012-07-06 15:00:23.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"036db0e926f011005a73de066249875e5a59693e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-06 15:12:42.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/607/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/7398/consoleFull : FAILURE\n","accounts_in_message":[],"_revision_number":4},{"id":"834fa0fd542bf2a2add27b82312b836a366c2269","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 18:43:17.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"ac79127a8386eb3c1c386a50c92dda96ff5b5b40","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-06 18:55:07.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/614/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/7425/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"e47d3223199b1fa876bfc9a0148dda39775c9cc4","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 19:49:04.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7b6c5d796f4a9ebce5d5ef4a72ed0bd960a29cbb","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-06 19:52:34.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c891bcd77f078cc091d38fd3171e37b6862b0893","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-06 20:03:52.000000000","message":"Patch Set 6: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/616/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/7434/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"265d1229dcfa271b671c710d507e3b47d63dd0f3","author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"date":"2012-07-06 20:13:54.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"83b2e4da86cc157bca062dd3a37921fc786ca87b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-07-09 20:32:38.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\nThanks Doug, looks good.  I\u0027ve proposed https://review.openstack.org/#/c/9542/ and https://review.openstack.org/#/c/9543/ to fix the other outstanding scripts.  There\u0027s no issue if the functions are not used in localrc.","accounts_in_message":[],"_revision_number":6},{"id":"36568bfee45cec58046ea2f1725378c4e90a8f9a","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2012-07-13 15:15:25.000000000","message":"Patch Set 6:\n\nAre there any other review comments on this one?","accounts_in_message":[],"_revision_number":6},{"id":"1adcb9a07560226ac4b9f756e09ea9f89e8be973","author":{"_account_id":1801,"name":"Duncan McGreggor","email":"duncan.mcgreggor@rackspace.com","username":"oubiwann"},"date":"2012-07-13 15:26:19.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"f044ac285390b4863ae209445180bfaf6274be24","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-07-13 23:59:41.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"a49f88f41a7481b88512efcbef62098a7ab5aa2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-13 23:59:42.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"62a9be01e516ad3196e173efcad0848a78af9a4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-14 00:17:15.000000000","message":"Patch Set 6: Verified\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-devstack-merge/676/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-tempest-devstack-vm/3832/testReport : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"f433532505cf932e2c7a34471040041fd3271d8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-14 00:17:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"f04178fd12731a58c899c309ad43f55d339909c5","revisions":{"a594561e1ac71ddd315ff169ebb2f2d769b337f8":{"kind":"REWORK","_number":1,"created":"2012-07-05 21:15:17.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/1"}}},"commit":{"parents":[{"commit":"6a19b59f6459c248c775377090561acdd57ca2f7","subject":"Merge \"Fix grep on MySQL configuration file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a19b59f6459c248c775377090561acdd57ca2f7"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:13:50.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a594561e1ac71ddd315ff169ebb2f2d769b337f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a594561e1ac71ddd315ff169ebb2f2d769b337f8"}]},"branch":"refs/heads/master"},"4af00a17b3ccc8bef591101823055c6fcd11fc18":{"kind":"REWORK","_number":2,"created":"2012-07-06 13:53:05.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/2"}}},"commit":{"parents":[{"commit":"6a19b59f6459c248c775377090561acdd57ca2f7","subject":"Merge \"Fix grep on MySQL configuration file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a19b59f6459c248c775377090561acdd57ca2f7"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-06 13:52:58.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4af00a17b3ccc8bef591101823055c6fcd11fc18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4af00a17b3ccc8bef591101823055c6fcd11fc18"}]},"branch":"refs/heads/master"},"c7a17d2758a12d450190abf7db1b13214811708f":{"kind":"REWORK","_number":3,"created":"2012-07-06 14:54:35.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/3"}}},"commit":{"parents":[{"commit":"6a19b59f6459c248c775377090561acdd57ca2f7","subject":"Merge \"Fix grep on MySQL configuration file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a19b59f6459c248c775377090561acdd57ca2f7"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-06 14:54:27.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nIt also moves the logic for dealing with \"negated\"\nservices into a function so it can be tested and\napplied by the new functions for manipulating\nENABLED_SERVICES.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c7a17d2758a12d450190abf7db1b13214811708f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c7a17d2758a12d450190abf7db1b13214811708f"}]},"branch":"refs/heads/master"},"9711692dc695d9ad7f02afe247dd19ece8de5ce3":{"kind":"REWORK","_number":4,"created":"2012-07-06 14:55:27.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/4"}}},"commit":{"parents":[{"commit":"6a19b59f6459c248c775377090561acdd57ca2f7","subject":"Merge \"Fix grep on MySQL configuration file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a19b59f6459c248c775377090561acdd57ca2f7"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-06 14:55:21.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nIt also moves the logic for dealing with \"negated\"\nservices into a function so it can be tested and\napplied by the new functions for manipulating\nENABLED_SERVICES.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9711692dc695d9ad7f02afe247dd19ece8de5ce3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9711692dc695d9ad7f02afe247dd19ece8de5ce3"}]},"branch":"refs/heads/master"},"cb3ac6a5eaac9f35f4cf57f9916fd275b3777538":{"kind":"REWORK","_number":5,"created":"2012-07-06 19:49:04.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/5"}}},"commit":{"parents":[{"commit":"08bc3048b10b7dbe62b38109274b0cd32a460de9","subject":"Merge \"Cleanup stack/unstack\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/08bc3048b10b7dbe62b38109274b0cd32a460de9"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-06 19:49:02.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nIt also moves the logic for dealing with \"negated\"\nservices into a function so it can be tested and\napplied by the new functions for manipulating\nENABLED_SERVICES.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cb3ac6a5eaac9f35f4cf57f9916fd275b3777538"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cb3ac6a5eaac9f35f4cf57f9916fd275b3777538"}]},"branch":"refs/heads/master"},"f04178fd12731a58c899c309ad43f55d339909c5":{"kind":"REWORK","_number":6,"created":"2012-07-06 19:52:34.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/07/9407/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/07/9407/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/07/9407/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/07/9407/6"}}},"commit":{"parents":[{"commit":"08bc3048b10b7dbe62b38109274b0cd32a460de9","subject":"Merge \"Cleanup stack/unstack\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/08bc3048b10b7dbe62b38109274b0cd32a460de9"}]}],"author":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-05 21:10:03.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug.hellmann@dreamhost.com","date":"2012-07-06 19:52:06.000000000","tz":-240},"subject":"add functions to manipulate ENABLED_SERVICES","message":"add functions to manipulate ENABLED_SERVICES\n\nEditing ENABLED_SERVICES directly can get tricky when\nthe user wants to disable something. This patch includes\ntwo new functions for adding or removing services\nsafely, and a third (for completeness) to clear the\nsettings entirely before adding a minimal set of\nservices.\n\nIt also moves the logic for dealing with \"negated\"\nservices into a function so it can be tested and\napplied by the new functions for manipulating\nENABLED_SERVICES.\n\nChange-Id: I88f205f3666b86e6f0b6a94e0ec32a26c4bc6873\nSigned-off-by: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f04178fd12731a58c899c309ad43f55d339909c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f04178fd12731a58c899c309ad43f55d339909c5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}