)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ac84e60e6a1fc6f746facfab64c5da69b3cb7d0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d360fd21_ad69a1ff","updated":"2025-05-12 22:17:21.000000000","message":"Oops I meant to +2 this with my previous comment.","commit_id":"cbae98949193085f0ef5cfc250d5e8cc7530de5f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9c9f12c67f2170f699af8d0f798d71ffbfc59d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2adf71e1_8d21f7a2","updated":"2025-05-12 22:17:06.000000000","message":"OpenDev has had to make a number of apparmor related changes as we migrate to Noble as well. The version of apparmor on Noble is newer and enforces a lot more restrictions. I am half surprised the fix in this case is to not disable things, but am not surprised that changes to apparmor are needed. In any case this seems fine to me.","commit_id":"cbae98949193085f0ef5cfc250d5e8cc7530de5f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"91a7d66cf6cc9cb4d66fad3e589af6f43d3ffb07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48f0fbbe_d08c72f9","updated":"2025-05-12 15:56:38.000000000","message":"Testing this in neutron here https://review.opendev.org/c/openstack/neutron/+/949511","commit_id":"cbae98949193085f0ef5cfc250d5e8cc7530de5f"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7f8a68d0274689d50cdd832e0ab0fd5798f5789b","unresolved":true,"context_lines":[{"line_number":300,"context_line":"    _configure_public_network_connectivity"},{"line_number":301,"context_line":"}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"function _disable_libvirt_apparmor {"},{"line_number":304,"context_line":"    if ! sudo aa-status --enabled ; then"},{"line_number":305,"context_line":"        return 0"},{"line_number":306,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6153c6e5_efa9e43d","side":"PARENT","line":303,"updated":"2025-05-12 17:15:36.000000000","message":"so my understainding is that htis was speficicly added a very long time ago when ovn was in it own plugin.\n\nthe reason for this is when you compiled ovs adn ovn from soruce it had some apparmor issue with libvirt createign the port on ovs. likely because libvirt used the ovs-vsctl util and it proably was in a differnt location i.e. /usr/bin vs /usr/local/bin.\n\n\nregardless of the orgianl reaosn why nova nolonger uses libvirt to create port on ovs, os-vif handles that and has for a number of years.\n\nso libvirt should not be interacting with ovs directly anymroe and even if it was we use ovn form distor package by default now.\n\n\nstephen also proposed a dnm to neutron to tirgger there jobs and that is alos green\n\nhttps://review.opendev.org/c/openstack/neutron/+/949511?\n\ngiven that context and the fact ci is happy i think removing this is well overdue.","commit_id":"ddcd052b1e4ed707f431de56cfa81ac24328bbaa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ec6369e510cb83ba51ef1ecc22223f686ffffa38","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    _configure_public_network_connectivity"},{"line_number":301,"context_line":"}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"function _disable_libvirt_apparmor {"},{"line_number":304,"context_line":"    if ! sudo aa-status --enabled ; then"},{"line_number":305,"context_line":"        return 0"},{"line_number":306,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"59418e7b_b71bb2aa","side":"PARENT","line":303,"in_reply_to":"6153c6e5_efa9e43d","updated":"2025-05-13 06:53:03.000000000","message":"Acknowledged","commit_id":"ddcd052b1e4ed707f431de56cfa81ac24328bbaa"}]}