)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6ef5cd34c3a418ce11c277c42679544d4ed09170","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Date: Mon Jun 05 13:25:00 2014 -0500"},{"line_number":10,"context_line":"Implements: bugfix BUGFIX"},{"line_number":11,"context_line":"Closes-Bug: 1291111/1322200"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Reason of the change:"},{"line_number":14,"context_line":"When the Openstack is installed with a network proxy,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1ae5cdf2_7332f25e","line":11,"updated":"2014-06-22 01:42:00.000000000","message":"comments reflect the same intent as provided in https://review.openstack.org/#/c/94892\n\nThe commit message needs cleanup in multiple ways.","commit_id":"92a04540b8eac00ec53cb0fa989112153fc387ce"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f16979eae978bff2a7636701745f5b8d90dc0e67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reset no_proxy when the node is installed behind a proxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Date: Fri Jan 09 09:54:00 2015 -0500"},{"line_number":10,"context_line":"Implements: bugfix BUGFIX"},{"line_number":11,"context_line":"Closes-Bug: 1291111"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_fe221401","line":10,"updated":"2015-01-11 20:25:08.000000000","message":"I\u0027ve never seen this before.","commit_id":"fcdf1910cc40fc514c75874436d90c25106f01db"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f16979eae978bff2a7636701745f5b8d90dc0e67","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Date: Fri Jan 09 09:54:00 2015 -0500"},{"line_number":10,"context_line":"Implements: bugfix BUGFIX"},{"line_number":11,"context_line":"Closes-Bug: 1291111"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem:"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"3a961159_5e1a48c7","line":11,"updated":"2015-01-11 20:25:08.000000000","message":"I believe this should be in the last paragraph, like above the Change-Id line.","commit_id":"fcdf1910cc40fc514c75874436d90c25106f01db"}],"functions-common":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c06a7cb41219ec41870d5892b501345770cd6c56","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"    fi"},{"line_number":1596,"context_line":"    export no_proxy"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1599,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1600,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1601,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"1ae5cdf2_00a7040c","line":1598,"updated":"2014-06-18 14:13:46.000000000","message":"Do not modify localrc.  Also, this doesn\u0027t handle local.conf properly anyway.","commit_id":"92a04540b8eac00ec53cb0fa989112153fc387ce"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6ef5cd34c3a418ce11c277c42679544d4ed09170","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"    fi"},{"line_number":1596,"context_line":"    export no_proxy"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1599,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1600,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1601,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"1ae5cdf2_9335be46","line":1598,"updated":"2014-06-22 01:42:00.000000000","message":"that\u0027s a great point!","commit_id":"92a04540b8eac00ec53cb0fa989112153fc387ce"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"528ecb21d8f183f4cbaae150e6ab3cf9f5bc8be2","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"    fi"},{"line_number":1908,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1911,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1912,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1913,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"baa201ad_dedd86e1","line":1910,"updated":"2014-10-08 16:19:29.000000000","message":"Touching the localrc file is bad.\n\nMoreover localrc is deprecated, use local.conf. But anyway, touching local.conf is still bad.","commit_id":"273895786a7f4d20a9f843b1abd83e220b3fdeb2"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"d4d36641185e6184e36686ccac90b66fc36056ac","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"    fi"},{"line_number":1908,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1911,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1912,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1913,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"baa201ad_4ab3904c","line":1910,"in_reply_to":"baa201ad_dedd86e1","updated":"2014-10-08 18:56:05.000000000","message":"the only reason to use localrc is because the no_proxy parameter needs to be transferred to other process, e.g. Trove_installation. localrc is called by the \"others\" by default. if using another file, it is going to require an fix in Trove_installation.","commit_id":"273895786a7f4d20a9f843b1abd83e220b3fdeb2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f8682c277d7523e347be72c9f6e23ee958fb27b1","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1913,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1914,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1915,"context_line":"    else"},{"line_number":1916,"context_line":"        echo -e \"# Reset the no_proxy variables\\nexport no_proxy\u003d\"$no_proxy \u003e\u003e $TOP_DIR/localrc"},{"line_number":1917,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"baa201ad_a25a0a81","line":1914,"updated":"2014-10-13 08:04:01.000000000","message":"I am not a big fan of overwritting the localrc. But in any case you should add/edit the local.conf. For instance, in my devstack I don\u0027t have a localrc file. Because localrc is deprecated in favor of local.conf.\n\nIf you want your patch to work in a few month and in all situation you should concider also editing the local.conf","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"c634173dbc90ba8121493ac63b0082d942a08f37","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1913,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1914,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1915,"context_line":"    else"},{"line_number":1916,"context_line":"        echo -e \"# Reset the no_proxy variables\\nexport no_proxy\u003d\"$no_proxy \u003e\u003e $TOP_DIR/localrc"},{"line_number":1917,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"baa201ad_5d1d8e65","line":1914,"in_reply_to":"baa201ad_6f855b06","updated":"2014-10-14 15:23:00.000000000","message":"if localrc cannot be changed, any proposed other way to pass the no_proxy setting to other processes?","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"cfce3dd9441599f7affc91423e70aeed9012f429","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"    # Save the no_proxy configuration in the localrc"},{"line_number":1913,"context_line":"    if [[ -n \"$(grep \u0027no_proxy\u0027 $TOP_DIR/localrc)\" ]]; then"},{"line_number":1914,"context_line":"        sed -i \"/no_proxy\u003d/c\\no_proxy\u003d$no_proxy\" $TOP_DIR/localrc"},{"line_number":1915,"context_line":"    else"},{"line_number":1916,"context_line":"        echo -e \"# Reset the no_proxy variables\\nexport no_proxy\u003d\"$no_proxy \u003e\u003e $TOP_DIR/localrc"},{"line_number":1917,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"baa201ad_6f855b06","line":1914,"in_reply_to":"baa201ad_a25a0a81","updated":"2014-10-13 18:09:56.000000000","message":"local.conf/localrc will not be changed","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"859c6c47e614d942b9441512a0b7e0f218eaf8d8","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"    # Add SERVICE_HOST"},{"line_number":1915,"context_line":"    if [ -n \"${no_proxy##*$SERVICE_HOST*}\" ]; then"},{"line_number":1916,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1917,"context_line":"    fi"},{"line_number":1918,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1919,"context_line":"}"},{"line_number":1920,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"5a890539_340e08e6","line":1917,"updated":"2014-11-14 07:18:49.000000000","message":"If no_proxy has to work on real multi node environment behind a proxy, there are few more parameters like GLANCE_HOST, HEAT_API_CFN_HOST, RABBIT_HOST, CINDER_SERVICE_HOST, etc., may also need to be included.\nAssume a scenario, where your Glance works on a separate host, then just SERVICE_HOST may not be enough","commit_id":"3898662aa2a4d3695eb7c3983f14634eb26a45a7"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"5daed0e193bb0335f30cb4d8d1409efc649e5dda","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"    # Add SERVICE_HOST"},{"line_number":1915,"context_line":"    if [ -n \"${no_proxy##*$SERVICE_HOST*}\" ]; then"},{"line_number":1916,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":1917,"context_line":"    fi"},{"line_number":1918,"context_line":"    export no_proxy\u003d$no_proxy"},{"line_number":1919,"context_line":"}"},{"line_number":1920,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"5a890539_052bf8eb","line":1917,"in_reply_to":"5a890539_340e08e6","updated":"2014-11-19 19:57:57.000000000","message":"didn\u0027t see any bug report on GLANCE_HOST, HEAT_API_CFN_HOST, RABBIT_HOST, CINDER_SERVICE_HOST. Do you have one?","commit_id":"3898662aa2a4d3695eb7c3983f14634eb26a45a7"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f16979eae978bff2a7636701745f5b8d90dc0e67","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"# Reset the no_proxy with the HOST_IP address"},{"line_number":2095,"context_line":"#"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"function export_no_proxy_variables {"},{"line_number":2098,"context_line":"    # Add localhost to no_proxy if no_proxy is empty"},{"line_number":2099,"context_line":"    if [[ -z \"$no_proxy\" ]]; then"},{"line_number":2100,"context_line":"        no_proxy\u003dlocalhost"}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"3a961159_de0e388c","line":2097,"updated":"2015-01-11 20:25:08.000000000","message":"Who calls this?","commit_id":"fcdf1910cc40fc514c75874436d90c25106f01db"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bc98a0a75e9d65377469e24d58dede4652b2e051","unresolved":false,"context_lines":[{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"function export_no_proxy_variables {"},{"line_number":2098,"context_line":"    # Add localhost to no_proxy if no_proxy is empty"},{"line_number":2099,"context_line":"    if [[ -z \"$no_proxy\" ]]; then"},{"line_number":2100,"context_line":"        no_proxy\u003dlocalhost"},{"line_number":2101,"context_line":"    elif [[ ! \"$no_proxy\" \u003d~ \"localhost\" ]]; then"},{"line_number":2102,"context_line":"        no_proxy\u003d$no_proxy,localhost"}],"source_content_type":"application/x-shellscript","patch_set":31,"id":"da86d52c_c5f384e5","line":2099,"updated":"2015-02-10 00:25:30.000000000","message":"i don\u0027t like the way this unconditionally exports no_proxy when it otherwise isn\u0027t set","commit_id":"3667a624b79ffd7ea0c8e30f67d28fbfad24e00e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7dba2933252e45a033869fd4f2d1b5d5d0d6b2ab","unresolved":false,"context_lines":[{"line_number":2102,"context_line":"        no_proxy\u003d$no_proxy,localhost"},{"line_number":2103,"context_line":"    fi"},{"line_number":2104,"context_line":"    # Add HOST_IP"},{"line_number":2105,"context_line":"    if [ -n \"${no_proxy##*$HOST_IP*}\" ]; then"},{"line_number":2106,"context_line":"        no_proxy\u003d$no_proxy,$HOST_IP"},{"line_number":2107,"context_line":"    fi"},{"line_number":2108,"context_line":"    # Add SERVICE_HOST"}],"source_content_type":"application/x-shellscript","patch_set":31,"id":"9a80dd14_1ddcd145","line":2105,"updated":"2015-03-06 16:49:58.000000000","message":"It isn\u0027t clear to me what the purpose of this exercise is.\n\nThe commit message indicates \"if they are not included already and then exporting the variable\". However the ## operator only compares for the word (here *$HOST_IP*) at the START of the parameter.\n\nhttp://www.gnu.org/software/bash/manual/bashref.html\n\nConsider this illustration:\n\n#!/bin/bash\n\nunset no_proxy\n\nH2\u003d192.168.40.20\nH1\u003d192.168.40.201\nH3\u003d192.168.40.20\n\nif [[ -z \"$no_proxy\" ]]; then\n    no_proxy\u003dlocalhost\nfi\n\nif [ -n \"${no_proxy##*H1*}\" ]; then\n    no_proxy\u003d$no_proxy,$H1\nfi\n\nif [ -n \"${no_proxy##*H2*}\" ]; then\n    no_proxy\u003d$no_proxy,$H2\nfi\n\nif [ -n \"${no_proxy##*H3*}\" ]; then\n    no_proxy\u003d$no_proxy,$H3\nfi\n\necho $no_proxy\n\n\namrith@homegw:~/sources$ source ./test.bash\nlocalhost,192.168.40.201,192.168.40.20,192.168.40.20\namrith@homegw:~/sources$\n\nNotice that the .20 address is added twice. That isn\u0027t ideal, I don\u0027t think.","commit_id":"3667a624b79ffd7ea0c8e30f67d28fbfad24e00e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"bc98a0a75e9d65377469e24d58dede4652b2e051","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"        no_proxy\u003d$no_proxy,$SERVICE_HOST"},{"line_number":2111,"context_line":"    fi"},{"line_number":2112,"context_line":"    # Add RABBIT_HOST"},{"line_number":2113,"context_line":"    if [ -n \"${no_proxy##*$RABBIT_HOST*}\" ]; then"},{"line_number":2114,"context_line":"        no_proxy\u003d$no_proxy,$RABBIT_HOST"},{"line_number":2115,"context_line":"    fi"},{"line_number":2116,"context_line":"    # Add CINDER_SERVICE_HOST"}],"source_content_type":"application/x-shellscript","patch_set":31,"id":"da86d52c_450874d9","line":2113,"updated":"2015-02-10 00:25:30.000000000","message":"I think this is going to fail with nounset if rabbit service isn\u0027t enabled","commit_id":"3667a624b79ffd7ea0c8e30f67d28fbfad24e00e"},{"author":{"_account_id":12403,"name":"Al Miller","email":"al.miller@ajmiller.net","username":"ajmiller"},"change_message_id":"34c1de078046b88e4eb56044cc7d66f2a2211cb3","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        fi"},{"line_number":1751,"context_line":"        "},{"line_number":1752,"context_line":"        # Add more IP addresses"},{"line_number":1753,"context_line":"        SERVICE_IPS\u003d\"$HOST_IP $SERVICE_HOST $RABBIT_HOST $GLANCE_HOST $HEAT_API_CFN_HOST $KEYSTONE_SERVICE_HOST $KEYSTONE_AUTH_HOST\""},{"line_number":1754,"context_line":"        for IP in $SERVICE_IPS; do"},{"line_number":1755,"context_line":"            if [[ -n $IP \u0026\u0026 ! \"$no_proxy\" \u003d~ \"$IP\" ]]; then"},{"line_number":1756,"context_line":"                no_proxy\u003d$no_proxy,$IP"}],"source_content_type":"application/x-shellscript","patch_set":34,"id":"9a80dd14_28adb9e9","line":1753,"updated":"2015-03-13 15:31:27.000000000","message":"This assumes that these services are defined centrally in the main devstack stack.sh.  What happens as devstack functionality is split out into repo-specific devstack plugins, like what was just done with neutron-lbaas?  How will any future services know to do this?  What will happen when some hapless future developer doesn\u0027t know about this and doesn\u0027t update this list.\n\nIt seems like if this idea is to fit in the devstack plugin model, it needs to delegate updating SERVICE_IPS to the code specific to each service.","commit_id":"407af30332353247ddecff07b42d701ac255371d"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"26aac976ec2ecadb18345ad21c1caa0b1c2bf15a","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"        fi"},{"line_number":1751,"context_line":"        "},{"line_number":1752,"context_line":"        # Add more IP addresses"},{"line_number":1753,"context_line":"        SERVICE_IPS\u003d\"$HOST_IP $SERVICE_HOST $RABBIT_HOST $GLANCE_HOST $HEAT_API_CFN_HOST $KEYSTONE_SERVICE_HOST $KEYSTONE_AUTH_HOST\""},{"line_number":1754,"context_line":"        for IP in $SERVICE_IPS; do"},{"line_number":1755,"context_line":"            if [[ -n $IP \u0026\u0026 ! \"$no_proxy\" \u003d~ \"$IP\" ]]; then"},{"line_number":1756,"context_line":"                no_proxy\u003d$no_proxy,$IP"}],"source_content_type":"application/x-shellscript","patch_set":34,"id":"9a80dd14_f05a684e","line":1753,"in_reply_to":"9a80dd14_28adb9e9","updated":"2015-03-16 13:11:12.000000000","message":"any suggestion?","commit_id":"407af30332353247ddecff07b42d701ac255371d"}],"stack.sh":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"528ecb21d8f183f4cbaae150e6ab3cf9f5bc8be2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# Local Settings"},{"line_number":165,"context_line":"# --------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":168,"context_line":"export_proxy_variables"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Remove services which were negated in ENABLED_SERVICES"}],"source_content_type":"text/x-sh","patch_set":18,"id":"baa201ad_7e665a52","side":"PARENT","line":167,"updated":"2014-10-08 16:19:29.000000000","message":"Why do you move these lines ?","commit_id":"552459cbccf12473c5734f92b034c8f2464a4069"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"d4d36641185e6184e36686ccac90b66fc36056ac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# Local Settings"},{"line_number":165,"context_line":"# --------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":168,"context_line":"export_proxy_variables"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Remove services which were negated in ENABLED_SERVICES"}],"source_content_type":"text/x-sh","patch_set":18,"id":"baa201ad_4abe30af","side":"PARENT","line":167,"in_reply_to":"baa201ad_7e665a52","updated":"2014-10-08 18:56:05.000000000","message":"good point. it is moved because some parameters are set after this line. i\u0027ll have a check. if there is no impact, i\u0027ll remove this change.","commit_id":"552459cbccf12473c5734f92b034c8f2464a4069"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"8a26324aa26d1c710cb82db5bfdce7e9efadd564","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# Local Settings"},{"line_number":165,"context_line":"# --------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":168,"context_line":"export_proxy_variables"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Remove services which were negated in ENABLED_SERVICES"}],"source_content_type":"text/x-sh","patch_set":18,"id":"baa201ad_8471d6e2","side":"PARENT","line":167,"in_reply_to":"baa201ad_7e665a52","updated":"2014-10-09 13:29:02.000000000","message":"the HOST_IP is configured at line 488. in order to add HOST_IP into the no_proxy parameter, this line has to be moved down after the line 488.","commit_id":"552459cbccf12473c5734f92b034c8f2464a4069"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"780772a5f30fa1324a087c1f36507d635e2c1ed3","unresolved":false,"context_lines":[{"line_number":508,"context_line":"fi"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":511,"context_line":"export_proxy_variables"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":514,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":19,"id":"baa201ad_53eeb9b5","line":511,"updated":"2014-10-10 10:07:28.000000000","message":"I got why this was moved to the bottom.  But now, my question is : what if the package installed before L511 needs a proxy_server ? I mean there\u0027s a lot of package installed between L167 and L511.","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"c634173dbc90ba8121493ac63b0082d942a08f37","unresolved":false,"context_lines":[{"line_number":508,"context_line":"fi"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":511,"context_line":"export_proxy_variables"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":514,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":19,"id":"baa201ad_9d4d3675","line":511,"in_reply_to":"baa201ad_4244feb6","updated":"2014-10-14 15:23:00.000000000","message":"thank. will update it soon","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"f325d8a885ff14226fa1fdf115aaee083ca00262","unresolved":false,"context_lines":[{"line_number":508,"context_line":"fi"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":511,"context_line":"export_proxy_variables"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":514,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":19,"id":"baa201ad_a6479e4a","line":511,"in_reply_to":"baa201ad_53eeb9b5","updated":"2014-10-10 14:43:24.000000000","message":"in my test, it does work fine. the system proxy needs to be configured before the installation. \nI can do more testing to see if there is a problem. \nthe other alternative is to reset the no_proxy at L511 only. and keep the proxy parameter at L167. \nwhat do you think?","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f8682c277d7523e347be72c9f6e23ee958fb27b1","unresolved":false,"context_lines":[{"line_number":508,"context_line":"fi"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"# Make sure the proxy config is visible to sub-processes"},{"line_number":511,"context_line":"export_proxy_variables"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":514,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"}],"source_content_type":"text/x-sh","patch_set":19,"id":"baa201ad_4244feb6","line":511,"in_reply_to":"baa201ad_a6479e4a","updated":"2014-10-13 08:04:01.000000000","message":"Yeah, the \"other alternative\" seems safe.","commit_id":"547f73d200a123d04d6b4f4f99cce0ca724c4cb2"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"859c6c47e614d942b9441512a0b7e0f218eaf8d8","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Make sure the no_proxy config is visible to sub-processes"},{"line_number":514,"context_line":"export_no_proxy_variables"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":517,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a890539_f439e0a4","line":515,"updated":"2014-11-14 07:18:49.000000000","message":"Why can\u0027t we use the existing \"export_proxy_variables\" instead of a new method. I can see moving \"export_proxy_variables\" call from the existing position to your current \"export_no_proxy_variables\" may not create any problem.","commit_id":"3898662aa2a4d3695eb7c3983f14634eb26a45a7"},{"author":{"_account_id":11226,"name":"Zu Qiang","email":"QIANG.ZU@GMAIL.COM","username":"zuqiang"},"change_message_id":"5daed0e193bb0335f30cb4d8d1409efc649e5dda","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"# Make sure the no_proxy config is visible to sub-processes"},{"line_number":514,"context_line":"export_no_proxy_variables"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"# Allow the use of an alternate hostname (such as localhost/127.0.0.1) for service endpoints."},{"line_number":517,"context_line":"SERVICE_HOST\u003d${SERVICE_HOST:-$HOST_IP}"},{"line_number":518,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a890539_a5f4e487","line":515,"in_reply_to":"5a890539_f439e0a4","updated":"2014-11-19 19:57:57.000000000","message":"this is to avoid any possible problems.","commit_id":"3898662aa2a4d3695eb7c3983f14634eb26a45a7"}]}